D27182: [applets/taskmanager] Clean up Tooltip code

broulik added inline comments. INLINE COMMENTS > ToolTipInstance.qml:151 > +icon.name: "window-close" > +icon.width: units.iconSizes.small > +icon.height: units.iconSizes.small Can we please get this fixed in `PlasmaComponents3` - this is being set all over t

D27184: Use real Kirigami Separators instead of blue rectangles

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Using the correct element is more sementically correct and looks better

D27183: Port Application Page's form layout to Kirigami FormLayout

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This simplifies the code, allows the layout to have a mobile-appropriat

D27182: [applets/taskmanager] Clean up Tooltip code

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The ToolTip code was kind of messy. This patch adjusts it to use modern Layouts, fixes some

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75077. cblack added a comment. Use toolbutton (for initial visual feedback; need to apply colour scheme as to prevent legibility issues) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75076&id=75077 B

D27138: [Applet]Display device name if more than one devices

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Any objections? REPOSITORY R115 Plasma Audio Volume Applet BRANCH devicesCount (branched from master) REVISION DETAIL https://phabricator.kde.org/D27138 To: gvgeo, #plasma, #vdg,

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ngraham added a comment. Yeah at least with text on the side, tabs won't work at all for smaller sizes, such as in the system tray: F8087543: Screenshot_20200205_193710.png That's with just two sources! If the text were on the bottom and it was

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ndavis added a comment. Looks like my previous comment is obsolete. I think tabs are more convenient than a combo box in this case, but I'm not sure this is the best use of tabs. AFAIK, we never use tabs as an actual selection control anywhere, so this behavior is unexpected. Or are the

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75076. cblack added a comment. Fix plasmashell freeze REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75075&id=75076 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL https://ph

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ndavis added a comment. I don't think putting the source selector on the bottom is better. It moves the buttons farther away from where the mouse would be when opening the widget on a default panel. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To:

D27142: Have authhelper define config file paths on its own

davidedmundson added a comment. Yes REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH decoupled-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, j

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75075. cblack marked an inline comment as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75025&id=75075 BRANCH media-plasmoid-relayout (branched from ma

D27142: Have authhelper define config file paths on its own

filipf added a comment. 5.18 then, right? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH decoupled-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D26813: Have user-manager write to SDDM's new config file

filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in accountmodel.cpp:45 > ideally we want the exact same code as the other place > > load /etc/sddm.conf > loop through /etc/sddm.conf.d > add all those files as config sources Seems doable, just not sure what to have this conf

D27161: Add support for static platformtheme plugins

masonm planned changes to this revision. masonm added a comment. I think there's issues with this. I had assumed it is fine to load static plugins regardless of from where, but in my testing there are issues so I think this needs to be an "either or" scenario instead of allowing static/dynami

D27166: Refactor converter runner

alex added a reviewer: sitter. alex marked an inline comment as done. alex added a comment. The regex has been implemented and the code is now ~100 lines shorter but provides the same functionality and the few remaining utility functions have been moved to the runner class. This should al

D27166: Refactor converter runner

alex updated this revision to Diff 75064. alex added a comment. Use Regex for query parsing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=75039&id=75064 BRANCH converter_runner_refactoring (branched from master) REVISION DETAIL https:/

D27170: delay show window

This revision was automatically updated to reflect the committed changes. Closed by commit R124:e63bb075db8d: delay show window (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27170?vs=75054&id=75063 REVISION DETAIL https://phabric

D27155: libnotificationmanager : add app-specific kconfig settings

crossi planned changes to this revision. crossi added a comment. Will remove the defaults and rely on the rules file. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27155 To: crossi, ervin, broulik, bport, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren

D27170: delay show window

ngraham added a comment. 5.18? REPOSITORY R124 System Settings BRANCH phab/delaystart REVISION DETAIL https://phabricator.kde.org/D27170 To: mart, #plasma, sitter Cc: ngraham, sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragr

D27170: delay show window

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. sounds reasonable. works for me as well REPOSITORY R124 System Settings BRANCH phab/delaystart REVISION DETAIL https://phabricator.kde.org/D27170 To: mart, #plasma, sitter Cc: sitte

D27159: Moved the header to the bottom

ngraham added a comment. There's a more exhaustive change in D26806: [Applets/Power Manager] Update layout based on T10470 already; perhaps we should focus our efforts there? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D27170: delay show window

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY show the window only after mainWidget() of the view has been called. mainWidget creates the ui on demand,

KUserFeedback 1.0.0

KUserFeedback is a framework for collecting user feedback for applications via telemetry and surveys. The library comes with an accompanying control and result UI tool. https://download.kde.org/stable/kuserfeedback/ Signed by Jonathan Riddell 2D1D5B0588357787DE9EE225EC94D18F7F05997E

D27165: [krdb] Hardcode Breeze default in kde4 migration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0e4eaf013fb5: [krdb] Hardcode Breeze default in kde4 migration (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27165?vs=75038&id=75049

D27166: Refactor converter runner

alex added a comment. Thanks for the quick answer, I will adjust the code/copyright. The reason I moved the functions to new files is that the runner file was really big and after splitting it up it was working well and the code was more readable/maintainable. But I wanted to wait befo

D27166: Refactor converter runner

sitter added a comment. Oh and seeing as you largely split out existing code you should preserve Petri's copyright in all files. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27166 To: alex, broulik, ngraham, #plasma Cc: sitter, plasma-devel, Orage, LeGast00

D27166: Refactor converter runner

sitter added a comment. Please make a cpps for you headers and move the function implementations there. +1 to regex INLINE COMMENTS > converter_utilities.h:23 > + > +double stringToDouble(const QStringRef &value, bool *ok, const QLocale > &locale) > +{ Perhaps I am missing something b

D27138: [Applet]Display device name if more than one devices

gvgeo added a comment. No response, I believe this patch can continue. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27138 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: cgiboudeaux, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. I 'll wait for response about the alignment before I update test plan too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, pla

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 721 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/721/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 05 Feb 2020 11:27:10 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 433 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/433/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 05 Feb 2020 11:27:11 + Build duration: 12 min and counting JUnit Tests Name: projectr

D27166: Refactor converter runner

alex added a comment. While I was refactoring this project I haven't changed the string parsing logic itself. What do you think about changing the parsing process using a regex, for example to the regex from https://regex101.com/r/EUDzQi/7. This can make the parsing process/adding

Dropping KRDB

Hi all, in plasma-desktop we have this wonderful class called KRDB which syncs Plasma settings to various other toolkits, including "KDE4". Since it is not a library but just compiled into half the KCMs, changing it always requires a tonne of CMake adjustments all over the place. More import

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

crossi added inline comments. INLINE COMMENTS > fonts.cpp:201 > +Q_ASSERT(dpiItem && dpiWaylandItem && antiAliasingItem); > +if (dpiItem->isSaveNeeded() || dpiWaylandItem->isSaveNeeded() || > antiAliasingItem) { > +emit aliasingChangeApplied(); antiAliasingItem->isSaveNeeded() ?

D27166: Refactor converter runner

alex created this revision. alex added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The logic from the converter runner has been refactored and moved to seperate files. Additional

D27165: [krdb] Hardcode Breeze default in kde4 migration

broulik created this revision. broulik added reviewers: Plasma, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With the KConfigXT changes, the default isn't written anymore, so it wouldn't sync the def

D26709: add gpu entry to about system

This revision was automatically updated to reflect the committed changes. Closed by commit R102:55912f121c61: add gpu entry to about system (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26709?vs=74250&id=75036#toc REPOSITORY R102 KInfoCenter CHANGES SINCE LAST U

D26785: cleanup devinfo header includes

This revision was automatically updated to reflect the committed changes. Closed by commit R102:8fe51fbe76fc: cleanup devinfo header includes (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26785?vs=73925&id=75034 REVISION DETAIL ht

D26667: refactor about-distro to more generically support textual dumps

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R102:4b4f6a3f9639: refactor about-distro to more generically support textual dumps (authored by sitter). CHANGED PRIOR TO C

D27159: Moved the header to the bottom

broulik added a comment. Same issue as with notifications: the `PowerManagementItem` shows inhibition info and other state, which makes the position of the checkbox non-deterministic REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27159 To: niccolove, #vdg

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

broulik added a comment. When there is no player it completely falls apart. It also doesn't work when there is no album art. The fallback player icon is gone. F8086262: Screenshot_20200205_093259.PNG The line spacing also seems a little excessive.

D27143: moved do not disturb to the bottom

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. My biggest gripe with merely moving the controls to the bottom is that many plasmoids show additional information in the header, which will cause the controls to shift around an

D27155: libnotificationmanager : add app-specific kconfig settings

broulik added a comment. Not a fan of all that code in the `default` part. The idea was to install a rules file by default (like libtaskmanager does) which can then be tweaked and/or overridden. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27155 To: cro