ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY The ToolTip code was kind of messy. This patch adjusts it to use modern Layouts, fixes some binding loops, reduces redundancy, adds comments, and ports almost everything to PlasmaComponents3. We still need PC2 for `Highlight` so it can't be removed entirely. There is only one unavoidable visual change, which was made in this patch because it is consistent with the latest VDG mockup (T12640 <https://phabricator.kde.org/T12640>): the blurred album art background no longer goes under the player controls bar. This simplifies the code substantially, and as the mockup shows, it just looks better anyway (IMO). This is not intended to fully implement the mockup in T12640 <https://phabricator.kde.org/T12640>. TEST PLAN Everything looks the same, except for this: F8087660: Peek 2020-02-05 21-49.webm <https://phabricator.kde.org/F8087660> REPOSITORY R119 Plasma Desktop BRANCH clean-up-tooltip-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D27182 AFFECTED FILES applets/taskmanager/package/contents/ui/ToolTipInstance.qml To: ngraham, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
