D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74347. gvgeo added a comment. Need specific width for columns in FLow. Changed maximumWidth to preferredWidth. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74322&id=74347 BRANCH b3 (branched from m

D26911: Align SpinBox text with LineEdit text

ndavis abandoned this revision. ndavis added a comment. Whoops, this problem doesn't actually exist in git master, I must have caused it while trying to fix another problem. I was so sure of myself... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26911 To: ndavis, #

D26911: Align SpinBox text with LineEdit text

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The SpinBox edit field didn't have the right horizontal alignment and the math using the

D25273: Enable selecting all installed color schemes in Cuttlefish

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Bad combobox width strikes again (https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon: F7939162: Screenshot_20200124_204922.PNG

D26892: Switch to the old-style button text for the KNSQuick buttons

aacid added a comment. stable branch please :) REPOSITORY R119 Plasma Desktop BRANCH restore-old-style-kns-button-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D26892 To: leinir, #plasma, davidedmundson Cc: aacid, yurchor, davidedmundson, kde-i18n-doc, gikari

D25584: [TabBar] Remove frame

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:2ecfa27b0af0: [TabBar] Remove frame (authored by filipf). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES

D26799: Apply KDE coding style, minor optimizations

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. emit and Q_EMIT are the same thing, I wouldn't change any future instances Q_EMIT has the advantage of not conflicting with some other libraries like emit sometimes can

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, O

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. In D26582#600469 , @hein wrote: > So does this fall through to the dialog when the type hasn't been determined Any file has always one mime type : "application/octet-stream", but KRun generally resolves mimetype thr

D26038: feat(kcm): add option for auto rotation

sasch added a comment. Don't want to spam here, pretty cool. However, I don't see the orientation part within settings on the latest daily opensuse Kryption (Plasma 5.18.80) in a wayland session ( https://phabricator.kde.org/file/data/3sk75xlk4g762d3dvdep/PHID-FILE-uuwpwd636vbjefesyjb7/previ

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

hein added a comment. So does this fall through to the dialog when the type hasn't been determined? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, j

D26904: Use Qt5 syntax for signal, rename files

alex created this revision. alex added reviewers: mlaurent, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The signal in the SonnetSpellCheckingModule constructor now uses the Qt5 syntax and the m

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre added a comment. Ping since system theme support is now in frameworks and plasma master can depend on frameworks master REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25273 To: davidre, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-D

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre updated this revision to Diff 74332. davidre added a comment. - remove default color scheme, system theme support in kcolorschememanager, also display icons REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=69667&id=74332 BRANCH colorsc

D26861: [Applet/Task Manager] Move audio indicator to the corner

filipf added a comment. Well I tested this with several themes and it looks just fine on all of them except Sweet. A #plasma person should have a look at the code, but visually and usability-wise this is pretty good. REPOSITORY R119 Plasma Desktop

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalouka

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

ngraham added a comment. Wasn't this already fixed with D26772 ? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-De

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

ngraham added a comment. Ah, looks like it landed on the stable branch but was never merged to master. Just did that. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage, LeGast00

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. ping :) @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. Gentle ping dear reviewers. INLINE COMMENTS > recentdocuments.cpp:69 > +| Agent::any() > +| Url("/*/" + term + "*") > +| Limit(30); Request for now is limited, it will need some work in KActivityStats to be more clever REPOSITORY

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, mart. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN - Make the kscreenlocker shortcut empty - Try opening systemsettings -> workspace behaviour, it crashes - Apply

D26806: [Applets/Power Manager] Update layout based on T10470

davidedmundson added inline comments. INLINE COMMENTS > gvgeo wrote in BatteryItem.qml:112 > This does not react to preferredWidth, minimumWidth or maximumWidth. Is it > really managed by Layout? It's not Flow isn't a layout. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

Re: Long press global shortcuts

On Sun, Jan 12, 2020 at 6:11 PM Aleix Pol wrote: > > Hi, > In a discussion some weeks ago, we came to the conclusion that it > would make sense to support long press global shortcuts. > > The use-case we discussed back then was the power button on the Plasma > phone. We need to have 2 actions upon

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo marked 5 inline comments as done. gvgeo added a comment. After some effort, I reached in these conclusions: 1.Is not that big of a problem to specify width in a layout. The big problem is specifying preferredWidth and height in the same item. Breaks the dimensions, this is what got me

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74322. gvgeo added a comment. Remove as much as I could width and height settings. Removed loader. Moved instead flow in place. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74314&id=74322 BRANCH b

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham accepted this revision. ngraham added a comment. Yeah, it won't be perfect for everything, but I think it's better than what we have right now and fixes the bug. Is everyone okay with this? REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL

D26271: [Applet]Update layout based on T10470

manueljlin accepted this revision. manueljlin added a comment. Nice, looks great! About the stream name, it doesn't look like it's useful most of the time so it might be better to remove it REPOSITORY R115 Plasma Audio Volume Applet BRANCH layout2 (branched from master) REVISION DETAIL

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > MenuModel.cpp:26 > #include "MenuItem.h" > - > +#include > not needed > ModuleView.cpp:349 > if (activeModule) { > - > KActivities::ResourceInstance::notifyAccessed(QUrl(QStringLiteral("kcm:") + > activeModule->moduleInfo().servic

D26881: [Applets/Folder View] Allow using a folder that ends with a space

anthonyfieroni added a comment. If url ends with more than one space? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalouka

D26806: [Applets/Power Manager] Update layout based on T10470

davidedmundson added inline comments. INLINE COMMENTS > BatteryItem.qml:48 > +spacing: units.smallSpacing > +width: leftColumnWidth + spacing + rightColumnWidth > width used inside a layout > BatteryItem.qml:57 > height: implicitHeight > +width

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74314. gvgeo added a comment. Don't show suppression messages if PM is disabled. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74262&id=74314 BRANCH b3 (branched from master) REVISION DETAIL https

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari added a comment. In D26891#600210 , @fvogt wrote: > It should only do the migration once, like the kconf_update script. From where migration script is launched? Can the migration script itself be a standalone entity, that uses kded

D26896: Kill the KinfoCenter binary

ngraham added a comment. In D26896#600258 , @broulik wrote: > Would it make sense to keep a `kinfocenter` script that just launchers `systemsettings5 -i` for compat? > Does it still show up if you type "kinfocenter" into KRunner, not sure if

D26881: [Applets/Folder View] Allow using a folder that ends with a space

broulik added a comment. That's somewhat oddly spcific, isn't it? I'd be surprised that `fromLocalFile` strips trailing spaces? :0 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, Th

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. In D26891#600264 , @gikari wrote: > In D26891#600210 , @fvogt wrote: > > > If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari marked 3 inline comments as done. gikari added a comment. In D26891#600210 , @fvogt wrote: > If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/mai

D26896: Kill the KinfoCenter binary

broulik added a comment. Would it make sense to keep a `kinfocenter` script that just launchers `systemsettings5 -i` for compat? Does it still show up if you type "kinfocenter" into KRunner, not sure if it uses the `Exec` for that if this name is in the desktop file somewhere other than th

D26895: Introduce an Info Center mode

davidedmundson added inline comments. INLINE COMMENTS > SettingsBase.h:48 > +// This has effect only if set right after the ctor > +void setInfoCenterMode(bool set); > bool queryClose() override; why not an arg in the ctor then? > SettingsBase.h:95 > +MenuItem * homeModule = nu

D26896: Kill the KinfoCenter binary

davidedmundson added a comment. Assuming the other gets in, ship it! INLINE COMMENTS > CMakeLists.txt:25 > Crash > DBusAddons > DocTools We can probably get rid of at least this. Maybe quite a few others REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde

D26895: Introduce an Info Center mode

broulik added a comment. Great idea! INLINE COMMENTS > SettingsBase.h:100 > KAboutApplicationDialog * aboutDialog = nullptr; > +bool m_infoCenterMode = false; > }; I would prefer this to be an enum > main.cpp:66 > +if (infoCenterMode) { > +QCoreApplication::setApplicat

D26896: Kill the KinfoCenter binary

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Remove the binary, only install the modules and categories. The categories have been reorganized a bit to

D26895: Introduce an Info Center mode

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY withthe command line switch -i, start systemsettings loading the KInfoCenter modules and hyerarchy instea

D26894: Enable publication of API dox on api.kde.org

zzag added inline comments. INLINE COMMENTS > zzag wrote in metainfo.yaml:1 > I think Martin didn't step down officially. "officially" REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D26894 To: kossebau, #kwin Cc: zzag, plasma-devel, Orage, LeGast00n,

D26894: Enable publication of API dox on api.kde.org

zzag added a comment. +1 > So, is kdecoration still a non-deprecated lib? Yes, KDecoration2 is a non-deprecated lib. INLINE COMMENTS > metainfo.yaml:1 > -maintainer: graesslin > description: Plugin based library to create window decorations. I think Martin didn't step down officia

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. If this is adjusted to include the migration code for older breeze-like GTK themes from https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa, it should be possible to drop the kconf_update script there. It might e

D26892: Switch to the old-style button text for the KNSQuick buttons

yurchor added a comment. No objections for porting into the stable branch from the Ukrainian team. REPOSITORY R119 Plasma Desktop BRANCH restore-old-style-kns-button-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D26892 To: leinir, #plasma, davidedmundson Cc:

D26894: Enable publication of API dox on api.kde.org

kossebau added a comment. I stumbled over that metainfo.yaml file and was wondering whether this would not be a lib that wants to be covered an api.kde.org. So, is kdecoration still a non-deprecated lib? If so, this change should trigger addition of KDecoration on api.kde.org, similar like

D26797: KCM/Component Refactor UI to a single list of combobox

meven added inline comments. INLINE COMMENTS > broulik wrote in componentchooseremail.cpp:149 > So here you do show an `entryPath` but not in the other components? For email I have a slightly more advanced logic to read and display the "Added Associations" section of mimeapps.list and add it to

D26894: Enable publication of API dox on api.kde.org

kossebau created this revision. kossebau added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R129 Window Decoration Library BRANCH addtoapikdeorg REVISION DETAIL https://phabricator.kde.org/

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74304. meven marked 11 inline comments as done. meven added a comment. - Make CfgPlugin a QComboBox with default and currently saved index handling - General code improvements : in loops, naming... - set the minimal width of combobox 18 making them most o

D26847: Hide irrevelevant default button, code clean and future proofing

meven added a comment. In D26847#600133 , @rikmills wrote: > Fails to build: > > https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console > > 00:42:51 /workspace/build/src/usermanager.cpp: In constructor ‘User

D26893: Fix a building issue

meven created this revision. meven added reviewers: Plasma, ngraham, rikmills. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Build regression introduced in D26847 https

D26870: [ksgrd] Drop a QWidget dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R111:d7a5f72c7a69: [ksgrd] Drop a QWidget dependency (authored by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26870?vs=74238&id=74302 REVI

D26892: Switch to the old-style button text for the KNSQuick buttons

davidedmundson added subscribers: kde-i18n-doc, davidedmundson. davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Which branch? I don't have a strong opinion, that's something that needs @kde-i18n-doc to decide REPOSIT

D26892: Switch to the old-style button text for the KNSQuick buttons

gikari added a comment. This also should be changed in GTK Subpage in Application Style KCM (D26717 ) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26892 To: leinir, #plasma Cc: gikari, plasma-devel, Orage, LeGast00n, The

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari added inline comments. INLINE COMMENTS > fvogt wrote in gtkconfig.h:76 > Where are those methods called from? `GtkConfig::applyAllSettings()`? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari, fvogt Cc: plasma-devel, Orage, LeG

D26892: Switch to the old-style button text for the KNSQuick buttons

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This fixes a series of localization issues as reported in https://bugs.kde.org/show_bug.cgi?id=415541 based on the minimum-impact

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added inline comments. INLINE COMMENTS > gtkconfig.h:76 > > +void setDefaultGtk2Theme() const; > +void setDefaultGtk3Theme() const; Where are those methods called from? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari,

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY BUG: 416635 FIXED-IN: 5.18.0 TEST PLAN 1. Remove `gtk-theme-name=` line in `~/.gtkrc-2.0` file 2. Restart `kded5`, `gtk-theme-n

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. Never going to be correct. Sometimes the highlight touches the edges, other times have big margins. The aim was to avoid getting out of the svg frame. These changes focus even more on the breeze theme. Sweet theme has some issues. F7927628: Screenshot_2020012

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo updated this revision to Diff 74298. gvgeo added a comment. Change line order. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26861?vs=74297&id=74298 BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 A

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo updated this revision to Diff 74297. gvgeo added a comment. This revision is now accepted and ready to land. Increase right margins by 1.2 when need, to avoid highlight area been drawn out of the frame. Various little changes. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDAT

D26847: Hide irrevelevant default button, code clean and future proofing

rikmills added a comment. Fails to build: https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console 00:42:51 /workspace/build/src/usermanager.cpp: In constructor ‘UserManager::UserManager(QWidget*, const QVariantList&)’: 00:42:51 /workspace/build/src/use

D26760: Update from Plasma for ToolTipInstance.qml

This revision was automatically updated to reflect the committed changes. Closed by commit R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=74260&id=74296 REVISION DE