meven added inline comments. INLINE COMMENTS
> broulik wrote in componentchooseremail.cpp:149 > So here you do show an `entryPath` but not in the other components? For email I have a slightly more advanced logic to read and display the "Added Associations" section of mimeapps.list and add it to the list of choices. I did this because at least for thunderbird, when it set itself as default browser it creates a new entry to "Added Associations" and use this new entry as choice in "Default Applications". But this new application service has no icon defined, so a user would be confused to see two entries for Thunderbird in the list, one with the icon which is not selected. I meant here to display something to the user to help distinguish between the two. I may want to reconsider and simply add whatever service is in Default Application and display it, ignoring entries in "Added Associations", as I do elsewhere. REPOSITORY R119 Plasma Desktop BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.org/D26797 To: meven, #plasma, #vdg, ngraham, ervin Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
