D25100: Mark all wallpaper plugins as addons

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. In D25100#592375 , @mak wrote: > @ngraham Did this have AppStream metadata before? Probably the distribution data still lists this as component, while the new file lists it as addon. The distro data is preferred, so that

D25100: Mark all wallpaper plugins as addons

2020-01-11 Thread Matthias Klumpp
mak added a comment. Did this have AppStream metadata before? Probably the distribution data still lists this as component, while the new file lists it as addon. The distro data is preferred, so that's why this shows up as app. You need your distro to ship this as update, or set `PreferLocal

D25100: Mark all wallpaper plugins as addons

2020-01-11 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Seems like this isn't the right way to solve the problem. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngraham, apol, mak, #plasma Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-F

D19947: systray: show a small animation on the icons when activated

2020-01-11 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:27fa3f7e0c35: systray: show a small animation on the icons when activated (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19947?vs=62799

D25375: Start of the accessibility KCM

2020-01-11 Thread Carson Black
cblack added a comment. F7878328: image.png If you're going to do this faux sidebar thing, why not just split the accessibility KCM into multiple KCMs so it can use the proper system settings sidebar? REPOSITORY R119 Plasma Desktop REVISION DETA

D25375: Start of the accessibility KCM

2020-01-11 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > tcanabrava wrote in kcmaccess.cpp:194 > care to elaborate? This is old code and I haven't touched it. In that case, I can submit a separate patch to use glib instead of the gsettings command line interface. REPOSITORY R119 Plasma Desktop REVIS

D26598: Drop unused method

2020-01-11 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It's not used anywhere TEST PLAN builds REPOSITORY R122 Powerdevil B

D26570: Improve Plasma user feedback introspection

2020-01-11 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 73315. apol added a comment. Async load REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73227&id=73315 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26570 AFFECTED FILES kcms/feedback

D26392: Add option to easily configure and start a hotspot

2020-01-11 Thread Nathaniel Graham
ngraham added a subscriber: cblack. ngraham added a comment. In D26392#592133 , @jgrulich wrote: > Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that i

D26572: Always render checkbox/radiobutton background

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. Hugely improved visibility with this patch: F7878198: Screenshot_20200111_160828.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26572 To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham Cc:

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. I notice that this also has the effect of changing the button texts to not have ellipses on the end. I guess `NewStuff.Button` needs to do that itself? Works great BTW. A big improvement! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. This patch makes plasma-desktop fail to build without the dependent KNS framework change. That means that the KNS change is in fact a hard dependency and therefore this functionality can't make it into 5.18 with the patch's current state. If you want it for 5.18 (as

D26583: [Application Style] Add GTK Application Style Page

2020-01-11 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 73313. gikari added a comment. Remove unnessary include and `containsTheme` function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73272&id=73313 BRANCH gtk-style-page REVISION DETAIL https://phabr

D26572: Always render checkbox/radiobutton background

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. In D26572#592280 , @hpereiradacosta wrote: > I would prefer not systematically render the background, because it might break existing applications, like rendering a widget on top of a painted image. In fact that

D26572: Always render checkbox/radiobutton background

2020-01-11 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. I would prefer not systematically render the background, because it might break existing applications, like rendering a widget on top of a painted image. Also this goes against Qt's rendering model which does not require rendering widget background, relying o

D26593: Remove GTK KCM

2020-01-11 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY After D26583 GTK KCM is no longer needed, the functionality is now in Application Style KCM. A

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-11 Thread Алексей Шилин
aleksejshilin added a comment. In D26582#591959 , @meven wrote: > Well there was already KRun::setRunExecutables :) I've already talked about it in my previous message: In D26582#591952 , @al

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. That seems reasonable to me as a path forward. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, za

D26261: Rewrite GTK KCM

2020-01-11 Thread Mikhail Zolotukhin
This revision was automatically updated to reflect the committed changes. Closed by commit R99:1ebf620d361f: Rewrite GTK KCM (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26261?vs=73065&id=73307 REVISION DETAIL https:

D26592: [GTK3] Fix Chromium maximized maximize button

2020-01-11 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:47b9a1f073db: [GTK3] Fix Chromium maximized maximize button (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26592?vs=73303&id=73305 REVIS

D26592: [GTK3] Fix Chromium maximized maximize button

2020-01-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixed, thanks. While you're touching Chromium headerbar button styling, maybe you could also fix https://bugs.kde.org/show_bug.cgi?id=414591. REPOSITORY R98 Breeze for Gtk BRANCH fix

D26592: [GTK3] Fix Chromium maximized maximize button

2020-01-11 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Chromium now uses the restore icon instead of the maximize icon when maximized. TEST PLAN Bef

D26591: [GTK3] Fix treeview hover colour

2020-01-11 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:9d9768fe98b0: [GTK3] Fix treeview hover colour (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26591?vs=73299&id=73300 REVISION DETAIL

D26591: [GTK3] Fix treeview hover colour

2020-01-11 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Treeviews now reflect the Qt theme more accurately when hovering items. BUG: 414263 FIXED-

D26392: Add option to easily configure and start a hotspot

2020-01-11 Thread Aleix Pol Gonzalez
apol added a comment. Otherwise lgtm INLINE COMMENTS > networkmodel.cpp:517 > NetworkModelItem *originalItem = nullptr; > - > for (NetworkModelItem *item : > m_list.returnItems(NetworkItemsList::Connection, connection)) { unrelated change. REPOSITORY R116 Plasma Network Managem

D26392: Add option to easily configure and start a hotspot

2020-01-11 Thread Aleix Pol Gonzalez
apol added a comment. In D26392#588345 , @jgrulich wrote: > In D26392#587159 , @mthw wrote: > > > @apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi net

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Fixed!

2020-01-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/140/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 19:28:02 + Build duration: 18 min and counting JUnit Tests Name: project

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 141 - Fixed!

2020-01-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/141/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 19:28:01 + Build duration: 15 min and counting JUnit Tests

D26392: Add option to easily configure and start a hotspot

2020-01-11 Thread Jan Grulich
jgrulich added a comment. Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that is in few days. @ngraham how is it going with the icon? REPOSITORY R116 Plasma Network Management Applet REVISION DET

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Nicolas Fella
nicolasfella added a comment. I'm not against keeping the separators, but the button to en/disable the whole section seems overkill to me. Chances are that the set of entries you want to have does not exactly align with the categories anyway REPOSITORY R120 Plasma Workspace REVISION DETAI

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. I agree that separating the list into categories makes it a lot less visually overwhelming to look at. If @nicolasfella was saying that maybe we could remove the feature that allows disabling all elements within a section at once, that I might be able to get behind.

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Failure!

2020-01-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/139/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:04:49 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT Starte

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 140 - Failure!

2020-01-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/140/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 11 Jan 2020 18:04:49 + Build duration: 1 hr 0 min and counting CONSOLE OUTPU

D22382: Add global shortcuts for switching to the previous/next activity

2020-01-11 Thread Christian Muehlhaeuser
muesli added a comment. While waiting for that separate discussion and decision, does anyone mind if I land this _without_ default shortcuts set? At least it enables people to switch to the previous/next activity when they configure a shortcut manually. Currently that's not possible, as

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Noah Davis
ndavis added a comment. In D26587#592088 , @broulik wrote: > Hmm this makes inactive tabs even harder to spot than already :/ There's really not much we can do about Chromium when every Electron app uses the custom CSS we have for Chromiu

D26261: Rewrite GTK KCM

2020-01-11 Thread Carson Black
cblack accepted this revision. cblack added a comment. No complaints here. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-theme-through-kded REVISION DETAIL https://phabricator.kde.org/D26261 To: gikari, apol, #vdg, ngraham, cblack Cc: cblack, baberts, ngraham, plasma-devel, LeG

D25449: Start of the new Formats KCM

2020-01-11 Thread Arjen Hiemstra
ahiemstra added a comment. Note that the interaction model is that way because that's how the system locale works. The KCM sets a bunch of environment variables (LC_ALL and related) which Qt then uses to determine what format to use. These generally correspond to certain country formats. Whi

D24324: [GTK2] Add program to libexec for GTK2 recoloration

2020-01-11 Thread Carson Black
cblack updated this revision to Diff 73289. cblack added a comment. Use colourscheme name instead of emoji REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24324?vs=67090&id=73289 BRANCH arcpatch-D24324 REVISION DETAIL https://phabricator.kde.org/

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Kai Uwe Broulik
broulik added a comment. Hmm this makes inactive tabs even harder to spot than already :/ REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D26587 To: cblack, #vdg, #breeze, ndavis Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Méven Car
meven added a comment. In D26586#592053 , @nicolasfella wrote: > I would just kill the per-section control. There's no point to that IMHO I don't share this opinion. A list with dozens of elements is a maze for users. The categories s

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:c9ac507ff3c2: [GTK3] Improve Electron menubar legibility (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26587?vs=73287&id=73288 REVISION

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Carson Black
cblack updated this revision to Diff 73287. cblack added a comment. Remove commented line REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26587?vs=73286&id=73287 BRANCH electron-menubar-fix (branched from master) REVISION DETAIL https://phabricat

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > _chromium.scss:6 > +color: gtk("@theme_titlebar_foreground"); > +// color: gtk("@theme_titlebar_foreground_backdrop"); — This makes > Chromium look good but impairs legibility in electron menubars > background-color: gtk("@

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think this is fine. REPOSITORY R98 Breeze for Gtk BRANCH electron-menubar-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D26587 To: cblack, #vdg, #breeze,

D26587: [GTK3] Improve Electron menubar legibility

2020-01-11 Thread Carson Black
cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Electron apps using a menubar are now more legible. This has the side effect of forcing background tabs in Chrome/ium to not have a

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Nicolas Fella
nicolasfella added a comment. Also German locale strikes again: The shortcut label (Tastatur-Kurzbefehle) is too long here F7877547: Screenshot_20200111_182731.PNG REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice, a big improvement visually. Make sure @hein or another #plasma person is good with this too. REPOSITORY R120 Plasma Workspace BRANC

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Nicolas Fella
nicolasfella added a comment. I would just kill the per-section control. There's no point to that IMHO REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: nicolasfella, plasma-

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. Also for toggling individual sections, I would recommend making the button say "disable all" or "hide all" (depending on what's most accurate) and use the `view-hidden` icon. Then when all items in that category are disabled/hidden, disable all controls and labels fo

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. Much better! The scrollview needs a frame around it though. You can do this by adding this to it: Component.onCompleted: scrollview.background.visible = true; Why this isn't the default, I have no idea... REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25449: Start of the new Formats KCM

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. More generally, I'm not sure the interaction model of the Detailed Settings part of this KCM (both old and new) makes any sense. Once I choose my global locale, if I want to override individual elements, I want to choose the exact format I want, which I currently can

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Konrad Materka
kmaterka added a comment. This changes is based on the idea from D22176 . It needs review and probably more testing. Is it visually correct? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma

D25449: Start of the new Formats KCM

2020-01-11 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The preview area from the current KCM is missing. In the sheet, the scrollview below the search field seems to be on top of the search field, and the sheet's close button is

D26586: [SystemTray] Rework system tray settings

2020-01-11 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Combines settings of SNI icons and plasmoids in one list. BUG: 360307 FIX

D26584: Load localization catalog for slideshow config window

2020-01-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops, forgot the translation domain, sorry! Thanks for the fix, folks. I'm still not totally clear on why some things require a domain to be added for translations, and other things d

D25449: Start of the new Formats KCM

2020-01-11 Thread Tomaz Canabrava
tcanabrava marked 4 inline comments as done. tcanabrava added a comment. F7877402: Screenshot_20200111_155924.PNG With OverlaySheet INLINE COMMENTS > anthonyfieroni wrote in kcm.cpp:41 > https://doc.qt.io/qt-5/qqmlengine-obsolete.html The non obso

D25449: Start of the new Formats KCM

2020-01-11 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 73281. tcanabrava added a comment. - Merge branch 'master' into arcpatch-D25449 - Use OverlaySheet REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73236&id=73281 BRANCH arcpatch-D25449 REVISION D

D26528: [wallpapers/image] Add placeholder labels when wallpaper lists are empty

2020-01-11 Thread Yuri Chornoivan
yurchor added a comment. In D26528#591882 , @victorr wrote: > There is no translation for part of the lines. > This patch fixes the problem. > F7877060: plasma-workspace-5.17.80-fix.patch Pleas

D26584: Load localization catalog for slideshow config window

2020-01-11 Thread Yuri Chornoivan
yurchor created this revision. yurchor added reviewers: Plasma, Localization. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY It was reported by Victor Ryzhykh that this patch fixes localization of the wallpape

D26489: Use qmlRegisterAnonymousType

2020-01-11 Thread Tomaz Canabrava
This revision was automatically updated to reflect the committed changes. Closed by commit R112:7a6b1a037e65: Use qmlRegisterAnonymousType (authored by tcanabrava). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26489?vs=73276&id=73278 REVISION DETAIL https:/

D26489: Use qmlRegisterAnonymousType

2020-01-11 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R112 Milou BRANCH arcpatch-D26489 REVISION DETAIL https://phabricator.kde.org/D26489 To: tcanabrava, broulik Cc: meven, broulik, plasma-devel, LeGast00n, The-Fer

D26489: Use qmlRegisterAnonymousType

2020-01-11 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 73276. tcanabrava added a comment. - Move typeRegistration to the Plugin instanciation REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26489?vs=72962&id=73276 BRANCH arcpatch-D26489 REVISION DETAIL https://phabric

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-11 Thread Méven Car
meven updated this revision to Diff 73275. meven added a comment. Use KRun::setRunExecutables REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26582?vs=73269&id=73275 BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 AF

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-11 Thread Méven Car
meven added a comment. Well there was already KRun::setRunExecutables :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ra

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-11 Thread Méven Car
meven planned changes to this revision. meven added a comment. In D26582#591952 , @aleksejshilin wrote: > I thought about using KRun::setShowScriptExecutionPrompt() for D10835 , but "Recent Documents" include

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-11 Thread Алексей Шилин
aleksejshilin added a comment. I thought about using KRun::setShowScriptExecutionPrompt() for D10835 , but "Recent Documents" include only those files which were opened, and doesn't include ones which were executed, so an execution prompt there would be to

D25375: Start of the accessibility KCM

2020-01-11 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 73274. tcanabrava marked 16 inline comments as done. tcanabrava added a comment. - ListElement does not handle i18n calls, use raw array - Dont complain about null background - Failing on Qt 5.14 - Add Key entries to the kconfigxt generator - ArtsB

D26583: [Application Style] Add GTK Application Style Page

2020-01-11 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 73272. gikari edited the test plan for this revision. gikari added a comment. Do not init `GtkPage*`, if the kded module is not loaded REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73271&id=73272 BRANCH

D26583: [Application Style] Add GTK Application Style Page

2020-01-11 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY The GTK KCM is now moved to Application Style KCM as a sub page. The functionality is identical to the one, found in GTK KCM, as wel

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

2020-01-11 Thread Méven Car
meven created this revision. meven added reviewers: Plasma, broulik, aleksejshilin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Since D10835 opening urls that needed mimet

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Méven Car
meven updated this revision to Diff 73268. meven added a comment. Undo unintended change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26580?vs=73267&id=73268 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26580 AFFECTED FILES

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Méven Car
meven updated this revision to Diff 73267. meven added a comment. RecentUsageModel Allow to open smb:/ sftp:/ resources REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26580?vs=73262&id=73267 BRANCH master REVISION DETAIL https://phabricator.k

D26528: [wallpapers/image] Add placeholder labels when wallpaper lists are empty

2020-01-11 Thread Victor Ryzhykh
victorr added a comment. There is no translation for part of the lines. This patch fixes the problem. F7877060: plasma-workspace-5.17.80-fix.patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26528 To: ngraham,

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Méven Car
meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26580 AFFECTED

D26185: Fix font rendering when compiled against Qt >= 5.14

2020-01-11 Thread Andrew Cooligan
acooligan added a comment. I think you may leave ifdef here but set: qputenv("QT_ENABLE_HIGHDPI_SCALING", "0"); if it's false as `QT_AUTO_SCREEN_SCALE_FACTOR` is deprecated since qt 5.14. In D26185#582742 , @davidedmundson wrote: