tcanabrava updated this revision to Diff 73274. tcanabrava marked 16 inline comments as done. tcanabrava added a comment.
- ListElement does not handle i18n calls, use raw array - Dont complain about null background - Failing on Qt 5.14 - Add Key entries to the kconfigxt generator - ArtsBell* -> CustomBell* - kModifiers* -> KeyboardModifiers* - Rename mouse settings - Remove deprecated call - Fix nitpicks - Fix Qml Style - Use QFileDialog to look for audio files - Fix Binary checks - Mark as Q_INVOKABLE, not Q_SCRIPTABLE - Use QtQuick Dialogs for the audio file - Fix orca calls - Use Label instead of placeholder text - Fix icon & text for search audio files - Fix Triggers - Trigger orcaInstalled() only when entering ScreenReader - Add explanation for magic number - Add transient window for the KNofityConfigWidget dialog - Fix KConfig Misuse - Explain property - Audible Bell Layout - Add string context REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=73058&id=73274 BRANCH arcpatch-D25375 REVISION DETAIL https://phabricator.kde.org/D25375 AFFECTED FILES kcms/access/CMakeLists.txt kcms/access/accessibility.ui kcms/access/kcmaccess.cpp kcms/access/kcmaccess.desktop kcms/access/kcmaccess.h kcms/access/kcmaccessibilitybell.kcfg kcms/access/kcmaccessibilitybell.kcfgc kcms/access/kcmaccessibilitykeyboard.kcfg kcms/access/kcmaccessibilitykeyboard.kcfgc kcms/access/kcmaccessibilitymouse.kcfg kcms/access/kcmaccessibilitymouse.kcfgc kcms/access/kcmaccessibilityscreenreader.kcfg kcms/access/kcmaccessibilityscreenreader.kcfgc kcms/access/package/contents/ui/Bell.qml kcms/access/package/contents/ui/KeyboardFilters.qml kcms/access/package/contents/ui/ModifierKeys.qml kcms/access/package/contents/ui/MouseNavigation.qml kcms/access/package/contents/ui/ScreenReader.qml kcms/access/package/contents/ui/main.qml kcms/access/package/metadata.desktop To: tcanabrava, ngraham, ervin Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
