KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/5/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 31 Dec 2019 04:46:07 + Build duration: 28 sec and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 31 Dec 2019 04:46:07 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncat

D26035: battery: Improve the brightness responsiveness

This revision was automatically updated to reflect the committed changes. Closed by commit R120:62be85f4360d: battery: Improve the brightness responsiveness (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26035?vs=71743&id=72439 RE

D26316: flatpak: don't crash when showing sources

ngraham added a comment. Doesn't fix https://bugs.kde.org/show_bug.cgi?id=415727 for me, sorry. :( REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26316 To: apol Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26316: flatpak: don't crash when showing sources

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QML seems to be getting confused (only in opensuse) and crash. This is a blind fix that hopefully fixes the issue. TEST PLAN Doesn't

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

ngraham added a comment. Wish I could verify, but the latest commit causes Discover to crash when visiting the Settings page for me: https://bugs.kde.org/show_bug.cgi?id=415727 REPOSITORY R134 Discover Software Store BRANCH sources_actiontoolbar REVISION DETAIL https://phabricator.kde

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

apol added a comment. F7851481: Screenshot_20191231_024108.png The bug mentioned got fixed by this (old Qt doesn't iterate over QList). I don't see how this would make it look any different. The kirigami visible patch is indeed necessary but fo

D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

ngraham updated this revision to Diff 72435. ngraham added a comment. Simplify; still works REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26312?vs=72433&id=72435 BRANCH fix-clock-long-date-in-vertical-panel (branched from master) REVISION DETA

D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 381551 FIXED-IN: 5.18.0 TEST PLAN Before: F7851382: Before.png

D26310: feat: use Control and logical size APIs for replicas

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Use the new Control API to load and save output replica information and the logical size API in li

D26220: feat: control replication

romangg updated this revision to Diff 72429. romangg added a comment. - Rename config key REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26220?vs=72385&id=72429 BRANCH control-replication REVISION DETAIL https://phabricator.kde.org/D26220 AFFECTED FI

D26309: feat: replace replication source with logical size API

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Just overriding the logical size of an output that replicates anoterh one is simpler than trying t

D26264: Add record keystrokes feature to the hotkeys KCM module

ngraham added a comment. The kglobalaccel KCM is unhelpfully named `keys` and lives in plasma-desktop: https://cgit.kde.org/plasma-desktop.git/tree/kcms/keys REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D26264 To: martonmiklos, mlaurent, lunakl, jriddell Cc: ngra

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

ngraham added a comment. In D26234#584969 , @ndavis wrote: > In D26234#584620 , @meven wrote: > > > I feel the "raise maximum volume" button does not need to be always visible as most users won't eve

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

ndavis added a comment. In D26234#584620 , @meven wrote: > I feel the "raise maximum volume" button does not need to be always visible as most users won't ever use it, instead the mute toggle could use the space. You'd be surprised how ma

D26271: [Applet]Update layout based on T10470

filipf added inline comments. INLINE COMMENTS > ListItemBase.qml:117 > +id: defaultButton > +Layout.leftMargin: units.smallSpacing * 0.75 > +checked: PulseObject.default Margins should but don't get mirrored when using a RTL

D26271: [Applet]Update layout based on T10470

ngraham added a comment. Without device icons, the text needs to be improved a bit, or else I see this when I have multiple devices: F7851224: Screenshot_20191230_145819.png INLINE COMMENTS > ListItemBase.qml:115 > > +PlasmaCompon

D26264: Add record keystrokes feature to the hotkeys KCM module

martonmiklos added a comment. In D26264#584826 , @ngraham wrote: > FWIW we're planning to remove KHotKeys in favor of KGlobalAccel: T2050: sunsetting KHotKeys . I'm not sure how much sense it makes to add featu

D23676: [Folder View] Only install watch on .directory file if actually used

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23676 To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali

D26305: Fix Ctrl+F shortcut conflict

ngraham added inline comments. INLINE COMMENTS > SettingsBase.cpp:422 > } > - Dunno why phab is showing this; I didn't actually remove the trailing newline. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D26305 To: ngraham, #plasma, GB_2 Cc: plasma-devel, LeG

D26305: Fix Ctrl+F shortcut conflict

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The base app was always setting Ctrl+F as a search shortcut, even when the toolbar upon which t

D26297: [Notifications] Don't show DrKonqi notifications in history

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e7e747b9bea1: [Notifications] Don't show DrKonqi notifications in history (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26297?vs=72401&id=72421#toc REPOSITORY R120 Pl

D26304: [PageRow] Disable swipe forwards/backwards gesture by default

cblack created this revision. cblack added reviewers: VDG, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The PageRow's ColumnView no longer reacts to a forwards/backwards gesture by default. This r

Re: New Emojier translations

Yuri Chornoivan ha scritto: > Hi, > > There is a report in Russian mailing list that the translations for the new > emoji KCM [1] do not work. It is reported that the catalog name > (plasma_applet_org.kde.kimpanel.po [2]) does not work for KCM (aka Emojier). > > It was suggested to use i18nd()

D25990: Simplify android checks in cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R169:28c13770a73a: Simplify android checks in cmake (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25990?vs=71519&id=72411 REVISION DETAIL

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. In D25807#584697 , @trmdi wrote: > Thank you so much @davidedmundson! > > @mvourlakos: I think you can improve Latte now. :) of course! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added a comment. > Done, but now opening the KCM prints a ton of these errors: Is this still an issue? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: davidedmundson, astip

D26298: Add license to new files

This revision was automatically updated to reflect the committed changes. Closed by commit R120:78210e2780cf: Add license to new files (authored by trmdi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26298?vs=72407&id=72408 REVISION DETAIL https

D26298: Add license to new files

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. How nice of you. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26298 To: trmdi, #plasma, ngraham Cc: plasma-devel, LeGast00n, The-

D26298: Add license to new files

trmdi added a comment. In D26298#584838 , @ngraham wrote: > If you wrote this whole file yourself, you only need to add your own copyright. :) I wrote it with David's help so I would want to add him here. :) REPOSITORY R120 Plasma Work

D26298: Add license to new files

ngraham added a comment. If you wrote this whole file yourself, you only need to add your own copyright. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26298 To: trmdi, #plasma, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fb

D26298: Add license to new files

trmdi created this revision. trmdi added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Add license to strutmanager.* REPOSITORY R120 Plasma Workspace BRANCH master REVISION DET

D26264: Add record keystrokes feature to the hotkeys KCM module

ngraham added a comment. FWIW we're planning to remove KHotKeys in favor of KGlobalAccel: T2050: sunsetting KHotKeys . I'm not sure how much sense it makes to add features to it. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D262

D26297: [Notifications] Don't show DrKonqi notifications in history

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch makes sense to me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26297 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00

D26035: battery: Improve the brightness responsiveness

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Seems to work well, thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26035 To: apol, #plasma, broulik Cc: plasma-devel, LeGast00n

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

apol added a comment. This feels workaround-y, maybe we can just fix ListSectionHeader? REPOSITORY R134 Discover Software Store BRANCH sources_actiontoolbar REVISION DETAIL https://phabricator.kde.org/D26275 To: ahiemstra, #plasma, #discover_software_store, apol, ngraham Cc: rikmills,

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

apol accepted this revision. apol added a comment. Thanks! REPOSITORY R169 Kirigami BRANCH actiontoolbar_contextbutton_visible REVISION DETAIL https://phabricator.kde.org/D26279 To: ahiemstra, #kirigami, ngraham, apol Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkarda

D26035: battery: Improve the brightness responsiveness

apol added a comment. https://phabricator.kde.org/D26035 has been landed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26035 To: apol, #plasma, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26035: battery: Improve the brightness responsiveness

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in logic.js:53 > Wouldn't that cause subsequent calls to fail if the previous hasn't finished > yet? Wouldn't that be annoying if you drag the slider quickly? No, it will be called eventually, whi

D26179: [KCM/Component] Clean up code of filemanager cfg

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7651c1f42b5e: [KCM/Component] Clean up code of filemanager cfg (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72402&id=72403 R

D26297: [Notifications] Don't show DrKonqi notifications in history

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It creates a tray icon, so having a history entry is just annoying duplication. TEST PLAN 5.17

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72402. meven added a comment. cherry-pick on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72368&id=72402 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26179 AFFECTED FILES kc

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

This revision was automatically updated to reflect the committed changes. Closed by commit R119:967b6ac017e8: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D26289: [KCM/Activity] Make default button work, modernize code

meven updated this revision to Diff 72399. meven marked 4 inline comments as done. meven added a comment. 4 newlines were missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26289?vs=72375&id=72399 BRANCH arcpatch-D26289 REVISION DETAIL http

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Just a nitpick you can feel free to ignore, otherwise LGTM. INLINE COMMENTS > dtime.cpp:166 > + for(const QString &possible_ntputility : possible_ntputilities) { > +if( !((ntpUtility = Q

D26289: [KCM/Activity] Make default button work, modernize code

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > MainConfigurationWidget.cpp:59 > > +void MainConfigurationWidget::checkDefault() { > +defaulted(d->tabSwitching->isDefault() && d->tabPrivacy->isDefault())

D26296: Add Opera Extension ID

broulik created this revision. broulik added reviewers: Plasma, leinir. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I submitted it to the Opera Add-ons store and despite having been signed with the same key

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72396. meven added a comment. Add a KStandardDirs conversion REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72394&id=72396 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED F

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED FIL

D25851: [Notifications] Add quick reply feature

This revision was automatically updated to reflect the committed changes. Closed by commit R120:73a3222c6dd1: Merge branch 'broulik/quickreply' (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25851?vs=71197&id=72391#toc REPOSITORY R120 Plasma Workspace CHANGES SI

D26244: Install all kcm plugins into kcms subdir

volkov updated this revision to Diff 72390. volkov added a comment. build metadata from desktop files into the plugins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26244?vs=72249&id=72390 BRANCH master REVISION DETAIL https://phabricator.kde.

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. Thank you so much @davidedmundson! @mvourlakos: I think you can improve Latte now. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807 To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol Cc: davidre, plasma-devel, LeGa

D25807: Allow to set the available screen rect/region from outside through dbus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e8e360862fb7: Allow to set the available screen rect/region from outside through dbus (authored by trmdi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D24847: KCM Icons fix theme selected when we hit delete theme

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, works great now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma, crossi, ngraham, davidedmundson Cc: bport,

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 72387. trmdi added a comment. - Drop the test method REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=72384&id=72387 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL https://phabric

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. maybe drop the ::test method when merging REPOSITORY R120 Plasma Workspace BRANCH add-otherShellHelper (branched from master) REVISION DETAIL https://phabricator.kde.

D26220: feat: control replication

romangg updated this revision to Diff 72385. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26220?vs=72172&id=72385 BRANCH control-replication REVISION DETAIL https://phabricator.kde.org/D26220 AFFECTED FILE

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 72384. trmdi added a comment. - Use const reference for some parameters REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71980&id=72384 BRANCH add-otherShellHelper (branched from master) REVISION DETAI

D26287: [KCM/Activity] Clean unncessary destructor

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b616999bea2b: [KCM/Activity] Clean unncessary destructor (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26287?vs=72372&id=72382 REVISIO

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

meven added a comment. I feel the "raise maximum volume" button does not need to be always visible as most users won't ever use it, instead the mute toggle could use the space. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26234 To: gvgeo, #vdg,

D26289: [KCM/Activity] Make default button work, modernize code

meven created this revision. meven added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 activties Default button states follows those of the privacy and switching tabs REPOSITORY

D26271: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 72373. gvgeo added a comment. Brought back spacing, and corrected sizes. Centered icons, and align text. Reduced checkbox to 18 pixel. QQC2 checkbox is 16 pixels, but does not scale. Instead used PlasmaComponents3 which is 18. REPOSITORY R115 Pla

D26068: [KCM/Activity] Use KConfigXT to store settings

meven added inline comments. INLINE COMMENTS > meven wrote in PrivacyTab.cpp:67 > That was not needed, will clean up D26287 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin, crossi Cc: davidedm

D26287: [KCM/Activity] Clean unncessary destructor

meven created this revision. meven added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26287 AFFECTED F

D26068: [KCM/Activity] Use KConfigXT to store settings

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in PrivacyTab.cpp:67 > Why do we explicitly call deleteLater on these? That was not needed, will clean up REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068 To: meven, #plasma, ervin, crossi

D26068: [KCM/Activity] Use KConfigXT to store settings

davidedmundson added inline comments. INLINE COMMENTS > PrivacyTab.cpp:67 > +{ > +mainConfig->deleteLater(); > +pluginConfig->deleteLater(); Why do we explicitly call deleteLater on these? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26068

D26068: [KCM/Activity] Use KConfigXT to store settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df0a276b7eea: [KCM/Activity] Use KConfigXT to store settings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=72093&id=72369 REV

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72368. meven added a comment. Remove unrelated changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72367&id=72368 BRANCH arcpatch-D26179_2 REVISION DETAIL https://phabricator.kde.org/D26179 AFFEC

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72367. meven added a comment. Formatting & indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72366&id=72367 BRANCH arcpatch-D26179_2 REVISION DETAIL https://phabricator.kde.org/D26179 AFFEC

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72366. meven added a comment. Formatting & indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72365&id=72366 BRANCH arcpatch-D26179_2 REVISION DETAIL https://phabricator.kde.org/D26179 AFFEC

D26179: [KCM/Component] Clean up code of filemanager cfg

meven updated this revision to Diff 72365. meven marked 2 inline comments as done. meven added a comment. Formatting & indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26179?vs=72102&id=72365 BRANCH arcpatch-D26179_2 REVISION DETAIL h

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven planned changes to this revision. meven added a comment. Changes about componentchooserbrowser slipped here. I can't wait to forget about arc... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26100 To: meven, crossi, #plasma, ngraham, ervin Cc: plasma

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

meven updated this revision to Diff 72362. meven marked 3 inline comments as done. meven added a comment. Fix indentation issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=72100&id=72362 BRANCH arcpatch-D26100_2 REVISION DETAIL htt

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

rikmills added a comment. This does NOT fix BUG: 415666. The distro native sources button is still missing. Git master with this change: F7850103: 230501812c.png Correctly showing sources button before commit https://cgit.kde.org/discover.