ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY The base app was always setting Ctrl+F as a search shortcut, even when the toolbar upon which the search field lives was not visible. This caused the dreaded "ambiguous shortcut" dialog to appear. The patch fises the issue by setting the shortcut only when the toolbar contains a search field, and unsetting it when the toolbar is hidden. BUG: 405030 FIXED-IN: 5.18 TEST PLAN Hit [Ctrl] + [F] in both sidebar and icons view. In both cases, it focuses the search field. REPOSITORY R124 System Settings BRANCH fix-shortcut-conflict (branched from master) REVISION DETAIL https://phabricator.kde.org/D26305 AFFECTED FILES app/SettingsBase.cpp To: ngraham, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
