D26225: Change frameRadius to use pen widths, add frameRadiusForNewPenWidth, add PenWidth::NoPen

This revision was automatically updated to reflect the committed changes. Closed by commit R31:5bd591bb0f3b: Change frameRadius to use pen widths, add frameRadiusForNewPenWidth, add… (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26225?vs=7

D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

ndavis updated this revision to Diff 72355. ndavis added a comment. - use frameRadiusForNewPenWidth I think the use of the word new is important here because it's taking a radius and modifying it based on the pen width. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabric

D26268: Fix QTime function deprecation warnings by switching to QElapsedTimer

This revision was automatically updated to reflect the committed changes. Closed by commit R31:ff333a478065: Fix QTime function deprecation warnings by switching to QElapsedTimer (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26268?vs=72318

D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. In D26225#583803 , @ndavis wrote: > - Change newPenWidthFrameRadius to frameRadiusNewPenWidth > > This sounds slightly

D26037: feat(kded): add orientation sensor

romangg updated this revision to Diff 72352. romangg added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. - Activate orientation sensor only when used - Query new libkscreen auto rotation and tablet mode API REPOSITORY R104 KScreen CHANGES SINCE LAST U

D26037: feat(kded): add orientation sensor

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in orientation_sensor.h:38 > I suspect some apps will need that info, but it's just as easy for them to > get that via QSensors directly. Looking at it again I don't think it is advisable to remove these two values from the

D26281: feat: add auto rotate and tablet mode information

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This adds feature flags if a backend supports auto rotations. While this is not directly a func

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah my mistake. I was confused by the empty overflow issue, which your other patch fixes. I can confirm that this fixes the actual reported issue. :) However... I wonder if it's also w

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fixes the issue, thanks! REPOSITORY R169 Kirigami BRANCH actiontoolbar_contextbutton_visible REVISION DETAIL https://phabricator.kde.org/D26279 To: ahiemstra, #kirigami, ngraham C

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

hpereiradacosta added a comment. In D26267#584400 , @ndavis wrote: > In D26267#584396 , @hpereiradacosta wrote: > > > -1: > > if QWeakPointer::data() is obsoleted, (while needed in the code), I w

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

ndavis added a comment. In D26267#584396 , @hpereiradacosta wrote: > -1: > if QWeakPointer::data() is obsoleted, (while needed in the code), I would object to adding toStrongRef, in between, since as pointed out by Antony, calling data

D26271: [Applet]Update layout based on T10470

ngraham added a comment. Awesome work, @gvego. I'm really liking all of these patches of yours. :) The checkbox size issue is probably from the styling of the PlasmaComponents checkbox, as opposed to the basic QQC2 Checkbox. If I'm right, we'd need to fix the PC checkbox, or else just us

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

hpereiradacosta added a comment. -1: if QWeakPointer::data() is obsoleted, (while needed in the code), I would object to adding toStrongRef, in between, since as pointed out by Antony, calling data immediately after brings no further security, and just results in some overhead (Weak to sha

D26270: Fix QFontMetrics::width() deprecation warning by switching to boundingRect().width()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:8a6f6851a49b: Fix QFontMetrics::width() deprecation warning by switching to boundingRect(). (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26270?

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#584249 , @davidedmundson wrote: > Thanks for following up! > > > I'll open a Qt bug and see how it goes. > > Can you link it please. Somebody was faster. I added a comment and a link to this di

D25762: Only serialize window pixmap if we're using it

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b49d5cfde098: Only serialize window pixmap if we're using it (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25762?vs=71789&id=72347

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. I was not able to change the checkbox size, nothing I tried worked. Checked other places with smaller checkbox(like notifications). But could not found how the size is controlled. Current view: F7849371: Screenshot_20191229_220847.png

D26271: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 72345. gvgeo added a comment. Fix spacing Change plasmoid tooltip to mirror the port name Cleanup main.qml REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26271?vs=72321&id=72345 BRANCH UI (branch

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

ahiemstra added a comment. I've created https://phabricator.kde.org/D26279 for the overflow menu. I understood this bug to be about certain buttons now being hidden on the sources page, which as far as I could tell was happening due to sizing, which is what this patch fixes. REPOSITORY

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

ahiemstra updated this revision to Diff 72344. ahiemstra added a comment. - Remove unrelated flat change REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26279?vs=72343&id=72344 BRANCH actiontoolbar_contextbutton_visible REVISION DETAIL https://phabric

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring because the

D26121: Kicker/RecentDocument display file path as decoration

meven added a comment. In D26121#583212 , @ervin wrote: > LGTM, might need an update if D26122 lands though. No need to update here after D26122 , the code uses now

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

ngraham added a comment. Hmm, it doesn't seem to fix the issue for me: F7849179: Screenshot_20191229_101410.png FWIW I've noticed the same phantom overflow menu on the Application page's toolbar: F7849182: Screenshot_20191229_101453.png

D25889: Polish the reviews UI and presentation

ngraham added a comment. I'll do the change to show the top positive and top negative reviews on the app page in a separate patch once this lands. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_software_store

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 72336. ngraham added a comment. Implement VDG mockups REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=72312&id=72336 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL ht

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Kirigami's ListSectionHeader has a default property that points to an embedded RowLayout's

D26271: [Applet]Update layout based on T10470

manueljlin added a comment. Looking at the screenshots, UI wise it's looking good already, only that the checkbox seems too big (should be the same size as the radio button, 16px) and there's a 5px sized padding after the divider that cuts off part of the Internal Microphone button and volum

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added inline comments. INLINE COMMENTS > davidedmundson wrote in strutmanager.h:25 > what's this about? This is just for easily testing using the qdbus command. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807 To: trmdi, #plasma, mvourlakos, davide

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson added inline comments. INLINE COMMENTS > strutmanager.h:22 > +public Q_SLOTS: > +void setAvailableScreenRect(QString service, QString screenName, > QRect rect); > +void setAvailableScreenRegion(QString service, QString screenName, > QList rects); (const QStri

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25807 To: trmdi, #plasma, mvourlakos, davidedmundson, mart, apol Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngr

D26266: Change remove action's icon to "edit-delete"

trmdi abandoned this revision. trmdi added a comment. In D26266#584135 , @mvourlakos wrote: > What is ConfigOverlay for plasma panels is using at its tooltip? Ah, I was wrong. "delete" should be the right one. Sorry. https://github.com

D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson added a comment. Thanks for following up! > I'll open a Qt bug and see how it goes. Can you link it please. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure,

D26261: Rewrite GTK KCM

gikari added a comment. F7848862: Screenshot_20191229_155100.png May be tabs would be the solution? (This is mockup) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26261 To: gikari, apol, #vdg Cc: babert

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. Looks weird right now. From what I can tell, themes add lines between list items. There must be some easy way to disable it. F7848489: Screenshot_20191229_114632.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETA

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

ndavis added a subscriber: hpereiradacosta. ndavis added a comment. Thank you for pointing those out. I don't have a lot of experience, so this helps a lot. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26267 To: ndavis, #breeze, #plasma Cc: hpereiradacosta, anthony

D26271: [Applet]Update layout based on T10470

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, manueljlin, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Change layout according to T10470 mockups.

D26270: Fix QFontMetrics::width() deprecation warning by switching to boundingRect().width()

ndavis created this revision. ndavis added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY According to an article by @cfeck [1], QFontMetrics::width() gave the horizontal advance, whi

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

anthonyfieroni added a comment. `auto c = client().toStrongRef().data();` This is completely wrong, the idea behind shared / weak pointer is ability to know when non-owning resource goes out of scope. by calling toStrongRef you extend its lifetime if and only if it exists at time of call th

D26268: Fix QTime function deprecation warnings by switching to QElapsedTimer

ndavis created this revision. ndavis added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The following functions have deprecation warnings: start(), restart(), elapsed() _clock.isN

D26266: Change remove action's icon to "edit-delete"

mvourlakos added a comment. What is ConfigOverlay for plasma panels is using at its tooltip? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26266 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalouka

D26266: Change remove action's icon to "edit-delete"

trmdi added a comment. But I've just found that Plasma panels use QIcon::fromTheme which load the icon from the icon theme, while PlasmaComponent.ToolButton loads icon from Plasma theme, that is not consistent in some cases. What do you think? REPOSITORY R878 Latte Dock BRANCH master R