hpereiradacosta added a comment.
-1: if QWeakPointer::data() is obsoleted, (while needed in the code), I would object to adding toStrongRef, in between, since as pointed out by Antony, calling data immediately after brings no further security, and just results in some overhead (Weak to shared pointer). It means that either - weakPointer::data should not be obsoleted - the kdecoration api should be changed (to return shared pointers, or provide direct access to the data). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26267 To: ndavis, #breeze, #plasma Cc: hpereiradacosta, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
