D26217: Add standard pen widths and replace hardcoded numbers

2019-12-24 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The replaced numbers are directly related to the width of the pen. This patch likely doesn't

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-24 Thread Andreas Hartmetz
ahartmetz added a comment. Just to make this extra clear, I have nothing against auto-scaling. There is probably a KCM to set it however I want if I don't like the default. My problem is with blurry and in some cases ("-=") disfigured font rendering. That should never happen regardless of ph

D26212: Remember devices to raise maximum volume

2019-12-24 Thread George Vogiatzis
gvgeo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Keep a list of devices and applications to raise maximum volume. For applications, option will mirror across all the instances of a pr

D26200: Add shortcut for closing pages

2019-12-24 Thread Nathaniel Graham
ngraham added a comment. Maybe, but I think there is some value to having this handled by the toolkit to ensure behavioral consistency across apps. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26200 To: nicolasfella, #kirigami, mart, ngraham Cc: apol, plasma-dev

D26199: Remove unneeded shortcut for page naviagtion

2019-12-24 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. Oh gosh, so sorry! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26199 To: nicolasfella, #discover_software_store, ngraham, apol Cc: apol, ngraham, alexeymin, plasma-devel, LeGast0

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-24 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. After 900f2cb6f7070 in QtBase auto dpi changed it's meaning somewhat. The comment written no longer applies and #ifdef'ing is the correct thing to get the consiste

D26200: Add shortcut for closing pages

2019-12-24 Thread Aleix Pol Gonzalez
apol added a comment. Shouldn't the application control whether its pages get closed and under which condition it happens? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26200 To: nicolasfella, #kirigami, mart, ngraham Cc: apol, plasma-devel, fbampaloukas, GB_2, d

D26199: Remove unneeded shortcut for page naviagtion

2019-12-24 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. This is not for changing pages, it's about scrolling vertically. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26199 To: nicolasfella, #dis

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-24 Thread Aleix Pol Gonzalez
apol added subscribers: davidedmundson, dfaure. apol added a comment. I'm not all that sure. Not it's coming from D24255 by @dfaure, approved by @davidedmundson. Maybe they have some insight. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://p

D26192: Fix localization of the systemmonitor widget configuration window

2019-12-24 Thread Albert Astals Cid
aacid added a comment. For the future, ideally, if a component is used as a library (like it seems is the case here) it should be extracted to it's own catalog and then translated with i18nd* variants that specify that catalog to be loaded instead of asking the translators to translate it N

D26121: Kicker/RecentDocument display file path as decoration

2019-12-24 Thread Méven Car
meven added a comment. This was done to match my proposed recentlyused krunner : D26111 And the computer should be good now : D26147 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26121 REVISION DETAIL htt