D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson added a comment. Much nicer! Re: string Vs int It can be ints within plasmashell, it just needs to be strings over the dbus protocol. The problem is that on wayland (and to some extent x11 is racey) the order of screens within QApplication::screens might not be i

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71649. trmdi added a comment. - Add another missed line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71648&id=71649 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL https://phab

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. @davidedmundson Concerning the type of screenId should be QString, I think it need another patch, because Plasma::Corona's availableScreenRect also requires that type: https://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00331 REPOSITORY

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71648. trmdi marked 2 inline comments as done. trmdi added a comment. - Add a missed line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71647&id=71648 BRANCH add-otherShellHelper (branched from maste

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71647. trmdi added a comment. - Follow David's guide REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71594&id=71647 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL https://phabric

D25539: feat(kcm): add revert timer

liushuyu added a comment. Any other suggestions for this patch? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D26035: battery: Improve the brightness responsiveness

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use QQC2.Slider, so that we have a moved signal. This way we can only issue new brightnesses when

D26033: feat: add Control file watcher

romangg updated this revision to Diff 71641. romangg added a comment. Integrate into daemon. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26033?vs=71640&id=71641 BRANCH control-filewatcher REVISION DETAIL https://phabricator.kde.org/D26033 AFFECTED

D26033: feat: add Control file watcher

romangg updated this revision to Diff 71640. romangg added a comment. Make sure we only set the file watcher once. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26033?vs=71639&id=71640 BRANCH control-filewatcher REVISION DETAIL https://phabricator.kd

D26033: feat: add Control file watcher

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY A simple QFileSystemWatcher is added to Control objects that can be activated on demand. On

D26032: feat: add Control API for auto rotation

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY With this API the current user preference for auto rotation a particular output on global level

D26031: feat: access outputs controls through config control

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Compositing output controls for all outputs into config control objects allows writing and readi

D26026: refactor: let Control be a QObject

romangg added inline comments. INLINE COMMENTS > config.cpp:45 > +, m_data(config) > +, m_control(new ControlConfig(config, this)) > { Caching it means we don't read in new retention value when it changed. So this patch without a file watcher yet or other system to communicate changes

D26030: feat: read/write output control files

romangg added inline comments. INLINE COMMENTS > control.cpp:37 > +const QString path = filePath(); > +const auto infoMap = info(); > + `constInfo()` REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26030 To: romangg, #plasma Cc: plasma-devel, LeGast00n, The-Fe

D26030: feat: read/write output control files

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds functionality to read and write the control files of outputs. This can be used going on for

D26026: refactor: let Control be a QObject

romangg added a comment. That being said thinking about it some more having a file watcher can lead to races for example in the following case: - User changes auto rotation and resolution at the same time while device is held in a position unequal to current rotation - KWin receives up

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 253 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/253/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:23:45 + Build duration: 8 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 258 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/258/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:23:47 + Build duration: 6 min 54 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 123 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/123/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:23:46 + Build duration: 6 min 52 sec and counting JUnit Tests

D25959: [applets/taskmanager] Add highlight effect for hovered tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf22a4c7f99a: [applets/taskmanager] Add highlight effect for hovered tooltip (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25959?vs=7

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 28 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/28/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:23:48 + Build duration: 3 min 40 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » plasma-nano » stable-kf5-qt5 FreeBSDQt5.13 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nano/job/stable-kf5-qt5%20FreeBSDQt5.13/1/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:23:38 + Build duration: 3 min 30 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/1/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:23:36 + Build duration: 3 min 24 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/1/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:23:35 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » plasma-phone-components » stable-kf5-qt5 FreeBSDQt5.13 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/stable-kf5-qt5%20FreeBSDQt5.13/1/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 22:23:34 + Build duration: 1 min 4 sec and counting CONSOLE

KDE CI: Plasma » plasma-nano » stable-kf5-qt5 SUSEQt5.12 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nano/job/stable-kf5-qt5%20SUSEQt5.12/1/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:23:38 + Build duration: 31 sec and counting CONSOLE OUTPUT Started b

KDE CI: Plasma » plasma-phone-components » stable-kf5-qt5 SUSEQt5.12 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/stable-kf5-qt5%20SUSEQt5.12/1/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 22:23:33 + Build duration: 27 sec and counting CONSOLE OUTPUT

D25580: [System Tray] Unified data model for System Tray items

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, broulik, ngraham, nicolasfella Cc: plasma-d

D26026: refactor: let Control be a QObject

romangg added a comment. In D26026#578484 , @davidedmundson wrote: > > This is a preparatory step to add signals later for watching file changes. > > I don't think I understand. What for? > If it's full output configuration going via the

D26026: refactor: let Control be a QObject

davidedmundson added a comment. > This is a preparatory step to add signals later for watching file changes. I don't think I understand. What for? If it's full output configuration going via the disk that would go against the main part of kscreen architecture. INLINE COMMENTS > contr

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3245c6bc9b77: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the… (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

https://bugs.kde.org/show_bug.cgi?id=364953 Filip Fila changed: What|Removed |Added Latest Commit||https://commits.kde.org/pla |

D26028: refactor(kcm): move rotation buttons in own module

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Simple refactor to make the code more readable when later on auto rotation functionality is adde

D26027: refactor: make Globals a namespace

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Globals does not need to be a class. This simplifies working with it. TEST PLAN Compiles. REPO

D26026: refactor: let Control be a QObject

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This is a preparatory step to add signals later for watching file changes. TEST PLAN Tested in

D25967: Emit panelTakesFocus for other plamsashell types

davidedmundson planned changes to this revision. davidedmundson added a comment. In hindsight, lets see if we can get something that fixes the widget explorer at the same time. It's basically the same issue. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL htt

D26021: Display sub categories when serching

mart updated this revision to Diff 71614. mart added a comment. - hide subcategory column when going back to start page REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71613&id=71614 BRANCH mart/newSearch REVISION DETAIL https://phabri

D26021: Display sub categories when serching

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when searching, show categories *and* subcategories indented under categories, making it way less confusi

D25984: Load translations

kossebau added a comment. In D25984#578306 , @kossebau wrote: > Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib

D25984: Load translations

broulik added a comment. I guess it builds the QML tree and evaluates the `qsTr` calls and then finds it needs an item from a plugin and loads the import and only then translates it. Subsequent controls are translated, only the ones on the initial item are not. Perhaps if we shoehorn a `QQml

D25984: Load translations

kossebau added a comment. Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib should be invoked before during loading, no? Time to go playing with the actual

D25984: Load translations

kossebau added a comment. In D25984#578299 , @broulik wrote: > Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. Uh, okay, that seems like things

D25984: Load translations

davidedmundson added a comment. > Okay. Which app did you test with? Does it link kcoreaddons? Would poke then as well a bit, as I happen to have a related rant blog post lying around ;) ). systemsettings5 exhibits this situation REPOSITORY R169 Kirigami REVISION DETAIL https://pha

D25984: Load translations

kossebau added a comment. In D25984#578298 , @broulik wrote: > Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. Okay. Which

D25984: Load translations

broulik added a comment. Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kosseb

D25984: Load translations

broulik added a comment. Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami

D25984: Load translations

kossebau added a comment. In D25984#578296 , @broulik wrote: > We don't link against Kirigami, so the startup routine stuff doesn't apply? `Q_COREAPP_STARTUP_FUNCTION` generates a static struct in the compiled code, whose constructor will

D25984: Load translations

broulik added a comment. We don't link against Kirigami, so the startup routine stuff doesn't apply? And we're way after the QCoreApp constructor at this point. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aac

D25984: Load translations

kossebau added a comment. In D25984#578291 , @broulik wrote: > Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that.

D25984: Load translations

broulik added a comment. Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir updated this revision to Diff 71607. leinir added a comment. - Add functionality to open the accounts kcm on saveCredentials calls REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25961?vs=71495&id=71607 BRANCH switch-attica-plugin-to-kaccoun

D25984: Load translations

kossebau added a comment. > The ECM QM Loader uses Q_COREAPP_STARTUP_FUNCTION which doesn't work for things loaded as plugins like QML modules. Curious, where it exactly does it fail to work? Q_COREAPP_STARTUP_FUNCTION being nvoked during lib loading after the QApp instance exists still

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 252 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/252/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 15:32:40 + Build duration: 4 min 18 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 257 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/257/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 15 Dec 2019 15:32:40 + Build duration: 2 min 25 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 122 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/122/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Dec 2019 15:32:40 + Build duration: 2 min 23 sec and counting CONSOLE OUT

D25807: Allow to set the available screen rect/region from outside through dbus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Concept is fine. INLINE COMMENTS > othershellhelper.cpp:7 > + > +OtherShellHelper::OtherShellHelper(ShellCorona *plasmashellCorona) : > QObject(qobject_cast(plasm

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

ngraham added a comment. +1 on adding this, for sure. I think it's nice when a feature's shortcut is exposed like this. INLINE COMMENTS > main.qml:100 > +QtControls.Label { > +text: i18n("Keyboard shortcut:") > +} Maybe "Toggle with:"? REPOSITORY R

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! REPOSITORY R119 Plasma Desktop BRANCH little-color-sign (branched from master) REVISION DETAIL https://phabricator.kde.org/D25785 To: filipf, #plasma, #vdg, ngraham Cc: ng

D26018: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Not a huge fan of the code duplication there.. Needs D26013

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71594. trmdi added a comment. - No need to setConnected manually REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71488&id=71594 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL htt

D26015: Show grabby hand cursors when hovering and dragging draggable widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R120:360bc1df57fd: Show grabby hand cursors when hovering and dragging draggable widgets (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D26015: Show grabby hand cursors when hovering and dragging draggable widgets

ngraham updated this revision to Diff 71592. ngraham marked an inline comment as done. ngraham added a comment. Address review comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26015?vs=71590&id=71592 BRANCH grabby-hands-on-widgets (branche

D26015: Show grabby hand cursors when hovering and dragging draggable widgets

mart accepted this revision. mart added inline comments. INLINE COMMENTS > itemcontainer.cpp:652 > Q_UNUSED(event); > +setCursor(Qt::ArrowCursor); > shouldn't be necessary here but when going out of edit mode REPOSITORY R120 Plasma Workspace BRANCH grabby-hands-on-widgets (branc

D26015: Show grabby hand cursors when hovering and dragging draggable widgets

ngraham created this revision. ngraham added reviewers: VDG, Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Same idea as D25998 , but for desktop widgets and d

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e7af306adcc6: Use KQuickCharts to render notification timeout as a circular progress bar (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

D26012: Restore circular progress bar in compact notification applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:da86d1e40a1d: Restore circular progress bar in compact notification applet (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26012?vs

D26012: Restore circular progress bar in compact notification applet

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely! REPOSITORY R120 Plasma Workspace BRANCH circular_progress REVISION DETAIL https://phabricator.kde.org/D26012 To: ahiemstra, #plasma, broulik Cc: broulik, plasma-devel, LeG

D26012: Restore circular progress bar in compact notification applet

ahiemstra updated this revision to Diff 71584. ahiemstra added a comment. - Don't show busyindicator when there are no jobs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26012?vs=71579&id=71584 BRANCH circular_progress REVISION DETAIL https:

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 71583. steffenh added a comment. remove debug messages REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=71052&id=71583 BRANCH arcpatch-D25428 REVISION DETAIL https://phabricator.kde.org/D25428 AFFE

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

ngraham abandoned this revision. ngraham added a comment. All right. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25952 To: ngraham, #plasma, #vdg, hein, ndavis Cc: broulik, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbamp

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

davidedmundson added a comment. > Maybe it could stay open after click only for the case where it's a tooltip for a grouped item and there are multiple windows in it? IIRC this is what Windows does, now that I think about it. But even so, which case which is more likely: A user want

D25950: Add specialized notification for Bluetooth battery

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R122:ef856e3598ec: Add specialized notification for Bluetooth battery (authored by broulik). REPOSITORY R122 Powerdevil

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:943ca2072a80: [Notifications] Show hint if notifications aren't available or provided by… (authored by broulik). REPOS

D26012: Restore circular progress bar in compact notification applet

ahiemstra updated this revision to Diff 71579. ahiemstra added a comment. - Use visible to hide the busyindicator when progress > 0 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26012?vs=71577&id=71579 BRANCH circular_progress REVISION DETAIL

D25983: Update size hint when font changes

This revision was automatically updated to reflect the committed changes. Closed by commit R858:51871406787d: Update size hint when font changes (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25983?vs=71498&id=

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

ngraham added a comment. Maybe it could stay open after click only for the case where it's a tooltip for a grouped item and there are multiple windows in it? IIRC this is what Windows does, now that I think about it. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https:

D26012: Restore circular progress bar in compact notification applet

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CompactRepresentation.qml:103 > running: visible > +opacity: compactRoot.jobsPercentage == 0 ? 1 : 0 > } You might want to

D25976: Use a default non-administrator user Type for new users in model

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Both issues fixed, no additional regressions found, code looks sane. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D25976 To: meven, ngrah

D26012: Restore circular progress bar in compact notification applet

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY During the port to Qt5 the circular progress bar was lost, since there is no simple way to

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

broulik added a comment. I agree. The tooltips get in the way far too often as they are, so making them stay unnecessarily would be annoying. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25952 To: ngraham, #plasma, #vdg, hein, ndavis Cc: b

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

davidedmundson added a comment. There's a huge difference compared to close. With the thumbail case, it's quite common that your next action is to want to interact with the window that's under the thumbnail. With close that isn't the case. Given this was added very explicitly (

D25967: Emit panelTakesFocus for other plamsashell types

broulik added a comment. No! But it allows them to get it if they want to, e.g. when you hit inline reply REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25967 To: davidedmundson, #plasma Cc: broulik, apol, plasma-devel, LeGast00