D24810: Ensure defintion of XDG_DATA_DIRS

tcberner updated this revision to Diff 68732. tcberner edited the summary of this revision. tcberner added a comment. Update commit message in diff. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24810?vs=68731&id=68732 BRANCH master REVISION D

D24810: Ensure defintion of XDG_DATA_DIRS

tcberner updated this revision to Diff 68731. tcberner added a comment. Fix comment and commit message. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24810?vs=68379&id=68731 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24810 A

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodelitem.cpp:548 > > +if (device && device->ipV4Config().isValid() && m_connectionState == > NetworkManager::ActiveConnection::Activated) {

D24732: Rewrite AppChooser dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R838:c85055441a22: Rewrite AppChooser dialog (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68673&id

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

mibofra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. mibofra requested review of this revision. REVISION SUMMARY I apologize if I annoy someone with this request, as here https://bugs.kde.org/show_bug.cgi?id=3

D24935: Fix search field focus, both initial and on-demand

This revision was automatically updated to reflect the committed changes. Closed by commit R134:5d1b3718efb8: Fix search field focus, both initial and on-demand (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24935?vs=6872

D24935: Fix search field focus, both initial and on-demand

ngraham added a comment. In D24935#553754 , @apol wrote: > Having the focus there (which is where it used to be in some older version) makes it a bit harder to navigate the central view with the arrows Hopefully that will eventually be fi

D24935: Fix search field focus, both initial and on-demand

apol added a comment. Sure, it makes sense. It's not really changing much, only removing the loader. The loader did make things slightly more complex so I can imagine this working better. The whole `Component.onCompleted: {` bit is what gives it the focus. Having the focus there

D24935: Fix search field focus, both initial and on-demand

ngraham added a comment. @apol does this make sense conceptually though? I don't want to commit a big ugly hack. REPOSITORY R134 Discover Software Store BRANCH fix-searchfield-focus (branched from master) REVISION DETAIL https://phabricator.kde.org/D24935 To: ngraham, #discover_softw

D24935: Fix search field focus, both initial and on-demand

ngraham updated this revision to Diff 68726. ngraham added a comment. Remove unnecessary `focus: true` REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24935?vs=68719&id=68726 BRANCH fix-searchfield-focus (branched from master) REVISION DE

D24937: Set focus on the search bar by default

ngraham added a comment. FWIW this doesn't actually fix the bug for me. The search bar is now focusable by hitting the tab key enough times, but it doesn't get focus by default for me. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24937 To: davide

D24937: Set focus on the search bar by default

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Opened discover REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D24935: Fix search field focus, both initial and on-demand

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's give it a try, merge to master, this could have side-effects. INLINE COMMENTS > DiscoverDrawer.qml:85 > +id: searchField > +focus: true > This shouldn't

KDE CI: Plasma » systemsettings » stable-kf5-qt5 FreeBSDQt5.13 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20FreeBSDQt5.13/41/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 24 Oct 2019 20:17:45 + Build duration: 2 hr 4 min and counting CONSOLE OUTPUT

D24934: [notifications] Center no notification text on mobile

broulik added inline comments. INLINE COMMENTS > FullRepresentation.qml:580 > PlasmaExtras.Heading { > width: list.width > +height: list.height Now you could have used an `anchors.fill` xD REPOSITORY R120 Plasma Workspace REVISION DETAIL https:

D24934: [notifications] Center no notification text on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3ab37034791: [notifications] Center no notification text on mobile (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=687

D24934: [notifications] Center no notification text on mobile

nicolasfella updated this revision to Diff 68721. nicolasfella added a comment. - Fix it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68720&id=68721 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES a

D24934: [notifications] Center no notification text on mobile

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fix it, then ship it INLINE COMMENTS > FullRepresentation.qml:582 > +horizontalAlignment: Kirigami.Settings.isMobile ? > Text.AlignHCenter : Text.AlignLeft > +

D24934: [notifications] Center no notification text on mobile

nicolasfella added a comment. Looks just more complicated to me, but :shrug: REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D24934: [notifications] Center no notification text on mobile

nicolasfella updated this revision to Diff 68720. nicolasfella added a comment. - Do as Kai says REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68718&id=68720 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED F

D24934: [notifications] Center no notification text on mobile

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Keep the width and enable wrapping and horizontal centering. We both know how wide some locale can get :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricat

D24935: Fix search field focus, both initial and on-demand

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now the search field doesn't get focus initially, or w

D24934: [notifications] Center no notification text on mobile

KonqiDragon added a comment. Could you add a rounded corners? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg Cc: KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, n

D24786: [GTK3] Add styles for libhandy widgets

cblack added a comment. In D24786#550396 , @ndavis wrote: > I think it might be a bit premature to copy the look of Plasma Mobile at this point. I don't know what is likely to change and what is likely to stay. I expect that it will mirror the l

D24934: [notifications] Center no notification text on mobile

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES applets/notificatio

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7a7363289304: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D21815: [sddm-theme] Start moving from QQC1 to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5c8ce892e394: [sddm-theme] Start moving from QQC1 to QQC2 (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=64261&id=68716 REV

D24901: [sidebar] Add a hover effect to intro page icons

This revision was automatically updated to reflect the committed changes. Closed by commit R124:a306b76cb853: [sidebar] Add a hover effect to intro page icons (authored by filipf). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24901?vs=68641&id=68713

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

wbauer added a comment. In D24748#552313 , @anthonyfieroni wrote: > You can try it like that: > > if (!m_editMode) { > event->setAccepted(false); > } > > > or > > event->setAccepted(m_editMode); > That does

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham added a comment. The desktop effects KCM doesn't have a centered form layout like this one does. I tried a left-aligned label but it looked quite odd. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc: G

D24906: [KCMs/Night Color] Explain Night Color feature inline

GB_2 added a comment. In the Desktop Effects KCM the label is top-left aligned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc: GB_2, ahiemstra, davidedmundson, ndavis, plasma-devel, LeGast00n, The-Feren-OS-D

D24906: [KCMs/Night Color] Explain Night Color feature inline

This revision was automatically updated to reflect the committed changes. Closed by commit R119:af39f0aeaf93: [KCMs/Night Color] Explain Night Color feature inline (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24906?vs=68704&id=6

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham updated this revision to Diff 68704. ngraham added a comment. Tweak wording and set a maximum width for the label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24906?vs=68646&id=68704 BRANCH explain-night-color (branched from master) REV

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham added a comment. In D24906#553215 , @ahiemstra wrote: > Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means? I would hope so; warm vs co

D24925: KCM KSplash port to ManagedConfigModule

crossi updated this revision to Diff 68699. crossi added a comment. setNeedsSave() not needed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68682&id=68699 REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILES kcms/ksplash/

D24927: Use updateItem

jgrulich added a comment. I just pushed the very same change so you don't need to do the review. Can be closed then. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24927 To: nicolasfella, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-D

D24925: KCM KSplash port to ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > crossi wrote in kcm.cpp:148 > it needs an explicit call, like load() and save() My bad. setNeedsSave() is no longer needed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To: crossi, #plasma, ervin, mart, b

D24924: Don't reset model when adding an active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:6929300787ac: Don't reset model when adding an active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D24919: Don't reset model when device state changes

This revision was automatically updated to reflect the committed changes. Closed by commit R116:2bb496b0708f: Don't reset model when device state changes (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24919?vs=68694&id=68698#toc REPOSITORY R116 Plasma Networ

D24927: Use updateItem

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH uu REVISION DETAIL https://phabricator.kde

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68695. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68691&id=68695 BRANCH updavail REVISION DETAIL

D24919: Don't reset model when device state changes

nicolasfella updated this revision to Diff 68694. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24919?vs=68693&id=68694 BRANCH noreset2 REVISION DETAIL

D24919: Don't reset model when device state changes

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:829 > item->invalidateDetails(); > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(ro

D24853: [DigitalClock] Fix layout and QML warnings

ngraham added a comment. Fair enough, that seems reasonable. INLINE COMMENTS > configTimeZones.qml:58 > +Layout.fillWidth: true > +Layout.margins: 1 > Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing` REPOSITORY R120 Plasma Workspace REVISION DET

D24919: Don't reset model when device state changes

nicolasfella updated this revision to Diff 68693. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24919?vs=68677&id=68693 BRANCH noreset2 REVISION DETAIL https://phabricat

D24926: [ResultsView] Expose limit

broulik closed this revision. broulik added a comment. https://cgit.kde.org/milou.git/commit/?id=eda3d274da1d502e61e24fa41f6b23b9f236baed REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D24926 To: broulik, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-

D24925: KCM KSplash port to ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:148 > doesn't managed module take care of this? it needs an explicit call, like load() and save() REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To: crossi, #plasma, ervin, m

D24926: [ResultsView] Expose limit

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Lets the user of the view decide how many items they want TEST PLAN - Can have more than the de

D24924: Don't reset model when adding an active connection

jgrulich added a comment. In D24924#553460 , @jgrulich wrote: > Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically. Can you change it in other PRs too and

D24924: Don't reset model when adding an active connection

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically. REPOSITORY R116 Plasma Network Manage

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68691. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68681&id=68691 BRANCH updavail REVISION DETAIL https://phabricat

D24923: Use more return early

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c56f00b52786: Use more return early (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24923?vs=68689&id=68690 REV

D24925: KCM KSplash port to ManagedConfigModule

davidedmundson added inline comments. INLINE COMMENTS > kcm.cpp:148 > +ManagedConfigModule::defaults(); > setNeedsSave(m_settings->isSaveNeeded()); > } doesn't managed module take care of this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To:

D24923: Use more return early

nicolasfella added inline comments. INLINE COMMENTS > jgrulich wrote in networkmodel.cpp:402 > I think this is a valid Qt coding style, it was just my obsession to use > curly braces everywhere, even for single line body. As much as I hate it, crossi is right. https://community.kde.org/Policie

D24923: Use more return early

crossi resigned from this revision. crossi added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > jgrulich wrote in networkmodel.cpp:402 > I think this is a valid Qt coding style, it was just my obsession to use > curly braces everywhere, even for single line b

D24923: Use more return early

nicolasfella updated this revision to Diff 68689. nicolasfella added a comment. - Conding style REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24923?vs=68680&id=68689 BRANCH ret REVISION DETAIL https://phabricator.kde.org/D249

D24922: Don't reset model when available connection appears

This revision was automatically updated to reflect the committed changes. Closed by commit R116:d971703e1df5: Don't reset model when available connection appears (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D24923: Use more return early

jgrulich accepted this revision. jgrulich added inline comments. INLINE COMMENTS > crossi wrote in networkmodel.cpp:402 > Code style : Use curly braces even when the body of a conditional statement > contains only one line. I think this is a valid Qt coding style, it was just my obsession to u

D24920: Add missing role changes

This revision was automatically updated to reflect the committed changes. Closed by commit R116:17e4fd449991: Add missing role changes (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24920?vs=68678&id=68687

D24919: Don't reset model when device state changes

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > networkmodel.cpp:830 > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(row, 0)); > // qCDebug(PLASMA_NM) <<

D24924: Don't reset model when adding an active connection

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:313 > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(row, 0)); > } Shouldn't you add it

D24923: Use more return early

crossi requested changes to this revision. crossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:402 > // Check whether the connection is already in the model to avoid > duplicates, but this shouldn't happen > -if (!m_list.contai

D24925: KCM KSplash port to ManagedConfigModule

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILE

D24924: Don't reset model when adding an active connection

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 REPOSITORY R116 Plas

D24923: Use more return early

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH ret REVISION DETAIL https://phabricator.kd

D24922: Don't reset model when available connection appears

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY addAvailableConnection() does the proper row/data update handling already Depends

D24920: Add missing role changes

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY A few roles were not marked as changed properly. TEST PLAN Builds REPOSITORY R116

D24919: Don't reset model when device state changes

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 TEST PLAN Toggled Wi

D24913: Converts a couple foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f95ea34ac40: Converts a couple foreach (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24913?vs=68668&id=68675 REVISION DETAIL http

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#552239 , @ngraham wrote: > There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle. Solve

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68673. jgrulich added a comment. - Add border around the view and use small radius around for item highlight REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68502&id=68673 B

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY KConfig XT does not store default values in conf files. KCM Style applying defaul

D24916: KCM style : fix combobox that weren't updated after user made change

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. TEST PLAN Inside Configure Icons and Toolbars popup menu, change some value in combobox, hit apply

D24917: KCM Style port to KConfigXT

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES kcms/style/CMakeLists.txt kcms/style/kcmstyle.

D24913: Converts a couple foreach

meven added inline comments. INLINE COMMENTS > view.cpp:224 > > -Q_FOREACH (QScreen* screen, QGuiApplication::screens()) { > +const auto screens = QGuiApplication::screens(); > +for (QScreen* screen : screens) { screens currently returns QList and QList should get deprecated in Qt

D24913: Converts a couple foreach

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24913 AFFECTED FILES

D24894: notifier: Make action buttons translatable

apol accepted this revision. apol added a comment. Good catch! I wonder how that happened :/ REPOSITORY R134 Discover Software Store BRANCH notifier-i18n REVISION DETAIL https://phabricator.kde.org/D24894 To: aspotashev, apol, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 137 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/137/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 24 Oct 2019 10:35:30 + Build duration: 9 min 16 sec and counting JUnit Tests Name: (root) Failed:

D24910: Fix build

This revision was automatically updated to reflect the committed changes. Closed by commit R116:ba142dd7125c: Fix build (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24910?vs=68660&id=68661 REVISION DETAIL

D24910: Fix build

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. You could just push this without me doing review :). REPOSITORY R116 Plasma Network Management Applet BRANCH fix REVISION DETAIL https://phabricator.kde.org/D24910 To: nicolasfe

D24906: [KCMs/Night Color] Explain Night Color feature inline

ahiemstra added a comment. Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means? REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabric

D24910: Fix build

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH fix REVISION DETAIL https://phabricator.kd

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 136 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/136/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 24 Oct 2019 10:27:18 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT [...truncated 484

D24905: Use return early

This revision was automatically updated to reflect the committed changes. Closed by commit R116:f301f1ead38a: Use return early (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24905?vs=68658&id=68659 REVISION

D24905: Use return early

nicolasfella updated this revision to Diff 68658. nicolasfella added a comment. - s/break/continue - Fixup REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24905?vs=68644&id=68658 BRANCH returnearly REVISION DETAIL https://pha

D24903: Don't reset model when activeconnectionstate changed

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4627aaf6f066: Don't reset model when activeconnectionstate changed (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D24900: [mobile/wifi] Remove special font style for active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5e9ff384b503: [mobile/wifi] Remove special font style for active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricat

D24899: Remove commented out code

This revision was automatically updated to reflect the committed changes. Closed by commit R116:33991d909626: Remove commented out code (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24899?vs=68636&id=68654#toc REPOSITORY R116 Plasma Network Management Apple

D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b83e86d817bc: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE ht

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka added a comment. It looks like there are some review changes required in D24798 . Maybe I can commit my changes first? D24798 needs changes anyway and it would be good to split QCC1 -> QCC2 migration from layou

D24906: [KCMs/Night Color] Explain Night Color feature inline

davidedmundson added a comment. > They prefer, correct me if I'm wrong, something like "[Night Color KCM]". Plasma folks don't really have a good style sorted. You can find examples of 3 different styles. It is a good point that we miss a consistency :/ but it also means no individ

D24906: [KCMs/Night Color] Explain Night Color feature inline

davidedmundson added a comment. > They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc:

D24893: [Lock Screen] Add option to hide clock when idle

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in WallpaperFader.qml:145 > Why are we changing this line? The clock shadow effectively renders the clock (shader effect with source hidden), so it has to be hidden. > davidedmundson wrote in config.qml:21 > One thing Thomas

D24893: [Lock Screen] Add option to hide clock when idle

davidedmundson added inline comments. INLINE COMMENTS > WallpaperFader.qml:145 > target: clock.shadow > -opacity: 1 > +opacity: wallpaperFader.alwaysShowClock ? 1 : 0 > +} Why are we changing this line? > config.qml:21 > +

D24906: [KCMs/Night Color] Explain Night Color feature inline

zzag added a comment. > [KCMs/Night Color] Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

Night Color Widget (Redshift Control Widget adapt to kwin's Night Color)

Hey guys! I was thinking about resurrecting the Redshift Control Widget, as apparently there are users (including me) that find it very convenient to be able to enable/disable Night Color with just a click. Anyway I have some questions that I hope you might be able to answer. Currently R

D24905: Use return early

jgrulich added a comment. In D24905#553119 , @broulik wrote: > I think all of thise `breaks` in loops must be `continue`s? Good catch. REPOSITORY R116 Plasma Network Management Applet BRANCH returnearly REVISION DETAIL https://pha

Night Color Widget (adapt Redshift Control Widget to kwin's Night Color functionality)

Hey guys! I was thinking about resurrecting the Redshift Control Widget, as apparently there are users (including me) that find it very convenient to be able to enable/disable Night Color with just a click. Anyway I have some questions that I hope you might be able to answer. Currently R

D24894: notifier: Make action buttons translatable

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.17 branch please. While you cannot change strings, you can make previously accidentally untranslated strings translatable. REPOSITORY R134 Discover Software Store BRANCH notifier-i

D24905: Use return early

broulik added a comment. I think all of thise `breaks` in loops must be `continue`s? INLINE COMMENTS > networkmodel.cpp:457 > +if (item->itemType() != NetworkModelItem::AvailableConnection) > +break; > + Shouldn't this be a `continue`? > networkmodel.cpp:843 > +i

  1   2   >