broulik added a comment.
I think all of thise `breaks` in loops must be `continue`s? INLINE COMMENTS > networkmodel.cpp:457 > + if (item->itemType() != NetworkModelItem::AvailableConnection) > + break; > + Shouldn't this be a `continue`? > networkmodel.cpp:843 > + if (dev->type() != NetworkManager::Device::Modem) > + break; > + `continue`? REPOSITORY R116 Plasma Network Management Applet BRANCH returnearly REVISION DETAIL https://phabricator.kde.org/D24905 To: nicolasfella, jgrulich Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
