D24161: Make KCM look more like applet

2019-09-28 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. In D24161#538988 , @ngraham wrote: > Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port de

D24289: Fix wrong KCM device icon for specific form factors

2019-09-28 Thread Sefa Eyeoglu
sefaeyeoglu created this revision. sefaeyeoglu added reviewers: VDG, Plasma, ngraham, GB_2. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY The KCM did not know how different form factors should be displayed

D24283: Add clang format file

2019-09-28 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Kate have just clang-formatted all their code, a few other proejcts have too (see T11214

D24161: Make KCM look more like applet

2019-09-28 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. In D24161#538988 , @ngraham wrote: > Nice work. Landed on master so we have plenty of time to polish it up in follow-up patches. Speaking of that, I have a suggestions for unifying the UI even more: for multi-port de

D20972: [sidebar] Make search field not glued to the separator

2019-09-28 Thread Björn Feber
GB_2 requested changes to this revision. GB_2 added a comment. This revision now requires changes to proceed. In D20972#517463 , @filipf wrote: > D23274 makes this unnecessary. It landed. REPOSITORY

D23274: Add "Show intro page" button to System Settings sidebar

2019-09-28 Thread Björn Feber
GB_2 added a comment. This can be closed. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham, mart Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2019-09-28 Thread Björn Feber
GB_2 added a comment. Is there a reason this isn't landed yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: GB_2, elcste, shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, LeGast00n, The-F

D13881: oxygen-demo : add KMessage preview

2019-09-28 Thread Björn Feber
GB_2 added a comment. Looks fine IMO. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D13881 To: rjvbb, #vdg, plasma-devel Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesli

D10263: Fix being unable to close the toolbox menu by clicking outside

2019-09-28 Thread Björn Feber
GB_2 added a comment. Can be abandoned because of D24265 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbamp