sefaeyeoglu added a comment.

  In D24161#538988 <https://phabricator.kde.org/D24161#538988>, @ngraham wrote:
  
  > Nice work. Landed on master so we have plenty of time to polish it up in 
follow-up patches. Speaking of that, I have a suggestions for unifying the UI 
even more: for multi-port devices, show the port chooser combobox instead of 
the name of the current port, in both the KCM and the applet. There's 
guaranteed to be enough room (we'd be replacing a string with the same string 
in a combobox). Then remove the "Ports" items in the applet's hamburger menu.
  >
  > Oh and I just noticed a regression I didn't see before landing the patch, 
sorry. :/ The icons no longer match between the KCM and the applet when I add 
an external bluetooth device: F7450714: Screenshot_20190927_163022.png 
<https://phabricator.kde.org/F7450714>
  
  
  I created a new Diff to fix this: D24289 <https://phabricator.kde.org/D24289>

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg, ngraham, GB_2
Cc: drosca, ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

Reply via email to