D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-07 Thread Nathaniel Graham
ngraham added a comment. One thing I just noticed is missing is the option to quickly switch the whole display to use the opposite color scheme (i.e. Breeze Dark if you're using default Breeze) The current version cuttlefish does this and I find it quite handy. It would also be nice if

D12827: Added process details in the process list context menu

2019-09-07 Thread Chris Xiong
chrisx added a comment. Patch updated. Any suggestions? REVISION DETAIL https://phabricator.kde.org/D12827 To: chrisx, broulik, davidedmundson, mart Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBo

D12827: Added process details in the process list context menu

2019-09-07 Thread Chris Xiong
chrisx updated this revision to Diff 65628. chrisx added a reviewer: mart. chrisx added a comment. Rebased to master. Removed uses of deprecated class (QRegExp). Tidied the code up a bit. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12827?vs=35891&id=65628 REVISION DETAIL https

D23057: Use new Kirigami ListSectionHeader component on Updates and Sources pages

2019-09-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:296847184e07: Use new Kirigami ListSectionHeader component on Updates and Sources pages (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator

D23054: [Notifications] Use new Kirigami ListSectionHeader component in KCM's sources page

2019-09-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:af7252500c47: [Notifications] Use new Kirigami ListSectionHeader component in KCM's sources… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

2019-09-07 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R124:34ee0e8f6d7f: [Sidebar] Use new Kirigami ListSectionHeader component (authored by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23052?vs=65623&id

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

2019-09-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 65623. ngraham added a comment. Rebase REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23052?vs=63433&id=65623 BRANCH use-new-kirigami-section-header (branched from master) REVISION DETAIL https://phabricat

D23569: Request matching version of plasma-workspace libs

2019-09-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:587cb671d4cc: Request matching version of plasma-workspace libs (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23569?vs=64954&i

D23776: Add icon to "Move to Desktop/Activity" task manager context menu item and fix capitalizations

2019-09-07 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ffee9c4097a3: Add icon to "Move to Desktop/Activity" task manager context menu item and fix… (authored by Bjrn Feber , committed by GB_2). REPOSITORY R119 Plasma Desktop CHAN

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65595. GB_2 added a comment. Also add icon for "Move to Activity" item REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23776?vs=65590&id=65595 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23776 A

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2019-09-07 Thread David Edmundson
davidedmundson added a comment. There's some new env vars in Qt 5.14 to set a policy of what to do with DPI. Might be useful. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: snugghash, gladhorn, mart, hein, ngraham, graesslin, davidedmun

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

2019-09-07 Thread Björn Feber
GB_2 added a comment. In D23776#527312 , @ngraham wrote: > Any reason not to add an icon for Move to Activity as well? Forgot that, will do. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23776 To: GB_2,

D23776: Add icon to "Move to Desktop" task manager context menu item and fix capitalizations

2019-09-07 Thread Nathaniel Graham
ngraham added a comment. Any reason not to add an icon for Move to Activity as well? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23776 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, G

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65592. GB_2 added a comment. Don't hide button if revealing password, like in the PolKit dialog and simplify code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65585&id=65592 BRANCH arcpatc

D23776: Add icon to "Move to Desktop" task manager context menu item

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65590. GB_2 added a comment. Also fix "Move to Activity" capitalization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23776?vs=65587&id=65590 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23776

D23776: Add icon to "Move to Desktop" task manager context menu item

2019-09-07 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7327853: Move to Desktop Task Manager Context Menu Item Icon.png

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65585. GB_2 added a comment. Fix normal text fields REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65551&id=65585 BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362

Re: how to customize Desktop widget (Plasma) with batch request

2019-09-07 Thread Aleix Pol
On Tue, Sep 3, 2019 at 2:28 PM An Liu wrote: > > Hi, List > > Here is how we play with desktop environment: > We used to startup traditional desktop via >a) vncserver with noxstartup on :N as X server >b) setting up user environment (e.g, copy application.desktop template > to ~/D

D23727: Provide a simple test tool to see what autostart will look like

2019-09-07 Thread Aleix Pol Gonzalez
apol added a comment. plasma-checkautostart? plasma-autostart-list? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23727 To: apol, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fb

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

2019-09-07 Thread Luca Carlon
luc4 added a comment. Sorry but someone will have to also commit for me, I don't have commit access. Thanks! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D23727: Provide a simple test tool to see what autostart will look like

2019-09-07 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Cool. I dont like the binary name. It doesn't imply debug or listing things. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.k

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:b520a03420ec: Observe title tag only if there actually is a player (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23773?vs

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Kai Uwe Broulik
broulik updated this revision to Diff 65580. broulik added a comment. - init with initial value REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23773?vs=65575&id=65580 REVISION DETAIL https://phabricator.kde.org/D23773 AFFECTED FILES

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > broulik wrote in content-script.js:333 > An empty title is kinda pointless anyway, so this is on purpose It would still send an empty title on initialization or changes after the first change though. So if that's the purpose of the empty string ass

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

2019-09-07 Thread Luca Carlon
luc4 added a comment. Ping. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > fvogt wrote in content-script.js:333 > No, it won't be. Currently it won't send a notification if the title changes > to an empty string as `document.title` was sent initially (line 319) An empty title is kinda pointless anyway, so this is on pur

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > broulik wrote in content-script.js:333 > This is to store the name and only send a change when it is different from > last time I sent it. `document.title` will be the same as > `titleTag.innerText` rendering this check moot No, it won't be. Curre

D23502: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar

2019-09-07 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R169:57266693f2fc: Replace the custom overflow button with PrivateActionToolButton in ActionToolBar (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D23501: If a submenu action has an icon set, make sure to also display it

2019-09-07 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R169:b5d86e2fc7e7: If a submenu action has an icon set, make sure to also display it (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23501?vs=64

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > fvogt wrote in content-script.js:333 > Why not document.title? This is to store the name and only send a change when it is different from last time I sent it. `document.title` will be the same as `titleTag.innerText` rendering this check moot R

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > content-script.js:333 > +if (!titleTagObserver) { > +oldPageTitle = ""; > + Why not document.title? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23773 To: broulik, #plasma, fvogt, ognarb

D23773: Observe title tag only if there actually is a player

2019-09-07 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Noticed that I got title changes sent to the extension every time - Opened an ajax-nav

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

2019-09-07 Thread Kishore Gopalakrishnan
kishoreg created this revision. kishoreg added reviewers: ngraham, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Recently, I submitted this patch (https://phabricator.kde.org/D23082) which had a sid

D10362: Change reveal password button logic

2019-09-07 Thread Björn Feber
GB_2 updated this revision to Diff 65551. GB_2 added a comment. Use `length` property and stop revealing password if field is empty REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=65541&id=65551 BRANCH arcpatch-D10362 REVISION