kishoreg created this revision. kishoreg added reviewers: ngraham, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision.
REVISION SUMMARY Recently, I submitted this patch (https://phabricator.kde.org/D23082) which had a side-effect which I hadn't noticed at the time: If the user-configured maximum volume for the applet was less than 100%, it would also use this as the maximum value on the sliders for all streams. Before this patch: Devices tab: F7326896: Screenshot_20190907_163232.png <https://phabricator.kde.org/F7326896> Applications tab: F7326898: Screenshot_20190907_163203.png <https://phabricator.kde.org/F7326898> I have set the maximum volume in the applet settings to be 15%, and this setting is applied to all the sliders. Even the sliders which are intially at 100% get their maximum reset to 15% as soon as I interact with them. Note, for example, how even the microphone volume is capped at 15%. After this patch: Devices tab: F7326904: Screenshot_20190907_164055.png <https://phabricator.kde.org/F7326904> Applications tab: F7326905: Screenshot_20190907_162913.png <https://phabricator.kde.org/F7326905> The maximum volume is still set to 15% in the applet settings, but this is does not affect the maximum values of the sliders for the device or application streams. TEST PLAN 1. Right-click on applet > 'Configure audio 2. Try to set maximum volume < 100% and click 'OK'. 3. Scroll on the systray icon to change maximum volume. Check if it is limited to the configured maximum. 4. Open the applet and check that all the streams are not limited to the value to the value the user configured in the applet. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23768 AFFECTED FILES applet/contents/ui/ListItemBase.qml To: kishoreg, ngraham, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
