D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:523249683744: [GTK3] Make CSD window decorations 18px instead of 16px (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23560?vs=64933&id=64

D23520: Add time line to X axis

2019-08-29 Thread fuk sitter
fuksitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R102

D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread fuk sitter
fuksitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R98 B

D23568: Use custom event rather than window.postMessage

2019-08-29 Thread fuk sitter
fuksitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R856

D23566: Move code to send signals and set priority of processes to a dedicated object

2019-08-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in process_controller.h:89 > Eww, it would be better if we could make this a qwindow, but I see you're > limited by current KAuth Agreed. I did look at what would be needed to do that, but the entire widget thing is embedd

D23568: Use custom event rather than window.postMessage

2019-08-29 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:1eda6e4387da: Use custom event rather than window.postMessage (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23568?vs=6495

D23568: Use custom event rather than window.postMessage

2019-08-29 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works fine REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23568 To: broulik, #plasma, ognarb, fvogt, davidedmundson Cc: plasma-devel, LeG

D23568: Use custom event rather than window.postMessage

2019-08-29 Thread Kai Uwe Broulik
broulik updated this revision to Diff 64957. broulik retitled this revision from "Call window.postMessage with targetOrigin" to "Use custom event rather than window.postMessage". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment.

D23520: Add time line to X axis

2019-08-29 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better. The UI and functionality look great now. I'll hand this over to the #plasma people for code review now. REPOSITORY R102 KInfo

D23568: Call window.postMessage with targetOrigin

2019-08-29 Thread Fabian Vogt
fvogt added a comment. In D23568#522065 , @broulik wrote: > What we could also do which I just realized is that we could send a `CustomEvent` to the `window` instead of using `postMessage` > Basically what we did before except without a wrappe

D23568: Call window.postMessage with targetOrigin

2019-08-29 Thread Kai Uwe Broulik
broulik added a comment. What we could also do which I just realized is that we could send a `CustomEvent` to the `window` instead of using `postMessage` Basically what we did before except without a wrapper `div` as `window` seems to be the same in both content script and website. REPOSIT

D23125: fix bridge master:slave mapping by-name

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R116 P

D23125: fix bridge master:slave mapping by-name

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R116 P

D22376: new env var DRKONQI_HTTP_DELAY_MS to force a connection delay

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R871 D

D23569: Request matching version of plasma-workspace libs

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R119 P

D23261: Add option to discourage reporting bugs

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R871 Dr

D23569: Request matching version of plasma-workspace libs

2019-08-29 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We never remember to manually update it given the tight plasma coupling.

D23261: Add option to discourage reporting bugs

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? dont forgot to add on

D23241: Show application window icon on AboutPage

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R169 Ki

D22616: Remove phonon KCM

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R119 Pl

D23558: Use KBusyIndicatorWidget

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R97 Blu

D23568: Call window.postMessage with targetOrigin

2019-08-29 Thread Kai Uwe Broulik
broulik added a comment. Further down it says > It is not possible for content or web context scripts to specify a targetOrigin to communicate directly with an extension (either the background script or a content script). REPOSITORY R856 Plasma Browser Integration REVISION DETAIL h

D23253: [Notifications] Don't allow popup to obscure things in corners

2019-08-29 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf931ee1b403: [Notifications] Don't allow popup to obscure things in corners (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23253?vs

D23253: [Notifications] Don't allow popup to obscure things in corners

2019-08-29 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. master only, please REPOSITORY R120 Plasma Workspace BRANCH notification-popups-dont-obscure-things-in-corners0anymore (branched from master) REVISION DETAIL https://phabricator.k

D23568: Call window.postMessage with targetOrigin

2019-08-29 Thread Fabian Vogt
fvogt added a comment. > Always provide a specific targetOrigin, not *, if you know where the other window's document should be located. Failing to provide a specific target discloses the data you send to any interested malicious site. I wonder whether that is relevant to us? REPOSITORY

D23567: [Colors KCM] Don't explicitly reload KWin's configuration

2019-08-29 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf434825f4bf: [Colors KCM] Don't explicitly reload KWin's configuration (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23567?vs=64943&

D23568: Call window.postMessage with targetOrigin

2019-08-29 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, ognarb, fvogt, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY According to documentation [1] `targetOrigin` is a required argument

D23566: Move code to send signals and set priority of processes to a dedicated object

2019-08-29 Thread David Edmundson
davidedmundson added a comment. ++ Looks nice and simplifies this old mega class INLINE COMMENTS > process_controller.h:89 > + */ > +void setWidget(QWidget *widget); > + Eww, it would be better if we could make this a qwindow, but I see you're limited by current KAuth > ksysgu

D23567: [Colors KCM] Don't explicitly reload KWin's configuration

2019-08-29 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY KWin watches decoration palette changes on its own. When Plasma changes its colorscheme it

D23566: Move code to send signals and set priority of processes to a dedicated object

2019-08-29 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This pulls the code out of KSysGuardProcessList and introduces it in a new class called Pr

D23560: [GTK3] Make CSD window decorations 18px instead of 16px

2019-08-29 Thread Carson Black
cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY As mentioned by @ndavis in D23547 , window buttons should be 18p

D23547: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme.

2019-08-29 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:7b3d0777ea6c: [GTK3] Have checkboxes and radiobuttons respect the user's color scheme. (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D235

D23558: Use KBusyIndicatorWidget

2019-08-29 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Lovely! Designer widget is in kdesingerplugin FTR. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D23558 To: broulik, #vdg, sitter, drosca Cc: plasma-devel,

D23558: Use KBusyIndicatorWidget

2019-08-29 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: VDG, sitter, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it high-dpi capable and just looks smoother. TEST PLAN Before F7291154: Scr

D23520: Add time line to X axis

2019-08-29 Thread Alex Debus
alexde added a comment. Right now I only display the date under the tick mark if the date has changed and the tickmark number is odd, which I think is already good enough for this graph. However, indicating a date change at midnight (12 pm / 0 am) would make sense as well. If you prefer th

D23520: Add time line to X axis

2019-08-29 Thread Alex Debus
alexde updated this revision to Diff 64920. alexde added a comment. Fix displaying wrong variable. Add postfix "Str" to indicate that those vars are explicitely strings. Make sure that the date is only displayed when date has changed for <= 24h graphs. REPOSITORY R102 KInfoCenter CHANG