davidedmundson added a comment.
++
Looks nice and simplifies this old mega class
INLINE COMMENTS
> process_controller.h:89
> + */
> + void setWidget(QWidget *widget);
> +
Eww, it would be better if we could make this a qwindow, but I see you're
limited by current KAuth
> ksysguardprocesslist.cpp:1316
> + } else if (result == KSysGuard::ProcessController::Result::Error) {
> KMessageBox::sorry(this, i18n("You do not have the permission to
> kill the process and there "
> + "was a problem trying to run as
> root."));
If we're invoking this from QML any call that spawns an event loop has the
potential to crash.
box = new KMessageBox()
box->setAttribute(DeleteOnClose);
box->show();
would probably help
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D23566
To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
