D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b0f1d6620d78: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage (authored by arojas). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. 👍 👍 REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sync-scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D22700 To: filipf, #plasma, davidedmundson, ngraham Cc: plasma-devel, LeGast00n, jraleigh,

D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Bhushan Shah
bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Nice work finding this bug! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22707 To: arojas, bshah, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas

D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas
arojas added a comment. Just noticed this is fixed in master already, so this is for 5.16 only REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22707 To: arojas, bshah, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, h

D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: bshah, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY Otherwise they may not get assigned any value if the xft exclude range is (0,0), which will mak

D22684: [Klipper] Fix clipboard history management

2019-07-23 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62444. pdabrowski retitled this revision from "[Klipper] Fix clipboard history clearing" to "[Klipper] Fix clipboard history management". pdabrowski edited the summary of this revision. pdabrowski added a comment. This revision is now accepted and ready to

D22691: Remove the share dataengine.

2019-07-23 Thread Aleix Pol Gonzalez
apol added a comment. +1 this was used by the pastebin plasmoid which was replaced by QuickShare when ported to Plasma 5. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22691 To: aacid Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragree

D22702: [fileitemaction] Clean up includes

2019-07-23 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN Builds, actions in Dolphin work REPOSITORY R845 Plasma Vault BRANCH incl REVISION DET

D22700: Sync scaling DPI from Plasma to SDDM

2019-07-23 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds scaling to the list of Plasma settings that can be synced with SDDM. REPOSITORY R123 SDDM Configuration Panel (KCM

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev abandoned this revision. rgeorgiev added a comment. @broulik Hmm, now I think that I understood the rationale why SoundCloud support is activated using the **Enhanced Media Controls** option. As you commented on my other revision (D22632 ), Soun

D22632: Implement support for the "next" and "previous" actions in SoundCloud

2019-07-23 Thread Radoslav Georgiev
rgeorgiev added a comment. In D22632#499813 , @broulik wrote: > -1 > Site-specific workarounds are not in scope for this extension. > Also, SoundCloud uses Media Session API and provides callbacks on its own. I'm sorry; I was not awa

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev planned changes to this revision. rgeorgiev added a comment. In D22631#499815 , @broulik wrote: > I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You might

D22684: [Klipper] Fix clipboard history clearing

2019-07-23 Thread Piotr Dabrowski
pdabrowski added a comment. Weak pointer might not work well for this after all. I need to have a second look at this patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: plas

Re: plasma-thunderbolt

2019-07-23 Thread Harald Sitter
IIRC it's been sitting in review for months and weeks ago on IRC we already agreed that it only needs moving? Specifically that conversation caused me to fix a daemon lookup issue for debian distros as I recall. On Tue, Jul 23, 2019 at 5:17 PM Nate Graham wrote: > > That was the idea. Let's get

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing

2019-07-23 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch! A more descriptive Description section would be appreciated: you could explain what the issue is and how specifically this patch fixes it. In general that improves the likelihood of quick review. :) REPOSITORY R120 Plasma Workspace REVIS

D22627: Add a GUI option for choosing the input method

2019-07-23 Thread Nathaniel Graham
ngraham added a comment. In D22627#500454 , @filipf wrote: > Yeah an empty entry is bad UI but it works for the code since it ends up just grabbing the text from the combobox and writing it to the config file :P ... it was a quick solution I'll

Re: Plasma 2020 release schedules

2019-07-23 Thread Alexander Potashev
вт, 23 июл. 2019 г. в 19:04, Rik Mills : > > On 23/07/2019 16:53, Jonathan Riddell wrote: > > > https://community.kde.org/Schedules/Plasma_5 > > Has someone made changes to how table formatting is done there, or on > the wiki as a whole? That lack of table lines and borked alignment looks > dreadfu

D21829: Improved Touch support for Kickoff

2019-07-23 Thread Steffen Hartleib
steffenh added a comment. Hi @hein. > Before we discuss alternatives: Are you willing to have me try and teach you? I'm actually going to be very busy with a move in the next few weeks, so this could end up taking quite significant time between the two of us, but if you have the time an

D22691: Remove the share dataengine.

2019-07-23 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY It seems it's unused and also is the only source code in all of the KDE repos that uses kjsembed REPOSITORY R120 Plasma Workspace B

Re: Plasma 2020 release schedules

2019-07-23 Thread Rik Mills
On 23/07/2019 16:53, Jonathan Riddell wrote: > https://community.kde.org/Schedules/Plasma_5 Has someone made changes to how table formatting is done there, or on the wiki as a whole? That lack of table lines and borked alignment looks dreadful. > Distros, please say if you would like any of thes

Plasma 2020 release schedules

2019-07-23 Thread Jonathan Riddell
I've added proposed release schedules for Plasma for 2020. It sticks to the current formula of three releases a year, repo freeze before the KF5 release, beta after the KF5 release, .0 3 weeks after that, then five bugfix releases in 1,1,2,3,5 fibbonchi week periods. https://community.kde.org/Sch

Re: plasma-thunderbolt

2019-07-23 Thread Nate Graham
That was the idea. Let's get it through the process ASAP if this has to happen first. Nate On 7/23/19 8:26 AM, Jonathan Riddell wrote: Is Plasma Thunderbolt expected to be a new git repo to be released as part of Plasma 5.17?  If so it should go through kdereview pronto. Jonathan

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

2019-07-23 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62410. pdabrowski added a comment. new diff: much better patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=62398&id=62410 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES k

D22680: Airplane mode improvements

2019-07-23 Thread Nathaniel Graham
ngraham added a comment. Nice! This resolves the only issues I had with it. REPOSITORY R116 Plasma Network Management Applet BRANCH airplane-improved REVISION DETAIL https://phabricator.kde.org/D22680 To: jgrulich, #plasma, apol Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampalo

Re: Qt version needed by Plasma 5.17

2019-07-23 Thread Kai Uwe Broulik
Hi, I would prefer to keep Qt 5.12 supported, but maybe explicitly the latest patch release, i.e. 5.12.4 or so. Quickly skimming through the changelogs of Qt 5.13 I don't see any groundbreaking new features that I would want to use. The Frameworks Qt requirement policy [1] was also updated r

plasma-thunderbolt

2019-07-23 Thread Jonathan Riddell
Is Plasma Thunderbolt expected to be a new git repo to be released as part of Plasma 5.17? If so it should go through kdereview pronto. Jonathan

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

2019-07-23 Thread Piotr Dabrowski
pdabrowski updated this revision to Diff 62398. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22684?vs=62395&id=62398 REVISION DETAIL https://phabricator.kde.org/D22684 AFFECTED FILES klipper/klipper.cpp To: pdabrowski, #plasma, #plasma_workspa

D22684: [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366)

2019-07-23 Thread Piotr Dabrowski
pdabrowski created this revision. pdabrowski added reviewers: Plasma, Plasma: Workspaces, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pdabrowski requested review of this revision. REVISION SUMMARY Fixed clipboard history clearing in Klipper: https://bugs.k

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 71 - Still Failing!

2019-07-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/71/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 23 Jul 2019 13:45:22 + Build duration: 8 min 4 sec and counting CONSOLE OUTPUT [...tru

D22553: guard against plasmashell being properly dead and not showing the SNI

2019-07-23 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:3eeb0ce5bc1e: guard against plasmashell being properly dead and not showing the SNI (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22553?vs=62045&id=62393#toc REPOSITORY

Qt version needed by Plasma 5.17

2019-07-23 Thread Jonathan Riddell
Qt 5.13 was released on June 19th https://blog.qt.io/blog/2019/06/19/qt-5-13-released/ Plasma 5.17 is scheduled for 10th October https://community.kde.org/Schedules/Plasma_5 We have yet to decide which version of Qt we will say Plasma 5.17 works with. If nobody has a reason to need Qt 5.13 I wil

D22680: Airplane mode improvements

2019-07-23 Thread Jan Grulich
jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY - make the airplane mode to persist reboot/suspend or plasma restart - make the airplane mode to disable/enable BT devices - m