D22191: Implement syncing of theme preferences between SDDM and Plasma

ndavis added a comment. In D22191#489915 , @GB_2 wrote: > In D22191#489838 , @ndavis wrote: > > > > Settings UI: > > > F6953661: Screenshot_20190701_234413.png

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added inline comments. INLINE COMMENTS > kcm_sddm.actions:301 > +Name=Sync Settings > +Description=Syncs user settings with SDDM settings > +Policy=auth_admin I think the long form of sync would be better in the description: Synchronizes REPOSITORY R123 SDDM Configuration Panel (KCM) RE

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added inline comments. INLINE COMMENTS > advanceconfig.ui:226 > + > + > + It would be nice if you added the icon `view-refresh` to this button... > advanceconfig.ui:233 > + > + > + ...and here the icon `document-revert` or `edit-undo`. > ad

D22191: Implement syncing of theme preferences between SDDM and Plasma

GB_2 added a comment. In D22191#489838 , @ndavis wrote: > > Settings UI: > > F6953661: Screenshot_20190701_234413.png > > This control layout seems to imply that a user must press the "Sync" button e

D22191: Implement syncing of theme preferences between SDDM and Plasma

ndavis added a comment. > Settings UI: > F6953661: Screenshot_20190701_234413.png This control layout seems to imply that a user must press the "Sync" button every time they change their user settings. Wouldn't a checkbox for continual synch

Re: Tipping the apple cart?

Please lets keep in mind that this is not a thread to complain about Gitlab. No platform is perfect, and we're not yet on production machines. This thread is about how to make our review process great for both newbies and experienced developers, *and reviewers* - on Gitlab. On Sun, Jun 30, 2019 a

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson added a comment. Yeah, I understand the situation. LightDM (when I worked on it at least) used to support the Icon property in the .desktop file. That'd be a quick and easy way to add an extra clarification on which one is wayland in the short term. -

D22223: Seek to end as mpris next action

seijikun created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. seijikun requested review of this revision. REVISION SUMMARY Most pages where the mpris functionality is used will probably have an auto-continue feature for when the end of a media is reach

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson updated this revision to Diff 61015. davidedmundson marked an inline comment as done. davidedmundson added a comment. whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=61014&id=61015 BRANCH master REVISION DETAIL

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson updated this revision to Diff 61014. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=60421&id=61014 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21995 AFFECTED FILES

D19389: Rewrite kworkspace logout, shutdown and suspend API

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cd3e9a291a66: Rewrite kworkspace logout, shutdown and suspend API (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19389?vs=60969&id=61013#toc REPOSITORY R120 Pla

D19389: Rewrite kworkspace logout, shutdown and suspend API

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > loginddbustypes.h:105 > +{ > +public: > +uint userId; It's a `struct` already REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phab

D22162: taskmanager: performance

This revision was automatically updated to reflect the committed changes. Closed by commit R120:50c391cc6c1b: taskmanager: performance (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22162?vs=60854&id=61012 REVISION DETAIL https:/

D22162: taskmanager: performance

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. In D22162#488378 , @ngraham wrote: > Not sure if it's related, but while you're at it, would you be able to also fix these errors when hovering ov

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. asturmlechner requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D22213: [Tab] Fix sizing

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Repliaces `QTabBar::tabSizeHint` for desktop style. Not every style implements custom size h

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. This is a necessary step to avoid having two indistinguishable "Plasma" options in SDDM with the linked PR merged and all other DMs , the other option is to have a "Plasma (Wayland) (Wayland)" in sddm only. AFAICT the translations for Name need to be removed though

D22212: change username labels to e-mail address instead

sitter created this revision. sitter added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY users in bugzilla are always identified by their email address so it makes no sense to labe

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in advanceconfig.cpp:179 > If it's empty, you print a message, which is fine, but then we still add an > empty entry to our map, and still try to copy the file? Should I just bring back the code that only does the copy operati

D22190: auto log in if username and password have been loaded from kwallet

This revision was automatically updated to reflect the committed changes. Closed by commit R871:add2ad75e362: auto log in if username and password have been loaded from kwallet (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22190?vs=60933&id=61000#toc REPOSITORY R

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/14/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 02 Jul 2019 11:39:47 + Build duration: 5 min 18 sec and counting CONSOLE OUTPU

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/47/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 02 Jul 2019 11:39:50 + Build duration: 4 min 34 sec and counting CONSOLE OUTPUT [...tr

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with: - Plasma - Plasma (Wayland) Per linked issue it is not going to be like that forever; on every(?) other

D22065: Introduce PluginManager

broulik updated this revision to Diff 60997. broulik added a comment. - Also remove `pluginProtocolVersion`, can just call `AbstractBrowserPlugin::protocolVersion()` REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22065?vs=60996&id=60997

D22065: Introduce PluginManager

broulik updated this revision to Diff 60996. broulik added a comment. - Operate on `AbstractBrowserPlugin *` exclusively - Cleanup REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22065?vs=60554&id=60996 REVISION DETAIL https://phabric

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This means most our normal users in an office who don't know/care if they're running X11 or wayland have some extra tech-garbage after the name. REPOSITORY R120

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY SDDM as of 0.18.1 appends " (Wayland)" to the Name of any session file it find

D22191: Implement syncing of theme preferences between SDDM and Plasma

davidedmundson added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:54-55 > +{ > +KUser sddmUser(QStringLiteral("sddm")); > +KUser sddmGroup(QStringLiteral("sddm")); > + do we need two objects representing the same user? > advanceconfig.cpp:179 > + > +if (fontconfigPath.isEmp

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 60993. filipf added a comment. remove 2 unused imports REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=60992&id=60993 BRANCH sddm-theme-syncing (branched from master) REVISION DETAIL

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf marked an inline comment as done. filipf added inline comments. INLINE COMMENTS > ngraham wrote in sddmauthhelper.cpp:37 > This change to alphabetize the includes is good, but should be done in > another commit (feel free to commit directly) as it doesn't directly pertain > to the change

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 60992. filipf added a comment. get rid of KDevelop files that accidentally got added to the diff REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=60991&id=60992 BRANCH sddm-theme-syncing

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 60991. filipf marked an inline comment as done. filipf added a comment. - Merge branch 'master' into sddm-theme-syncing REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=60978&id=60991 BRANC

D22208: Fix toolTipDelegate.virtualDesktopParent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7affafa425b: Fix toolTipDelegate.virtualDesktopParent (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22208?vs=60987&id=60990 REVISI

D22207: Silence qml error message

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d80d3aaebadf: Silence qml error message (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22207?vs=60986&id=60989 REVISION DETAIL htt

D21927: Use window.postMessage instead of creating a wrapper item

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b1ea6f2de39a: Use window.postMessage instead of creating a wrapper item (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D219

D22208: Fix toolTipDelegate.virtualDesktopParent

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY The logic tried to do an early return, but that doesn't work with ||, so use && and check if

D22207: Silence qml error message

gladhorn created this revision. gladhorn added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY model.AppPid is documented to not always exist, so use the same check that is used in othere

D21968: Set desktopFileName

This revision was automatically updated to reflect the committed changes. Closed by commit R856:22a0e85e807d: Set desktopFileName (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21968?vs=60251&id=60985#toc REPOSITORY R856 Plasma Browser Integration CHANGES SINCE L

D22068: Send downloads when downloads plugin is loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R856:76d4b765f4f1: Send downloads when downloads plugin is loaded (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22068?vs=60557