broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY Repliaces `QTabBar::tabSizeHint` for desktop style. Not every style implements custom size hints for tabs, where it would just fall through to returning `sizeFromContents` as it is passed in, leading to tiny tabs. BUG: 409390 TEST PLAN Before (Breeze) F6956383: Screenshot_20190702_161243.png <https://phabricator.kde.org/F6956383> Before (Fusion, slightly broken, we might not take into account the vertical offset for inactive tabs?) F6956385: Screenshot_20190702_161253.png <https://phabricator.kde.org/F6956385> Before (Kvantum, hideous as usual) F6956389: Screenshot_20190702_161302.png <https://phabricator.kde.org/F6956389> Before (QtCurve, unusable) F6956390: Screenshot_20190702_161344.png <https://phabricator.kde.org/F6956390> After (Breeze, no change) F6956391: Screenshot_20190702_161209.png <https://phabricator.kde.org/F6956391> After (Fusion, more correct now, doesn't fall back to 2 * grid unit anymore) F6956392: Screenshot_20190702_161140.png <https://phabricator.kde.org/F6956392> After (Kvantum, even more hideous) F6956395: Screenshot_20190702_161159.png <https://phabricator.kde.org/F6956395> After (QtCurve, now mostly correct, not sure why the width is off) F6956397: Screenshot_20190702_161149.png <https://phabricator.kde.org/F6956397> REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22213 AFFECTED FILES plugin/kquickstyleitem.cpp To: broulik, #plasma, mart Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
