D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. +100 Will do a bigger review and test tomorrow! INLINE COMMENTS > config.qml:147 > +{ > +'label': i18nd("plasma_wallpaper_org.kde.image", > "Modification time (oldest first"), > +'slideshowMode': Wallpaper

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis added a comment. Since these seem to be scaled 2x, the thicker (6px@2x) highlight is more desirable. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22128 To: filipf, #plasma, #vdg Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragr

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis added a comment. Why is the tab highlight thicker in these F6939066: Screenshot_20190627_234222.png F6939070: Screenshot_20190628_000624.png And thinner in these? F6939067: Screenshot_2019062

D22132: Initialize view with the right size

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise there's some logical glitches and the image ends up being loaded 3 times. TEST PLAN qDebug

D22128: [Kickoff] Redo tab bar separator's geometry

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch makes Kickoff tab indicators glide(patch _) on the tab bar separator in all 4 orientations. REPOSITORY R119 Plasma Desk

D21959: Fix selectedNameFilter() multiple matches

dfaure closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesj

D22106: [Separator] Match Breeze borders' color

ndavis added a comment. +1 visually, but I agree that the Breeze Widget theme should be the part that provides the theming, if possible. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22106 To: filipf, #kirigami, #vdg, ngraham Cc: ndavis, mglb, apol, plasma-devel,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

filipf added a comment. Awesome 😍 INLINE COMMENTS > config.qml:135 > +{ > +'label': i18nd("plasma_wallpaper_org.kde.image", > "Alphabetical (A first)"), > +'slideshowMode': Wallpaper.Image.Alphabetical Instead of "A first" I think we

D22122: use pwquality_strerror to get error strings

sitter added inline comments. INLINE COMMENTS > anthonyfieroni wrote in passworddialog.cpp:157 > Shouldn't be fromUtf8 ? You can't handle all languages by latin. Oh, indeed! REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22122 To: sitter, #plasma Cc: anthonyfier

D16425: Added new Suspend then Hibernate option

meven added a comment. I tried using it but my system does not suspend-then-hibernate mode. You can check if your system supports it once you have systemd >= 239 and the following command returns true : qdbus org.freedesktop.PowerManagement /org/freedesktop/PowerManagement CanSusp

D22122: use pwquality_strerror to get error strings

anthonyfieroni added inline comments. INLINE COMMENTS > passworddialog.cpp:157 > +const QString errorString = > +QString::fromLatin1(pwquality_strerror(buf, > PWQ_MAX_ERROR_MESSAGE_LEN, > + error, auxerror)); Shouldn't be fromUtf

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/13/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 27 Jun 2019 14:04:42 + Build duration: 8 min 47 sec and counting CONSOLE OUTPU

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 37 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/37/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 27 Jun 2019 14:04:42 + Build duration: 3 min 48 sec and counting CONSOLE OUTPUT [...tr

D22106: [Separator] Match Breeze borders' color

mglb added a comment. Widgets style: https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76 Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha and either color mixing or transparent text color. REPOSITORY R169 Kirigami REVISION DETAIL https://phabr

D22122: use pwquality_strerror to get error strings

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY libpwquality has localized error string mappings, no need to reinvent the wheel here. the previous

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Allows setting of other sorting orders like alphabetical or last modified date. To enable this a new ProxyModel is introduced whi

D18920: Fix and update PCI module

konradr added a comment. Ufff, I can try. Do you want new string names diff separated from "#pragrma pack" diff? However, the only one important change is this two lines: #pragma pack(push, 1) #pragma pack(pop) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde

D21797: do not set a hardcoded minimum size

This revision was automatically updated to reflect the committed changes. Closed by commit R871:fdff5bd4bc20: do not set a hardcoded minimum size (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21797?vs=59989&id=60721 REVISION DETAIL ht

D21801: force the backtracewidget into loading state when the generator is loading

This revision was automatically updated to reflect the committed changes. Closed by commit R871:c2775e7335a1: force the backtracewidget into loading state when the generator is loading (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21801?

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/12/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 27 Jun 2019 11:43:36 + Build duration: 3 min 7 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/36/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 27 Jun 2019 11:43:36 + Build duration: 2 min 41 sec and counting CONSOLE OUTPUT [...tr

D20569: RFC: Use more compact OSD

filipf added a comment. I've been thinking about this OSD themes thing and I can't say I like it. I don't like the fact that you now need a different LnF to change them either, but to have another configurable theme thing seems like overkill. Although it's not without a solution without

D21797: do not set a hardcoded minimum size

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY R871 DrKonqi BRANCH minimums REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma, apol Cc: apol, cfeck, plasma-devel, LeGast00n, jraleigh, fbam

D22106: [Separator] Match Breeze borders' color

apol added a comment. Maybe we should have the Theme provide the opacity somehow? You can look at the kde:breeze repository for the kstyle and others. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22106 To: filipf, #kirigami, #vdg, ngraham Cc: apol, plasma-de

D18860: Add comment / description to the translations kcm

sitter added a comment. Mh, technically it's not setting system language, is it? It changes the user's language but has no facilities to apply that at system scope (i.e. across all users) Looking at the other KCMs the comment is more of the form "Configure/Change/Customize foobar" or "F

D22088: [Notifications] Ignore excess spam

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ed653ba75d6: [Notifications] Ignore excess spam (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22088?vs=60634&id=60715 REVISION DE

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#472572 , @ngraham wrote: > Can you update the test plan to provide examples of themes that are correctly tagged so we can test this? > > - Plasma 5 only theme > - Plasma 4 only theme > - Theme that works

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 27 Jun 2019 08:39:26 + Build duration: 56 sec and counting JUnit Tests Name: pro

D22084: Span wayland objects to lifespan of the QApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R130:bfce3c6727cd: Span wayland objects to lifespan of the QApplication (authored by davidedmundson). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phab