D21561: [Notifier] Delay creating QNetworkConfigurationManager

broulik added a comment. As I feared, no matter if I disconnect, it's always `NetworkAccessible`, even with a stock QML app (i.e. without KIO AccessManager that KDeclarative injects). `QNetworkAccessManager` only checks the actual network session when the `QNetworkConfigurationManager::Netw

D21561: [Notifier] Delay creating QNetworkConfigurationManager

broulik added a comment. Sorry, misread you there. `networkAccessible` could work. It claims to reflect the actual device state and since the `QQmlEngine` already has its own `QNetworkAccessManager` we don't need to create one. I'll give it a go. REPOSITORY R134 Discover Software Store RE

D21561: [Notifier] Delay creating QNetworkConfigurationManager

broulik added a comment. In D21561#473937 , @davidedmundson wrote: > Is QNetworkAccessManager::networkAccessible any better? > > It has an unknown state which implies it might be async. It's the constructor that takes forever, doesn't

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

davidedmundson added inline comments. INLINE COMMENTS > calculator.qml:39 > Plasmoid.switchHeight: Layout.minimumHeight > Layout.minimumWidth: mainLayout.Layout.minimumWidth + 8 > Layout.minimumHeight: mainLayout.Layout.minimumHeight + 8 This will change with the font size, surely

D16425: Added new Suspend then Hibernate option

abalaji added inline comments. INLINE COMMENTS > suspendsessionconfig.cpp:122 > +int comboBoxMaxWidth = 300; > +if (m_suspendThenHibernateEnabled) { > +comboBoxMaxWidth = qMax(comboBoxMaxWidth, > m_suspendThenHibernateEnabled->sizeHint().width()); After doing the above, this if

D21561: [Notifier] Delay creating QNetworkConfigurationManager

davidedmundson added a comment. Is QNetworkAccessManager::networkAccessible any better? It has an unknown state which implies it might be async. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21561 To: broulik, #plasma, apol Cc: davidedmundson,

D21561: [Notifier] Delay creating QNetworkConfigurationManager

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Yes, it's a big one. I was wondering if it would make sense to see if we can improve it on Qt level. INLINE COMMENTS > DiscoverNotifier.cpp:166 > { > +if (!m_manager) { > +m_

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R120:21d8bf8b8700: [sddm-theme] Update theme preview with 5.16 wallpaper (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21560?vs=59095&id=

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! Stable branch, obviously REPOSITORY R120 Plasma Workspace BRANCH new-sddm-theme-preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D21560 To: filip

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

filipf updated this revision to Diff 59095. filipf added a comment. mask white glow on left side REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21560?vs=59091&id=59095 BRANCH new-sddm-theme-preview (branched from master) REVISION DETAIL https

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

filipf updated this revision to Diff 59091. filipf added a comment. change time from 00:00 to 13:37 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21560?vs=59063&id=59091 BRANCH new-sddm-theme-preview (branched from master) REVISION DETAIL ht

D21566: Improve label for Disk Monitor widget

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently it uses up and down arrows, which do not really map to "read" and "write". Thi

D10362: Change reveal password button logic

GB_2 added a comment. In D10362#202592 , @elvisangelaccio wrote: > Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). > > Would it be possible to implement this feature li

D10362: Swap reveal password button logic

GB_2 added a comment. Changed `onClicked` to `onPressedChanged` REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: kde-frameworks-

D10362: Swap reveal password button logic

GB_2 updated this revision to Diff 59081. GB_2 added a comment. Change reveal password button logic REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10362?vs=26701&id=59081 BRANCH change-reveal-password-button-logic (branched from master

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

This revision was automatically updated to reflect the committed changes. Closed by commit R114:987f5fe9bb12: [Calculator] Make buttons' text labels scale in size along with the widget (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. That 12 is a bit random, isn't it? But glad my approach just works™ REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #pl

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. This is the rough patch which gives a rough implementation of this look into qwidget config dialogs F6866217: fullsidebar.diff The real hack which I consider a no-go (and no idea how to avoid) is this piece: - layout->ad

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

ngraham added a comment. Hah, why not? :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21560 To: filipf, GB_2, ngraham, #vdg Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

filipf added a comment. In D21560#473670 , @ngraham wrote: > Just seems like kind of an odd time to have in the screenshot. Maybe choose some other random time, like 9:30 or something. OK, I will edit the diff in a few hours or so (compil

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

ngraham added a comment. Just seems like kind of an odd time to have in the screenshot. Maybe choose some other random time, like 9:30 or something. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21560 To: filipf, GB_2, ngraham, #vdg Cc: plasma-devel, eric

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

filipf added a comment. In D21560#473664 , @ngraham wrote: > `00:00`? I did the 24 hour system, but didn't get any idea about a meaningful number. I'm open to suggestions. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://pha

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

ngraham added a comment. `00:00`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21560 To: filipf, GB_2, ngraham, #vdg Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D21561: [Notifier] Delay creating QNetworkConfigurationManager

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Creating it is quite heavy (25ms here) as it has to query NetworkManager for information. R

D21560: [sddm-theme] Update theme preview with 5.16 wallpaper

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Our current preview has become inaccurate. REPOSITORY R120 Plasma Workspace BRANCH new-sddm-theme-preview (branched from master)

D21433: [kdecoration] Unset resize borders for maximized clients

zzag abandoned this revision. zzag added a comment. Hugo will push a bit simpler solution. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D21433 To: zzag, #plasma Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mo

D21432: [kdecoration] Unset resize borders for maximized clients

zzag abandoned this revision. zzag added a comment. Hugo will push a bit simpler solution. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21432 To: zzag, #plasma Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D15247: Show tooltips in krunner

McPain added a comment. In D15247#472461 , @ngraham wrote: > IMO what's seen in your screenshot is not useful behavior. If the full text fits in the regular UI, there's no need to show a tooltip; it's just redundant. I see. Somehow `subTe

D21497: fill layouts from X server when there are no layouts in config

McPain added a comment. In D21497#472546 , @ngraham wrote: > Looks good and works for me, though I'm not super familiar with this code so I'd appreciate a review from @hein or @broulik. I'll land this tomorrow if everything will be still

D21557: [Media Controller] Anchor album art left and right as well

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Fixes it for me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21557 To: broulik, #plasma, filipf Cc: filipf, plasma-devel, ericadams, jraleigh, GB_2, r

D21557: [Media Controller] Anchor album art left and right as well

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0cd335211ad4: [Media Controller] Anchor album art left and right as well (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21557?vs=590

D21557: [Media Controller] Anchor album art left and right as well

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures it doesn't overflow its bounding box. Shouldn't make a visual differences (save for the m

D21408: RFC: [Notifications] Better notification number alignment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8f1daa56f9e8: Better notification number alignment (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21408?vs=58711&id=59050#toc REPOSITORY R120 Plasma Workspace CHANGES

D21554: Allow setting fullscreen via MPRIS

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This implements `CanSetFullscreen` to return `true` when it's a video and lets the `Fullscr

D21038: Also store the player's frame ID

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:71b4b66d5cf1: Also store the player's frame ID (authored by broulik). REPOSITORY R856 Plasma Browser Integration CH