apol accepted this revision. apol added a comment. This revision is now accepted and ready to land.
Yes, it's a big one. I was wondering if it would make sense to see if we can improve it on Qt level. INLINE COMMENTS > DiscoverNotifier.cpp:166 > { > + if (!m_manager) { > + m_manager = new QNetworkConfigurationManager(this); Explain why in a short comment. Something like `// delay initializing, Qt does a bunch of blocking calls there when using networkmanager` REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21561 To: broulik, #plasma, apol Cc: plasma-devel, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart