D13095: Scren brightness follow a quatratic progression

2019-06-01 Thread Kevin Slagle
kjslag added a comment. In D13095#467997 , @ngraham wrote: > Moving the brightness to zero is supposed to turn the //backlight// off, not the //screen// right? I don't see why. It seems better to put the screen into a low energy mode tha

D21026: Fix ToolButton remaining in a pressed state after press

2019-06-01 Thread Filip Fila
filipf added a comment. In D21026#472883 , @ngraham wrote: > Add `checkable: true` and click it Thanks! I tested it with this in a vacuum and with D21027 and it seems to be working as it should now as

D21026: Fix ToolButton remaining in a pressed state after press

2019-06-01 Thread Filip Fila
filipf updated this revision to Diff 58994. filipf added a comment. restore checkable state REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21026?vs=57574&id=58994 BRANCH no-highlight-color-after-press (branched from master) RE

D21527: Fix the 'Report bug' button being always disabled

2019-06-01 Thread Daniel Vrátil
dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The commit d4ae04a7 h

D21026: Fix ToolButton remaining in a pressed state after press

2019-06-01 Thread Nathaniel Graham
ngraham added a comment. Add `checkable: true` and click it REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21026 To: filipf, mart, #plasma, ngraham, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesli

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-06-01 Thread Filip Fila
filipf added a comment. In D20598#471150 , @meven wrote: > In D20598#471149 , @filipf wrote: > > > In D20598#455424 , @ngraham wrote: > > > > > This doe

D21026: Fix ToolButton remaining in a pressed state after press

2019-06-01 Thread Filip Fila
filipf added a comment. In D21026#462978 , @mart wrote: > but now it doesn't display the checked state in any way? How can I test to see the checked state is working? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D21027: [Notes] Fix icons being almost invisible with light backgrounds

2019-06-01 Thread Filip Fila
filipf added a comment. @broulik I tried again in master and `icon.width` and `icon.height` aren't working for me with this patch. REPOSITORY R114 Plasma Addons BRANCH background-appropriate-icon-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D21027 To: fil

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

2019-06-01 Thread Siddhartha Sahu
siddharthasahu added a comment. I took another look. As I already mentioned, there seems to be a difference between how `onLoginFailed` signals work in both. In the lock screen: - the `onLoginFailed`

D21524: Keep existing configurations' strings               

2019-06-01 Thread Mikhail Zolotukhin
gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Gtk configurator has been replacing .gtkrc-2.0 config file, with it's own settings, discarding present file contents.     Now

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

2019-06-01 Thread Filip Fila
filipf added a comment. I agree with David, when doing these sorts of changes it's imperative they're instantly implemented in all relevant places. I checked SDDM (with our theme) and the password field is disabled when in the timeout period so we need to fix that. Maybe this commit can

D19829: kicker: add option to make root level icons visible

2019-06-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f5ad1bfc33a4: kicker: add option to make root level icons visible (authored by i.Dark_Templar, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.