filipf added a comment.
In D20598#471150 <https://phabricator.kde.org/D20598#471150>, @meven wrote: > In D20598#471149 <https://phabricator.kde.org/D20598#471149>, @filipf wrote: > > > In D20598#455424 <https://phabricator.kde.org/D20598#455424>, @ngraham wrote: > > > > > This doesn't actually work for me. Upon opening, the following is printed to the console: > > > > > > org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was not found." > > > Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", "/usr/bin") > > > The environment variable QT_PLUGIN_PATH might be not correctly set > > > <Unknown File>:3:89: Unable to assign [undefined] to double > > > QQmlExpression: Expression file:///usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:436:33 depends on non-NOTIFYable properties: > > > Solid::Battery::serial > > > > > > > > > I am now getting the same error as well, kcmshell5 is eating up one cpu core in the background. > > > I am not focused on this anymore and might abandon this review as I really don't enjoy Qml hacking and lack of good tooling at least in my experience. If you still have some reserves of energy left, I'd really be appreciated! Someone seems to have fixed the icons so this patch now looks pretty good in 5.15: F6863740: image.png <https://phabricator.kde.org/F6863740> It's a massive improvement over the current state. The only thing to would be to figure out what's causing the error with 5.16 and this would be good to go. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik, filipf Cc: filipf, davidre, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
