D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

arojas added a comment. Just a FYI, Arch is going switch away from mkinitcpio https://lists.archlinux.org/pipermail/arch-dev-public/2019-May/029570.html (Not saying this wouldn't be useful for the time being) REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D2148

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

lavender added a comment. In D21489#471864 , @ngraham wrote: > Instead of just using it when it's there, it would probably make more sense to add a CMake variable that allows the distro to choose which code path to use. See for example https://

D21494: Close KSplash when the desktops are visible

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If the desktops are already visible, there's no much need to hold on the KSplash. Panels should be ellegan

D21408: RFC: [Notifications] Better notification number alignment

lavender added a comment. In D21408#470219 , @broulik wrote: > In D21408#470122 , @ngraham wrote: > > > When there are 2 or digits, maybe the circle can expand to become pill-shaped > > > The

D21408: RFC: [Notifications] Better notification number alignment

ndavis added a comment. Eh, changing the background to solid didn't help (I did include the changes from this patch) and it looks somewhat out of place next to the other icons. F6859137: Screenshot_20190529_194111.png REPOSITORY R120 Plasma Workspace

D21493: Port away from foreach()

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The macro is on its way to getting deprecated, so we better start adopting the suggested alternative just

D21408: RFC: [Notifications] Better notification number alignment

ndavis added a comment. In D21408#471892 , @ngraham wrote: > Could we increase the size of the circle in the Plasma theme to make any slight mis-alignment less noticeable? It might look out of place next to all the other icons which are a

D21492: Remove double look-ups

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN plasmashell still works fine REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabr

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

ngraham added a comment. Excellent! REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D21489 To: xnick, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

ngraham added a comment. Could we increase the size of the circle in the Plasma theme to make any slight mis-alignment less noticeable? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: cfeck, davidedmundson, ngraham, ndav

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

xnick added a comment. Sounds good. I'll take a look on how to adapt it tomorrow. Thanks! REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D21489 To: xnick, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

ngraham added a comment. Instead of just using it when it's there, it would probably make more sense to add a CMake variable that allows the distro to choose which code path to use. See for example https://cgit.kde.org/kdenetwork-filesharing.git/tree/CMakeLists.txt#n50 REPOSITORY R258 Ply

D16425: Added new Suspend then Hibernate option

abalaji added inline comments. INLINE COMMENTS > suspendsession.cpp:137 > Q_EMIT aboutToSuspend(); > -suspendJob = > backend()->suspend(PowerDevil::BackendInterface::ToRam); > +if (m_suspendThenHibernateEnabled) { > +suspendJob = > backend()-

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

xnick created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. xnick requested review of this revision. REVISION SUMMARY Arch uses the mkinitcpio script to create the init image. Plymouthhelper expects update-initramfs. Added a case to check if mkinitcpio

D21408: RFC: [Notifications] Better notification number alignment

broulik added a comment. Also, the circle comes from the Plasma theme. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21408 To: broulik, #plasma, #vdg Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himces

D21484: i18n: Use proper plurals in notification texts

This revision was automatically updated to reflect the committed changes. Closed by commit R134:6ad8b646b025: i18n: Use proper plurals in notification texts (authored by aspotashev). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21484?vs=58856

D21484: i18n: Use proper plurals in notification texts

aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R134 Discover Software Store BRANCH i18n-plurals REVISION DETAIL https://phabricator.kde.org/D21484

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:943140d368f5: Allow 'Exclude folders' section in Baloo KCM to fill window (authored by kishoreg, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21414?vs=58849&id=58855#to

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks so much. I'll land this on the 5.16 branch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21414 To: kishoreg, #baloo, #vdg, ngraham Cc: GB_2, abe

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58849. kishoreg edited the test plan for this revision. kishoreg added a comment. Removed colon to keep string unchanged. Screenshot: F6858284: Screenshot_20190529_201418.png REPOSITORY R119 Plasma Desktop C

D21482: [Notifications] Delay configuring events

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aed7f5979ec7: [Notifications] Delay configuring events (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21482?vs=58843&id=58847 REVISIO

D21471: [Notifications] Remove space between pause/stop and details button

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21471 To: broulik, #plasma, #vdg, hein, filipf Cc: abetts, felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterber

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. If the initial size is fine, that's good enough. We don't need to prevent people from resizing the window to be really small. If you remove the colon from the string (see earlier discussion), I think this could land in 5.16! REPOSITORY R119 Plasma Desktop REV

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg added a comment. In D21414#471615 , @ngraham wrote: > With no items in the list view, the size looks perfect to me: > > F6858199: Screenshot_20190529_080727.png > > Are you seeing something

D21482: [Notifications] Delay configuring events

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In `Component.onCompleted` we might not have a window yet which we need to make the events config

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. With no items in the list view, the size looks perfect to me: F6858199: Screenshot_20190529_080727.png Are you seeing something different? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/

D21479: Don't show explicit "Update" button

broulik added a comment. Perhaps. But there's also a tray icon that appears simultaneously which people are trained to click. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21479 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2,

D21479: Don't show explicit "Update" button

ngraham added a comment. Hmm, I don't think this would be an upgrade. Without a button there I don't think it's obvious that clicking on the pop-up will allow you to go perform updates. Sometimes it's best to be explicit. REPOSITORY R134 Discover Software Store REVISION DETAIL https://p

D21479: Don't show explicit "Update" button

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The entire notification popup is clickable already. It's a bit awkward since the cursor turns

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58838. kishoreg edited the test plan for this revision. kishoreg added a comment. Moved buttons to the left. F6858110: Screenshot_20190529_180905.png I'll try to figure out how to set the size hint properly. RE

D21471: [Notifications] Remove space between pause/stop and details button

This revision was automatically updated to reflect the committed changes. Closed by commit R120:745c60a7766c: [Notifications] Remove space between pause/stop and details button (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2147

D21474: [Notifications] Spawn new notification if one to replace doesn't exist

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17f1834e98ae: [Notifications] Spawn new notification if one to replace doesn't exist (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D21475: [Notifications] Check proper group for show popups in dnd mode setting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a24166f72fbd: [Notifications] Check proper group for show popups in dnd mode setting (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D21473: [Notifications] Don't replace last one if next one is identical

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5c83d292a2a0: [Notifications] Don't replace last one if next one is identical (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21473?v

D21471: [Notifications] Remove space between pause/stop and details button

felixernst added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21471 To: broulik, #plasma, #vdg, hein, filipf Cc: felixernst, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, a

D21471: [Notifications] Remove space between pause/stop and details button

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Obviously looks better to me since there is alignment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21471 To: broulik, #plasma, #vdg, hein, filipf Cc:

D21476: [Downloads Plugin] Update existing job when being signalled creation of existing job

This revision was automatically updated to reflect the committed changes. Closed by commit R856:3fce38176a0b: [Downloads Plugin] Update existing job when being signalled creation of… (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricat

D9037: use desktop file actions instead of global shortcuts

broulik updated this revision to Diff 58829. broulik added a comment. - Remove accidental file rename REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9037?vs=58828&id=58829 REVISION DETAIL https://phabricator.kde.org/D9037 AFFECTED FILES conta

D9037: use desktop file actions instead of global shortcuts

broulik updated this revision to Diff 58828. broulik edited the test plan for this revision. broulik added a comment. - Write migration script that uses kglobalaccel at runtime - Adjust desktop context menu to read the new shortcut - Remove activation timer as here the window gets focus mos

D21476: [Downloads Plugin] Update existing job when being signalled creation of existing job

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is in preparation for allowing for Firefox to suspend download jobs which makes a susp

D21475: [Notifications] Check proper group for show popups in dnd mode setting

broulik created this revision. broulik added reviewers: Plasma, bugseforuns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It checked the wrong one resulting in the setting not being written. BUG: 407534

D21474: [Notifications] Spawn new notification if one to replace doesn't exist

broulik created this revision. broulik added reviewers: Plasma, bugseforuns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since the Notification Server knows nothing about what notifications were sent, it te

D21473: [Notifications] Don't replace last one if next one is identical

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since there is timeout for when it is considered a separate notification and we don't even close

D21471: [Notifications] Remove space between pause/stop and details button

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was meant to provide some separation but since the arrow icon has so much padding