D21362: Fixes for fonts kcm

ngraham accepted this revision. ngraham added a comment. Perfect. REPOSITORY R119 Plasma Desktop BRANCH bshah/fixup-fonts REVISION DETAIL https://phabricator.kde.org/D21362 To: bshah, #plasma, mart, ngraham Cc: ngraham, mart, progwolff, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D21360: [Notifications] Remove action mnemonics from tooltip

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh right, gotcha. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21360 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen

D21360: [Notifications] Remove action mnemonics from tooltip

broulik added a comment. The button text handles mnemonics but the/a tooltip doesn't and never did REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21360 To: broulik, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesli

D21360: [Notifications] Remove action mnemonics from tooltip

ngraham added a comment. Seems like something that the button should do automatically for us? Or is it not doing that because it would be throwing away all ampersands? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21360 To: broulik, #plasma Cc: ngraham, p

D21361: [Notifications] Remove "Notifications" heading

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, shipit! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21361 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen

D21362: Fixes for fonts kcm

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > fonts.h:54 > +{ > +bool exclude; > +int excludeFrom; even if not 100% needed, could those be initialized before config load? REPOSITORY R119 Plasma D

D21366: [Notifications] Unwatch job when it gets stopped

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We watch the service owner so that when it dies without finishing the job we communicate an error

D21335: Don't write a anti-aliasing settings from startkde

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Sweet, this will be a great change. REPOSITORY R120 Plasma Workspace BRANCH bshah/no-write-kdeglobals REVISION DETAIL https://phabricator.kde.org/D21335 To: bshah, #plasma, ngraha

D21335: Don't write a anti-aliasing settings from startkde

bshah updated this revision to Diff 58544. bshah added a comment. remove from startplasmacompositor as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21335?vs=58462&id=58544 BRANCH bshah/no-write-kdeglobals REVISION DETAIL https://phabri

D21335: Don't write a anti-aliasing settings from startkde

bshah added a comment. In D21335#469040 , @apol wrote: > Probably needs removing from startplasmacompositor too then. Good call, thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21335 To: bshah,

D21365: [Notifications] Avoid stale screenRect

broulik added a comment. Not really. I previously had the property there because I was too lazy to add a `Connections` since `QObject` has no default property and requires this `property...` boilerplate. The code is valid either way, however, this one actually mostly works with Frameworks 5.

D21365: [Notifications] Avoid stale screenRect

apol added a comment. Seems like a workaround... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21365 To: broulik, #plasma, mart, lbeltrame, dvratil Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreu

D21335: Don't write a anti-aliasing settings from startkde

apol added a comment. Probably needs removing from startplasmacompositor too then. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21335 To: bshah, #plasma Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-m

D21365: [Notifications] Avoid stale screenRect

broulik created this revision. broulik added reviewers: Plasma, mart, lbeltrame, dvratil. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `AppletInterface` does not emit change signals for screen properties, onl

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.12 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 May 2019 11:46:10 + Build duration: 5 min 20 sec and counting JUnit Tests Name: (r

KDE CI: Plasma » xdg-desktop-portal-kde » stable-kf5-qt5 SUSEQt5.12 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/stable-kf5-qt5%20SUSEQt5.12/23/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 May 2019 11:45:40 + Build duration: 3 min 18 sec and counting JUnit Tests

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 23 May 2019 11:46:10 + Build duration: 2 min 56 sec and counting

KDE CI: Plasma » xdg-desktop-portal-kde » stable-kf5-qt5 FreeBSDQt5.12 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/stable-kf5-qt5%20FreeBSDQt5.12/23/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 23 May 2019 11:45:40 + Build duration: 1 min 25 sec and counting

D21357: User Switcher Plasma applet: Option to not lock screen on switch user session action

Murz added a comment. Thanks for pointing this, I wasn't think before, that those options are linked! Will be good to add text description for users in widget settings window, pointing to this. If you approve this, I can make new diff. REVISION DETAIL https://phabricator.kde.org/D21357 To

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.12 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 May 2019 09:44:45 + Build duration: 3 min 0 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 23 May 2019 09:44:45 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » xdg-desktop-portal-kde » stable-kf5-qt5 FreeBSDQt5.12 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/stable-kf5-qt5%20FreeBSDQt5.12/22/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 23 May 2019 09:41:15 + Build duration: 1 min 9 sec and counting CONSOLE

KDE CI: Plasma » xdg-desktop-portal-kde » stable-kf5-qt5 SUSEQt5.12 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/stable-kf5-qt5%20SUSEQt5.12/22/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 May 2019 09:41:15 + Build duration: 48 sec and counting CONSOLE OUTPUT

D21335: Don't write a anti-aliasing settings from startkde

bshah added a comment. D21362 is follow-up review to this one.. all 4 patches needs to go together. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21335 To: bshah, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragr

D21362: Fixes for fonts kcm

bshah created this revision. bshah added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This includes 3 different patches, - Parse global config files. Remove 'Vendor default' option. Fix

Re: Proposal: passing user idle time to systemd-logind

Relevant bit from wiki "Whenever the session gets idle the DE should invoke the SetIdleHint(True) call on the respective session object on the session bus. This is necessary for the system to implement auto-suspend when all sessions are idle. If the session gets used again it should call SetIdleHi

D20375: if no xcursor is found, don't build the kcm at all

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0d433faf4c5f: if no xcursor is found, don't build the kcm at all (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20375?vs=55731&id=58537

D21361: [Notifications] Remove "Notifications" heading

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is redundant with the title added by system tray. Even when added standalone it is kind of

D21360: [Notifications] Remove action mnemonics from tooltip

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise shows up as ampersand. BUG: 407853 FIXED-IN: 5.16.0 TEST PLAN Code inspired by

D21326: Make limtedrowcountproxymodel usable from QML

broulik added a comment. Before moving to frameworks also needs d-pointer INLINE COMMENTS > limitedrowcountproxymodel_p.h:47 > + * > + * The default value is 0 > + */ Should we use `-1` as the default instead and have 0 actually mean limit of zero items = empty? > limitedrowcou

D21357: User Switcher Plasma applet: Option to not lock screen on switch user session action

broulik added a comment. It is currently controlled by the "automatically lock screen" option (the `shouldLock` property) in screen locker settings. I would prefer to have a dedicated setting there which affects every user switching place (e.g. via kickoff and what not) rather than having a