broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We watch the service owner so that when it dies without finishing the job we 
communicate an error to the user.
  When the job is stopped, the job is "done" and we don't need to watch the 
service anymore.

TEST PLAN
  - Started a copy, finished it, quit Dolphin: no longer got a "job 
unregistered" message
  - Started a copy, killed Dolphin: got a "application closed unexpectedly" job 
error
  - Started a copy, finished it, started a second copy, killed Dolphin, still 
got the error message

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21366

AFFECTED FILES
  libnotificationmanager/jobsmodel_p.cpp
  libnotificationmanager/jobsmodel_p.h

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to