D16425: Added new Suspend then Hibernate option

avaldes added a comment. This is how it looks now @ngraham : F6822188: suspendThenHibernate.png REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham Cc: meven, soriano, abalaji, graesslin,

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58044. avaldes added a comment. Improved messages for suspend session REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16425?vs=56024&id=58044 BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Hi David! Hmm, it seems the behavior is already different. I don't use sddm, but I tried it just now and found that the input field is already *not* disabled, plus, the notification that the login failed comes after the timeout. Looking at the qml code, t

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

ngraham added a comment. Oh, duh, right. Yes, please change the login screen version too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. In D20186#464906 , @romangg wrote: > For the next release some pointers where still work could be done: > > - Touchpads do never feature acceleration profiles I believe. That's true for the moment, but this is

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I tested it now. I think it's working robustly and should still go in the upcoming release. We have the beta phase to further test then. For the next release some pointers where still

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

davidedmundson added a comment. I don't want SDDM and the lockscreen to have subtly different behaviours. If one is changing, the other should too. See similar files in sddm-theme REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddhartha

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. This one was easy enough. I definitely liked the fact that I could edit the qml files directly and test it live without going through a compilation step. I especially enjoyed it after I managed to crash the lock screen with a typo but was able to fix the stuck

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

ngraham added a comment. Yeah, isn't QML just so nice to work with!? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Cool! Thank you for the pointers to the correct place. It was much easier than I thought once I looked at the code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: plasma-d

D16425: Added new Suspend then Hibernate option

ngraham added a comment. In D16425#464725 , @avaldes wrote: > In D16425#464381 , @ngraham wrote: > > > This thing's UI really needs to be rewritten in QML. Once we do that and give it a proper FormL

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah I see what you mean. It does look like the text field needs to become defocused for a brief moment to work around that bug. And it re-focused itself quickly while the button is still d

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. That's correct. 2 points however: - I think the detection of a wrong password is very fast and at least on my system I immediately get the highlighted focus. When you say muted, is it slow to do this for you? - We probably can't do the immediate focus be

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

ngraham added a comment. Thanks! In testing this out, I find that the impact is quite muted since the text field de-focuses itself after you press the return key. So in practice, if you realize that you typed the wrong password, you can't actually start typing immediately because the text fi

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu updated this revision to Diff 58025. siddharthasahu added a comment. Update diff to master. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21192?vs=58019&id=58025 REVISION DETAIL https://phabricator.kde.org/D21192 AFFECTED FILES

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

ngraham added a comment. I'm afraid your patch does not apply for me: $ arc patch D21192 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D21192. Checking patch lookandfeel/contents/lockscreen/MainBlock.qml... error:

D21194: [Holidays plugin] Port partially to QQC2

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port mostly to QQC2 (Don't touch the TableView since there's no QQC2 version yet) - Use s

D21193: [Astronomical Calendar Plugin] Port to QQC2+Kirigami Formlayout

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Use standard import names - Adjust strings to f

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. siddharthasahu requested review of this revision. REVISION SUMMARY This is a patch to fix: https://bugs.kde.org/show_bug.cgi?id=407473 TEST PLAN I applied the diff on my system by di

D21191: [Media Frame] Port "Paths" category to QQC2+Kirigami and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2 - Use Kirigami `BasicListItem` for the paths view - Use standard import nam

D16425: Added new Suspend then Hibernate option

avaldes added a comment. In D16425#464381 , @ngraham wrote: > This thing's UI really needs to be rewritten in QML. Once we do that and give it a proper FormLayout style, the string can be shorter, but for now, seeing it in context, I feel like

D21128: Improve keyboard navigation

apol added inline comments. INLINE COMMENTS > mart wrote in delegaterecycler.cpp:373 > https://doc.qt.io/qt-5/qquickitem.html#Flag-enum > > you can set the focusscope flag on top of any qquickitem, FocusScope is just > an empty item that doesn't do anything that setting thjat flag in its ctor >

D21128: Improve keyboard navigation

apol updated this revision to Diff 58012. apol added a comment. Go for a more elegant approach: use Keys.forwardsTo and expose the item REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21128?vs=57870&id=58012 BRANCH arcpatch-D21128 REVISION DETAIL http

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/33/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 15:59:44 + Build duration: 31 sec and counting CONSOLE OUTPUT [...truncated 372

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R115:9c3d0f2dffc2: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricat

D21189: [System tray] Modernize "Entries" category

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Use standard import names Don't touch the Ta

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added a comment. Thanks! REPOSITORY R115 Plasma Audio Volume Applet BRANCH modernize-widget-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D21105 To: ngraham, #vdg, #plasma, drosca Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zr

D21188: Improve keyboard-only usage of the toolbar

apol created this revision. apol added reviewers: Kirigami, mart. apol added a project: Kirigami. apol requested review of this revision. REVISION SUMMARY Have PrivateActionToolButton trigger its action if the mnemonic is activated. BUG: 403711 TEST PLAN I can call the actions on the too

D20867: Add Property to disable drawing of menu arrow indicators

hallas added a comment. Hi @ngraham - any update on this one? Should we move forward with this approach or should we do something else? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hallas, ngraham Cc: mart, davidedmundson, plasma-devel, jraleigh, GB_2, r

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

abetts added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D21105 To: ngraham, #vdg, #plasma, drosca Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21105: Port widget settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added a comment. Ping. I'd like to get this in before the string freeze so it can be a part of Plasma 5.16 so we can complete T10586 in that release. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2110

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

ngraham added a comment. F6821636: Screenshot_20190513_081240.png This fixes the issue for me, but it feels like we should make the fix in plasma-framework to the button itself so everyone gets the benefit of the fix automatically, no? REPOSITORY

D21164: Replace QUrl::fromUserInput by lighter heuristic

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d38d7df3e170: Replace QUrl::fromUserInput by lighter heuristic (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21164?vs=57988&id=58004#toc REPOSITORY R120 Plasma Worksp

D21164: Replace QUrl::fromUserInput by lighter heuristic

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Oh right, it's the other way around. Well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21164 To: broulik, #plasma, apol Cc: apol, plasma-devel, jrale

D21186: extends keywords of device info module

This revision was automatically updated to reflect the committed changes. Closed by commit R102:0dda3bf3b438: extends keywords of device info module (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21186?vs=58002&id=58003 REVISION DETA

D21186: extends keywords of device info module

sitter added a comment. My PC has no batteries so I couldn't actually say. I agree that the energy info module is the better fit anyway. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D21186 To: sitter, broulik Cc: broulik, plasma-devel, jraleig

D21186: extends keywords of device info module

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Doesn't this thing also have batteries? But for that we have the energy info module I guess REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D21186: extends keywords of device info module

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY now includes more keywords of the available information TEST PLAN can search for disks REPOSITORY R102 KInfoCenter BRANCH mas

D21153: [Notifications KCM] Hack scroll bar not crashing

broulik abandoned this revision. broulik added a comment. Actual bug was addressed :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21153 To: broulik, #plasma Cc: ngraham, odeda, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D21184: Take the screen geometry into account when positioning popup notifications

lbeltrame accepted this revision. lbeltrame added a comment. It needs D21152 applied as well to work properly in my scenario. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21184 To: dvratil, broulik, d

D21184: Take the screen geometry into account when positioning popup notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1e175254dd8c: [Notifications] Take the screen geometry into account when positioning popup… (authored by dvratil). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D21152: [Notifications] Fix oversight of not taking into account screen X when placing notifications on the right side of the screen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b220dcbbdf8b: [Notifications] Fix oversight of not taking into account screen X when placing… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

D21184: Take the screen geometry into account when positioning popup notifications

broulik accepted this revision. broulik added a comment. Thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21184 To: dvratil, broulik, davidedmundson Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali

D21184: Take the screen geometry into account when positioning popup notifications

lbeltrame added a comment. Doesn't seem to work with screens that have a rotation. Setup: F6821443: Screenshot_20190513_134034.png Actual display of a notification: (note where it is, when it's set to "bottom right": F6821445: Scree

D21184: Take the screen geometry into account when positioning popup notifications

lbeltrame added a comment. I'll test and report if it works in my case, too. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21184 To: dvratil, broulik, davidedmundson Cc: lbeltrame, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, le

D21184: Take the screen geometry into account when positioning popup notifications

dvratil created this revision. dvratil added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The availableScreenRect is relative to the current screen, so if the notification applet is no

D21164: Replace QUrl::fromUserInput by lighter heuristic

broulik updated this revision to Diff 57988. broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21164?vs=57941&id=57988 REVISION DETAIL https://phabricator.kde.org/D21164 AFFECTED FILES libnotificationmana

Monday meeting notes for 13/5/2019

Kai Uwe: Work done: Notifications: - Merged notifications rewrite \o/ -- People love it except for some complaints about lack of padding or alignment which I don't agree with -- Blog post: https://blog.broulik.de/2019/05/next-generation-plasma-notifications/ -- Some minor fixes for issues fo

D21128: Improve keyboard navigation

mart added inline comments. INLINE COMMENTS > apol wrote in delegaterecycler.cpp:373 > DelegateRecycler can't be a FocusScope itself because QQuickFocusScope is > private API. > > We could put it in a FocusScope but then this opens a can of worms WRT sizes. https://doc.qt.io/qt-5/qquickitem.ht

D20930: Update WireGuard to match NetworkManager 1.16 interface

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Good work!! REPOSITORY R116 Plasma Network Management Applet BRANCH TwoTabs REVISION DETAIL https://phabricator.kde.org/D20930 To: andersonbruce, jgrulich, #vdg, ngraham Cc: ngr

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. See my last comment on the bug. Sorry. If you can explain why it's needed I'll happily click ship it. REPOSITORY R120 Plasma Workspace REVISION DETAIL htt

D21180: Check if service is still registered before showing progress

This revision was automatically updated to reflect the committed changes. Closed by commit R120:01333913374e: Check if service is still registered before showing progress (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21180?vs=5

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce added a comment. The changes to the key passwordfield menus was made to remove the AlwaysAsk option. This is the last change I am aware of necessary to release this. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20930 To: and

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce updated this revision to Diff 57983. andersonbruce added a comment. - Disable "AlwaysAsk" option in key password fields Caution: will not compile without changes to passwordfield.cpp and passwordfield.h made in the current master branch. REPOSITORY R116 Plasma Netwo

D21027: [Notes] Fix icons being almost invisible with light backgrounds

broulik added a comment. > I tried to set icon.width and icon.height but it doesn't do anything. In desktop style that should work since D20418 REPOSITORY R114 Plasma Addons BRANCH background-appropriate-icon-colors (branched from master) REVIS

D20930: Update WireGuard to match NetworkManager 1.16 interface

jgrulich added a comment. I think it doesn't matter in this case, you can just change it in your code, you don't need to have that change in your local copy, if this is merged than it's applied on top of that so it will be ok. REPOSITORY R116 Plasma Network Management Applet REVISION DETA

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

broulik updated this revision to Diff 57982. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21181?vs=57981&id=57982 REVISION DETAIL https://phabricator.kde.org/D21181 AFFECTED FILES applets/notifications/package/contents/ui/JobItem.qml To: broul

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

broulik created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21181 AFFECTED FILES applets/notifications/package/contents/ui/Jo

D21180: Check if service is still registered before showing progress

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Should Plasma be too busy to process a request and the app that requested it quit before Plasma p

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 13 May 2019 06:46:38 + Build duration: 23 min and counting CONSOLE OUTPUT [...truncated 374

D21114: [Microphone Indicator] Avoid duplicate application names

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2a3313b749e5: [Microphone Indicator] Avoid duplicate application names (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2111