D20242: Add flatpak mime types

eszlari created this revision. eszlari added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. eszlari requested review of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D20242 AFFECTED FILES disco

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel added a comment. In D8626#443079 , @ngraham wrote: > Probably because @dvogel doesn't have commit access and nobody ever landed the patch on his behalf. :( Feel free to do so now I guess, since @kbroulik has accepted it. Yes, kind

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

pino added a comment. In D19389#443139 , @davidedmundson wrote: > Sessionbackend.h is not installed. sessionmanagement.h (not sessionbackend.h) is indeed installed, according to your patch. Considering that D20237: Port to new KWorkspace

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4516ab53726c: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

davidedmundson added a comment. Sessionbackend.h is not installed. I should rename it _p.h maybe REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19389 To: davidedmundson, #plasma Cc: pino, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20237: Port to new KWorkspace API

apol added inline comments. INLINE COMMENTS > ItemGridDelegate.qml:33 > > +enabled: !(model.enabled === false) > + `enabled: model.enabled` no? > ItemListDelegate.qml:33 > > -enabled: !isSeparator > +enabled: !isSeparator && !(model.enabled === false) && (!isParent || > (isPare

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

pino added a comment. - loginddbustypes.h requires a license header - SessionBackend needs a d-pointer to minimize BIC changes - I'd move all the SessionBackend subclasses in a private header; they are not exported anyway, so unusable for users of this public library REPOSITORY R120 Pla

D20237: Port to new KWorkspace API

hein updated this revision to Diff 55381. hein added a comment. Fix up qDeleteAll usage, thanks David REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20237?vs=55372&id=55381 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20237 AFFEC

D20237: Port to new KWorkspace API

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > systemmodel.cpp:57 > { > -qDeleteAll(m_entryList); > -} > - > -void SystemModel::init() > -{ > -QList actions; > - > -actions << new SystemE

D8626: DDCUtil: Improved DDCUtil support for brightness control

ngraham added a comment. Probably because @dvogel doesn't have commit access and nobody ever landed the patch on his behalf. :( Feel free to do so now I guess, since @kbroulik has accepted it. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, brou

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#442088 , @knambiar wrote: > > Got to Know a lot about how X works with input handling. XD > > I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if yo

D20237: Port to new KWorkspace API

hein created this revision. hein added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Depends on D19389 . REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https:/

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

davidedmundson updated this revision to Diff 55363. davidedmundson added a comment. Wrap saveSession REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19389?vs=55319&id=55363 BRANCH origin-master (branched from master) REVISION DETAIL https://ph

D8626: DDCUtil: Improved DDCUtil support for brightness control

asturmlechner added a comment. Hm, any reason why this is still pending? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, broulik, davidedmundson Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

mart accepted this revision. mart added a comment. I think the patch is fine, the extra spacing is probably in the shell package plasma-desktop/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml you can take a look there and see where things are maybe gamm

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. Yes I checked, and they looked fine. However I'm considering reverting the patch anyway because I'm un-convincing myself that it was needed at all to properly support D19311 . REPOSITORY R31 Breeze REVISION DETAIL https:/

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hpereiradacosta added a comment. Did anyone check how this patch look with other icons than those in the screenshot ? E.g. the preview icon in dolphin, or list sorting or search icons ? Does the new arrow overlap with the said icons ? REPOSITORY R31 Breeze REVISION DETAIL https://pha

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/19/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Apr 2019 15:34:11 + Build duration: 9 min 10 sec and counting JUnit Tests Na

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 131 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/131/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 03 Apr 2019 15:29:16 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 2579

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 185 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/185/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 03 Apr 2019 15:29:15 + Build duration: 2 min 57 sec and counting JUnit Tests Name: pr

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

This revision was automatically updated to reflect the committed changes. Closed by commit R119:da0adfedcab0: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2014

D20223: Make disk monitor widget only show real devices by default

pavelmos added a comment. In D20223#442883 , @ngraham wrote: > I've edited the title and summary to be a bit more clear. Does that help and is it accurate? Yes that's right. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg, ngraham Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, al

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, all right, let's go with the separator. :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D20144 To: GB_2, #plasma, #vdg, ngra

D20223: Make disk monitor widget only show real devices by default

ngraham added a comment. I've edited the title and summary to be a bit more clear. Does that help and is it accurate? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20223 To: pavelmos, broulik, #plasma Cc: ngraham, davidedmundson, plasma-devel, jraleigh, G

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

filipf added a comment. In D20144#442451 , @GB_2 wrote: > In D20144#441802 , @ngraham wrote: > > > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.

D17796: Show accurate checked state for system monitor configuration pages

ngraham added a comment. We need a #plasma review first. Calling all Plasma devs! :) REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, rag

D20227: Remove player from known players list when it disappears

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a player item is removed and then added again later we would ignore it since we alread

D17796: Show accurate checked state for system monitor configuration pages

pavelmos added a comment. It seems to me that everything is fine. Are there any other comments or questions? REVISION DETAIL https://phabricator.kde.org/D17796 To: pavelmos, jriddell, #plasma, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

pavelmos added a comment. In D20223#442762 , @davidedmundson wrote: > Can you explain not what the change is doing, but why we're making it? > > What happens if I'm trying to monitor a removable USB disk? Thanks for your responce!

D20198: Don't lose list position after installing KNS cursor themes

leinir added a comment. In D20198#442785 , @apol wrote: > So fixing refreshList to not reset isn't feasible? Hmm... i'll have a look, it might be REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20198 To:

D20198: Don't lose list position after installing KNS cursor themes

apol added a comment. So fixing refreshList to not reset isn't feasible? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20198 To: leinir, #plasma, ngraham, broulik Cc: apol, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D20081: Add readme explaining how kwallet-pam works

This revision was automatically updated to reflect the committed changes. Closed by commit R107:b0ac7bbd6adf: Add readme explaining how kwallet-pam works (authored by davidedmundson). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20081?vs=5532

D20217: Remove kwallet4 support

This revision was automatically updated to reflect the committed changes. Closed by commit R107:905b00d38040: Remove kwallet4 support (authored by davidedmundson). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20217?vs=55317&id=55335 REVISION

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

davidedmundson added a comment. Can you explain not what the change is doing, but why we're making it? What happens if I'm trying to monitor a removable USB disk? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20223 To: pavelmos, broulik, #plasma Cc: d

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

pavelmos created this revision. pavelmos added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Made filtering the diskactivity widget settings upon first launch. Now, when the widget is f

D20205: initialize the kcolorscheme at the first app start

mart added a comment. In D20205#442466 , @davidedmundson wrote: > The analysis makes sense, I don't understand why this is the correct fix. > > Colours aren't the only thing lookandfeel syncs to kdeglobals when set. > Is it correct that a

D20222: Plasma-Workspace. The last checkbox in the widget settings

pavelmos created this revision. pavelmos added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Added a ban on disabling the last checkbox in the widget settings. There will always be at l

D20198: Don't lose list position after installing KNS cursor themes

leinir updated this revision to Diff 55330. leinir added a comment. Address comments by @ngraham and @apol REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20198?vs=55261&id=55330 REVISION DETAIL https://phabricator.kde.org/D20198 AFFECTED FILES

D20198: Don't lose list position after installing KNS cursor themes

leinir added a comment. In D20198#442364 , @ngraham wrote: > Why do we need this do-it-once helper function? To avoid having the lambda being called multiple times for subsequent installations, especially with incorrect parameters... It's