D12055: Remove border around menubars

2019-03-22 Thread Noah Davis
ndavis added a comment. In D12055#436424 , @filipf wrote: > In D12055#436412 , @ndavis wrote: > > > I don't see this border at all in the current version of Breeze GTK with Firefox. F6711302: Screens

D12055: Remove border around menubars

2019-03-22 Thread Vlad Zagorodniy
zzag updated this revision to Diff 54576. zzag added a comment. rebase REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12055?vs=35206&id=54576 BRANCH remove-border REVISION DETAIL https://phabricator.kde.org/D12055 AFFECTED FILES src/gtk318/wi

D12055: Remove border around menubars

2019-03-22 Thread Filip Fila
filipf added a comment. In D12055#436412 , @ndavis wrote: > I don't see this border at all in the current version of Breeze GTK with Firefox. F6711302: Screenshot_20190322_152144.png Try with a non-

D12055: Remove border around menubars

2019-03-22 Thread Andres Betts
abetts added a comment. +1 for visual improvement REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag, #breeze, ngraham, jackg, #vdg Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D12055: Remove border around menubars

2019-03-22 Thread Noah Davis
ndavis added a comment. I don't see this border at all in the current version of Breeze GTK with Firefox. F6711302: Screenshot_20190322_152144.png REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D1

D19959: Fixed issue causing changed signal to be called with false argument

2019-03-22 Thread Tigran Gabrielyan
tigrang added a comment. I do not have commit access. Can you commit for me, please? Full Name: Tigran Gabrielyan Email: tigran...@gmail.com REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19959 To: tigrang, mlaurent Cc: mlaurent, p

D12055: Remove border around menubars

2019-03-22 Thread Filip Fila
filipf added a comment. These borders are still pretty bad looking, I think we should go through with this. F6711163: image.png REPOSITORY R98 Breeze for Gtk BRANCH menubar-border REVISION DETAIL https://phabricator.kde.org/D12055 To: zzag,

D19694: [RFC] Reduce sidebar icon size/increase list information density

2019-03-22 Thread Filip Fila
filipf added a comment. > Ever since increasing the list item size to accommodate 32px icons, System Settings' sidebar has felt somehow wrong to me Same here, I prefer this patch rather than the bigger icons. Since we're still having issues with monochrome issues showing up, obviously th

D19752: [Splash KCM] Use InlineMessage for testing error

2019-03-22 Thread Andres Betts
abetts added a comment. Could the message include some hints of what failed? Maybe the theme name? Something like: "Failed to test Adwaita splash screen, please check theme" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19752 To: broulik, #plasma, #vdg

D19752: [Splash KCM] Use InlineMessage for testing error

2019-03-22 Thread Filip Fila
filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Visually I don't think there's anything to object to, and this is a useful message to have. The wording seems fine. Someone should also confirm that the code is sane. REPOSITORY R119 Pla

D19863: [Host] Add Message.sh

2019-03-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:832a18822cca: [Host] Add Message.sh (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19863?vs=54248&id=54571 REVISION DETAIL

D19946: systray: show a the context menu upon press an hold on the icon

2019-03-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:890e91b29bfe: systray: show a the context menu upon press an hold on the icon (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19946?vs=5

D19977: Prevent context drawer from disappearing

2019-03-22 Thread Dimitris Kardarakos
dkardarakos created this revision. dkardarakos added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Currently, on plasma mobile, if you navigate from a page that contains contextual act

D19959: Fixed issue causing changed signal to be called with false argument

2019-03-22 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Good catch. it's a bug in clazy. Thanks Do you have an commit access ? or do you want that I commit for you ? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D19976: [about-distro] OSRelease to collect "extra" keys

2019-03-22 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd ignore unknown keys. in preparation of moving to a library let's instead collect them

D19975: [about-distro] pimpl OSRelease privates

2019-03-22 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY in preparation of moving it into library - private members are now in private class - private cl

D19962: plasmoid: Make it possible to connect to a device using a touchscreen

2019-03-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R97:bc0b2e4a244c: plasmoid: Make it possible to connect to a device using a touchscreen (authored by apol). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19962?vs=5452

D19873: [image-wallpaper] Port to Kirigami.FormLayout and use twinFormLayouts

2019-03-22 Thread Filip Fila
filipf updated this revision to Diff 54554. filipf added a comment. make the "Folders" string translatable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54484&id=54554 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-03-22 Thread Filip Fila
filipf added a comment. In D18809#436246 , @victorr wrote: > File /wallpapers/image/imagepackage/contents/ui/config.qml > Word "Folders" without translation > > Kirigami.Heading { > text: "Folders" > level: 2 > }

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

2019-03-22 Thread Victor Ryzhykh
victorr added a comment. File /wallpapers/image/imagepackage/contents/ui/config.qml Word "Folders" without translation Kirigami.Heading { text: "Folders" level: 2 } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidr

D19784: Avoid calling QT_LSTAT and accessing recent documents

2019-03-22 Thread Robert Hoffmann
hoffmannrobert added a comment. In D19784#434564 , @hoffmannrobert wrote: > In D19784#431683 , @ngraham wrote: > > > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352.

D19971: Fix compilation error when SA_TRACE is 1

2019-03-22 Thread Vlad Zagorodniy
zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The error itself: /home/vlad/Workspace/KDE/src/kde/workspace/libksysguard/ksgrd/SensorAgent.cpp: In member function ‘void KSGRD::

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

2019-03-22 Thread Luca Carlon
luc4 added a comment. Hello. No, sorry, I don't think I have it. REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19931: Stylesheets seem to contain UTF-8 characters but US-ASCII is assumed while building. Setting the charset explicitly fixes the error.

2019-03-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Do you have commit access? REVISION DETAIL https://phabricator.kde.org/D19931 To: luc4, gepardo, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19909: Enable blurbehind for panels only if theme sets it

2019-03-22 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:8ef6104a2d02: Enable blurbehind for panels only if theme sets it (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19909?vs=54400&id=5

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

2019-03-22 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R119:34387d450ab2: [Desktop Theme KCM] "Normalize" margin around background in previews (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D197

[Breeze] [Bug 370569] kde4breeze.upd ignores system distributor values from XDG_CONFIG_DIRS/kdeglobals

2019-03-22 Thread Erik Quaeghebeur
https://bugs.kde.org/show_bug.cgi?id=370569 Erik Quaeghebeur changed: What|Removed |Added CC||k...@equaeghe.nospammail.net --- Comment #1