sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY previously we'd ignore unknown keys. in preparation of moving to a library let's instead collect them so a user of the class may also access them. - new extraKeys helper and extraValue getters - extras are always processed as String - test case fixture extended + now has comment variants (previously comments couldn't be tested since they were skipped as either comments or invalid/unknown lines. with the extras API we can actually verify that they do not incorrectly end up getting parsed TEST PLAN test still passes REPOSITORY R102 KInfoCenter BRANCH extras REVISION DETAIL https://phabricator.kde.org/D19976 AFFECTED FILES Modules/about-distro/autotests/OSReleaseTest.cpp Modules/about-distro/autotests/data/os-release Modules/about-distro/src/OSRelease.cpp Modules/about-distro/src/OSRelease.h To: sitter, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
