Re: welcome plasma-active-window-control

Nice! Last time I used it had many features and was very customizable even if it was unmaintained. On Sat, Mar 16, 2019 at 7:53 PM Jonathan Riddell wrote: > Just passed kdereview and moved into extra/base is Plasma Active Window > Control. > > Plasma Active Window Control is a plasma widget that

D19800: [Application Dashboard] Improve mouse handler

trmdi updated this revision to Diff 54052. trmdi added a comment. Improve the code. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19800?vs=53992&id=54052 BRANCH fix-390424 (branched from master) REVISION DETAIL https://phabricator.kde.org/D198

D19790: Improve the look of the GTK Application Style KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this is good to go now! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 To: GB_2, #plasma, #vdg, apol, ngraham C

D19469: [sddm-theme] Update login screen preview image

ngraham added a comment. I do believe that this is the very last patch for T10325: 5.16 Login screen improvements . :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: plasma-deve

D19712: Restore proper background color on list and sources pages

This revision was automatically updated to reflect the committed changes. Closed by commit R134:094c9d947e17: Restore proper background color on list and sources pages (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19712?

Re: welcome plasma-active-window-control

On Sat, Mar 16, 2019 at 6:53 PM Jonathan Riddell wrote: > > Just passed kdereview and moved into extra/base is Plasma Active Window > Control. > > Plasma Active Window Control is a plasma widget that you can embed in > your panel to control your active window with e.g. close or maximise > operati

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 54033. GB_2 added a comment. Fix groupbox widths REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54032&id=54033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FIL

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 54032. GB_2 added a comment. Improve and clean UI REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54026&id=54032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FI

D19647: [sddm-theme/lock screen] Use QQC2 for the clock labels

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d7654042677a: [sddm-theme/lock screen] Use QQC2 for the clock labels (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19647?vs=53572&id=

welcome plasma-active-window-control

Just passed kdereview and moved into extra/base is Plasma Active Window Control. Plasma Active Window Control is a plasma widget that you can embed in your panel to control your active window with e.g. close or maximise operations. Useful for decorationless window management. New maintainer is C

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 54026. GB_2 added a comment. Add back word GNOME and update GHNS button tooltip REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53994&id=54026 BRANCH master REVISION DETAIL https://phabricat

D19802: [comic] Modernize configuration windows

ngraham added a subscriber: mart. ngraham added a comment. In D19802#432171 , @filipf wrote: > Definitely some silly mistakes in there, thanks for showing me how to do it right! > > As for the looks, I'm struggling with liking the placement o

D19797: [fifteen-puzzle] Modernize settings window

rooty added a comment. I'm not sure - the sections are so small the headings make it sound redundant (Numbers, Show numbers, Number color), I'd add spaces instead. Size: 4 [checkbox] Show numbers Number color: Piece color: [checkbox] Use custom image for pieces --path--

D19802: [comic] Modernize configuration windows

filipf added a comment. Definitely some silly mistakes in there, thanks for showing me how to do it right! As for the looks, I'm struggling with liking the placement of the headings when Kirigami.FormData.label is used, hence the row layouts. Case in point: F6696611: Screenshot_2019

D19797: [fifteen-puzzle] Modernize settings window

filipf added a comment. In D19797#431918 , @ngraham wrote: > +1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me. > > This might be a case where

D19631: [sddm-theme/lock screen] Overhaul font sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d3aa8b07c168: [sddm-theme/lock screen] Overhaul font sizes (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54020&id=54024 REV

D19799: QNetworkReply was not deleted

broulik added inline comments. INLINE COMMENTS > apol wrote in FlatpakBackend.cpp:143 > This will crash here because it's passed into the connect, so it will be > deleted when the function leaves and accessed from the lambda. Just move the `QScopedPointer` into the lambda, which is what I was t

D19631: [sddm-theme/lock screen] Overhaul font sizes

ngraham accepted this revision. ngraham added a comment. I love it. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zr

D19799: QNetworkReply was not deleted

apol added a comment. How about connecting: `connect(reply, &QNetworkReply::finished, reply, &QObject::deleteLater);` after instantiating and be done with it? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19799 To: mlaurent, apol, #discover_softwar

D19799: QNetworkReply was not deleted

apol added inline comments. INLINE COMMENTS > FlatpakBackend.cpp:143 > auto replyGet = get(QNetworkRequest(m_url)); > - > +QScopedPointer > replyPtr(replyGet); > connect(replyGet, &QNetworkReply::finished, this, [this, replyGet] { This will crash here because it's pass

D19790: Improve the look of the GTK Application Style KCM UI

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm not a fan of changing the name to remove "GNOME" from it. GTK is a UI toolkit whose name is not familiar to many of our users; adding "GNOME" to it makes the purpose clearer

D19687: Allow single images to be excluded from the slideshow

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM now. Let's see what some of the #plasma people think. :) REPOSITORY R120 Plasma Workspace BRANCH toggleSlides REVISION DETAIL https:

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 54020. rooty added a comment. Remove extra character REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54019&id=54020 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D19631 AFFECTE

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 54019. rooty added a comment. Make it work for the lock screen too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54018&id=54019 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 54018. rooty added a comment. Implement changes in keyboard layout button REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54017&id=54018 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kd

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 54017. rooty added a comment. Add battery font size configuration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54012&id=54017 BRANCH arcpatch-D19631 REVISION DETAIL https://phabricator.kde.org/D1

D19799: QNetworkReply was not deleted

mlaurent updated this revision to Diff 54015. mlaurent added a comment. Use QScopedPointer REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=53998&id=54015 BRANCH delete_qnetwork_reply (branched from master) REVISION DETAIL https

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 54012. rooty marked an inline comment as done. rooty added a comment. Make property less restricted REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=54005&id=54012 BRANCH arcpatch-D19631 REVISION DETAI

D19800: [Application Dashboard] Improve mouse handler

trmdi added a comment. Ok, it will be fixed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19800 To: trmdi, hein, ngraham, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19687: Allow single images to be excluded from the slideshow

davidre added a comment. In D19687#431950 , @ngraham wrote: > UI looks good now. I've done some code review below: Thanks for the heads-up! I was orienting myself on the Code around. REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D19687: Allow single images to be excluded from the slideshow

davidre updated this revision to Diff 54010. davidre added a comment. - Use range-based for REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19687?vs=53870&id=54010 BRANCH toggleSlides REVISION DETAIL https://phabricator.kde.org/D19687 AFFECTE

D19801: [KSplashQML] Update stages comment and make code clearer

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f899ccdc0fa3: [KSplashQML] Update stages comment and make code clearer (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19801?vs=53997

D19753: [KSplashQML] Register DBus before loading the splash theme

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9a4bb220c162: [KSplashQML] Register DBus before loading the splash theme (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19753?vs=538

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

kossebau added a comment. In D19748#432027 , @broulik wrote: > Seems it does break things here (both with and without Qt scaling :/) Could you retry with cleaned Plasma cache? As discussed before, I saw this with openSUSE dark as well, bu

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

broulik added a comment. F6696238: Screenshot_20190316_121442.png Seems it does break things here (both with and without Qt scaling :/) REPOSITORY R119 Plasma Desktop BRANCH normalizeplasmathemepreviewmargins REVISION DETAIL https://phabricator

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty marked an inline comment as done. rooty added inline comments. INLINE COMMENTS > ngraham wrote in MediaControls.qml:126 > These changes will worsen the problem of the song/artist name getting cut off > when they're even marginally long. I would be in favor of fixing that (in > another pat

D19631: [sddm-theme/lock screen] Overhaul font sizes

rooty updated this revision to Diff 54005. rooty added a comment. Use track and artist style from D17073 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19631?vs=53632&id=54005 BRANCH arcpatch-D19631 REVISION

D19803: [Tabs Runner] Check DBus reply signature

broulik abandoned this revision. broulik added a comment. Probably not since it crashes in demarshalling the variant list to a qvarianthash, not the initial cast REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19803 To: broulik, #plasma, apol Cc:

D19803: [Tabs Runner] Check DBus reply signature

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Qt tends to crash when trying to `qdbus_cast` to a wrong type TEST PLAN Similar check was

Plasma distro-specific installation path?

Hello, one question please: Is there any way to know from Qt/KDE frameworks side in which global installation path Plasma was installed? e.g. in Tumbleweed that is "/usr/share/plasma" but other distros there is a chance that use something different regards, michail Latte Dev Team

D19748: [Desktop Theme KCM] "Normalize" margin around background in previews

ngraham added a comment. No objection! REPOSITORY R119 Plasma Desktop BRANCH normalizeplasmathemepreviewmargins REVISION DETAIL https://phabricator.kde.org/D19748 To: kossebau, #plasma, #vdg, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliez

D19802: [comic] Modernize configuration windows

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > configAdvanced.qml:55 > +Controls.Label { > +text: maxComicLimit.value !==1 ? i18nc("@item:valuesuffix > spacing to number + unit", " st

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54001. filipf added a comment. 1 strips per comic -> 1 strip per comic REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54000&id=54001 BRANCH modernized-comic-settings (branched from master) REVISION DET

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54000. filipf edited the summary of this revision. filipf edited the test plan for this revision. filipf added a comment. when value for minutes is 1 use "min" instead of "mins", when value for days is 1 use "day" instead of "days" REPOSITORY R114 Pla

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:59 > Then do it so I can accept the patch I already did it. > apol wrote in gtkconfigkcmodule.cpp:65 > That's fine, but you can do it in a separate patch. I'm already updating the strings here. I always did this

D19802: [comic] Modernize configuration windows

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH modernized-comic-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D19802 AFFECTE

D19631: [sddm-theme/lock screen] Overhaul font sizes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, I think this is sane enough now. :) INLINE COMMENTS > MediaControls.qml:126 > Layout.fillWidth: true > -level: 5 > +level: 4 >

D19687: Allow single images to be excluded from the slideshow

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks good now. I've done some code review below: INLINE COMMENTS > image.cpp:623 > m_slideshowBackgrounds = paths; > +Q_FOREACH(const QString &slide, m_uncheckedSlides) { > +m_slideshowBackgrounds.removeAll(

D19799: QNetworkReply was not deleted

broulik added inline comments. INLINE COMMENTS > OdrsReviewsBackend.cpp:186 > m_isFetching = false; > + reply->deleteLater(); > return; Can't you call this at the beginng of the method? Or let it be owned by a `QScopedPointer replyPtr(sender());` instead of calling `delet

D19799: QNetworkReply was not deleted

mlaurent updated this revision to Diff 53998. mlaurent added a comment. Fix indent REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19799?vs=53990&id=53998 BRANCH delete_qnetwork_reply (branched from master) REVISION DETAIL https://phabr

D19790: Improve the look of the GTK Application Style KCM UI

apol added inline comments. INLINE COMMENTS > GB_2 wrote in kde-gtk-config.desktop:59 > Will remove those, just copied it from the Application Style KCM. Then do it so I can accept the patch > GB_2 wrote in gtkconfigkcmodule.cpp:65 > This is making it consistent with other KCMs. That's fine, b

D19799: QNetworkReply was not deleted

apol added inline comments. INLINE COMMENTS > OdrsReviewsBackend.cpp:186 > m_isFetching = false; > + reply->deleteLater(); > return; indentation > FlatpakBackend.cpp:149 > Q_EMIT jobFinished(false, nullptr); > + replyGet->deleteLater(); >

D19801: [KSplashQML] Update stages comment and make code clearer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's an `kcminit` stage that wasn't documented. Also change `m_stage` and then check it so th

D19800: [Application Dashboard] Improve mouse handler

ngraham added a comment. In D19800#431915 , @trmdi wrote: > In D19800#431914 , @ngraham wrote: > > > While I can't get the bug to happen as often with this, I still can sometimes--especially when I

D19797: [fifteen-clock] Modernize settings window

ngraham added a comment. +1 for porting to Kirigami.Formlayout, but I'm not sure that the new layout is an improvement. Something about it just doesn't feel quite right to me. This might be a case where we could benefit from using actual headers ("Numbers" and "Pieces"), maybe? REPOSITO

D19800: [Application Dashboard] Improve mouse handler

trmdi added a comment. In D19800#431914 , @ngraham wrote: > While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column. > > This might need @hein's magic touch.

D19800: [Application Dashboard] Improve mouse handler

ngraham added a comment. While I can't get the bug to happen as often with this, I still can sometimes--especially when I drag the top-left-most item down one column. This might need @hein's magic touch. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 53994. GB_2 added a comment. Clean desktop file REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53967&id=53994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FILE

D19800: [Application Dashboard] Improve mouse handler

trmdi created this revision. trmdi added reviewers: hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Clear pressedItem when dragging items - Correct the "view" attached property to "GridView.view

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:1 > All this not saying they're right or wrong but unrelated to the change at > stake. I'll remove the things that weren't here before, but this is just sorting the desktop entry to make it consistent with other

D19799: QNetworkReply was not deleted

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY delete networkreply REPOSITORY R134 Discover Software Store BRANCH delete_qnetwork_reply (branched from master) REVISION DE