broulik added inline comments.

INLINE COMMENTS

> OdrsReviewsBackend.cpp:186
>          m_isFetching = false;
> +     reply->deleteLater();
>          return;

Can't you call this at the beginng of the method? Or let it be owned by a 
`QScopedPointer<QNetworkReply, QScopedPointerDeleteLater> replyPtr(sender());` 
instead of calling `deleteLater()` explicitly before each return

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19799

To: mlaurent, apol, #discover_software_store
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to