D15304: [KCM] Port to QQC2

drosca accepted this revision. drosca added a comment. Looks good now! REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham, #plasma, drosca Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel, jralei

D18976: Improve Contextmenu

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:85 > +m_configureAction->setVisible(!configuring); > +}); > + this bracket ident needs to be like the one from m_addWidgetsAction > menu.cpp:138 > > +m_configureAction->setText(i18nc("view settings window

D18896: [plasma-nm] Refresh wifi networks as fast as possible

jgrulich added inline comments. INLINE COMMENTS > main.qml:78 > +function wifiScan() { > +handler.requestScan() > } Since this is just one line function, you can use handler.requestScan() directly as before. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18867: Remove redundant DNS field

This revision was automatically updated to reflect the committed changes. Closed by commit R116:29b6d0ee5900: Remove redundant DNS field (authored by andersonbruce, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D18939: KMenuEdit: add search/filter bar

mlaurent added inline comments. INLINE COMMENTS > kmenuedit.cpp:137 > +m_searchLine = new KTreeWidgetSearchLine(this, m_tree); > +m_searchLine->setCaseSensitivity(Qt::CaseSensitivity::CaseInsensitive); > +m_searchLine->setKeepParentsVisible(true); you can use directly Qt::CaseInsensi

D18939: KMenuEdit: add search/filter bar

tuxxi added a comment. Yes, that's exactly what I'm doing. QFrame works fine for doing the same thing with the added benefit of easier styling around the edges. But if you *really want* I can switch it to a blank QWidget... it makes absolutely no difference though. REPOSITORY R103 KMenu E

D18939: KMenuEdit: add search/filter bar

ngraham added a comment. If the reason why you're creating a `QFrame` is because `QSplitter` doesn't accept a layout, you can just give it a blank `QWidget` and assign the widget your layout. See https://stackoverflow.com/a/53384177/2934226 REPOSITORY R103 KMenu Editor REVISION DETAIL h

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51565. tuxxi added a comment. - Fix padding issues REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51562&id=51565 BRANCH search-bar REVISION DETAIL https://phabricator.kde.org/D18939 AFFECTED FILES k

D18939: KMenuEdit: add search/filter bar

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Actually looking one more time I see a visual issue introduced by this patch: by putting the search field and list inside a frame, they both have bigger margins than the tabbed

D18939: KMenuEdit: add search/filter bar

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent. UX and code look good to me now. @cfeck, or #plasma folks, any comments or shall we land this? BTW @tuxxi you'll need to fix your

D18976: Improve Contextmenu

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Display Dock Settings/Panel Settings instead of View Settings - Hide View Settings when configur

D18939: KMenuEdit: add search/filter bar

tuxxi added inline comments. INLINE COMMENTS > ngraham wrote in kmenuedit.cpp:143 > If there's nothing specifically in the style guidelines about it, it's best > to follow the existing coding style. Nothing else here uses `auto` with `new` > constructors, so we should follow the same style for

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51562. tuxxi marked 8 inline comments as done. tuxxi added a comment. - resolve (hopefully) final nitpicks REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51561&id=51562 BRANCH search-bar REVISION DETAIL

D18939: KMenuEdit: add search/filter bar

ngraham added inline comments. INLINE COMMENTS > tuxxi wrote in kmenuedit.cpp:30 > IMHO it looks cleaner to separate includes into categories, which is what I > did here. It surely is, but that's not related to this patch. In KDE, we try to make our commits as atomic as possible, and do clean-

D18939: KMenuEdit: add search/filter bar

tuxxi added inline comments. INLINE COMMENTS > ngraham wrote in kmenuedit.cpp:30 > Unrelated change. IMHO it looks cleaner to separate includes into categories, which is what I did here. > ngraham wrote in kmenuedit.cpp:141 > Since the placeholder text says "Search..." we should probably not u

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51561. tuxxi marked 5 inline comments as done. tuxxi added a comment. Fix various nitpicks REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51545&id=51561 BRANCH search-bar REVISION DETAIL https://phabri

D18975: [PotD] Port mostly to QQC2

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Port the Config UI mostly to QQC2, with the exception of the ComboBox,

D15304: [KCM] Port to QQC2

ngraham marked 2 inline comments as done. ngraham added a comment. OK, I think this is finally ready to land. No more hacks. @drosca and/or @davidedmundson, could you confirm? REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL https://phabricator.kde.org

D15304: [KCM] Port to QQC2

ngraham updated this revision to Diff 51557. ngraham added a comment. Remove more hacks and now-unnecessary changes REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=51556&id=51557 BRANCH arcpatch-D15304 REVISION DETAIL https:

D15304: [KCM] Port to QQC2

ngraham updated this revision to Diff 51556. ngraham added a comment. Remove all the hacks and do this right, once and for all REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=50385&id=51556 BRANCH arcpatch-D15304 REVISION DETA

D18939: KMenuEdit: add search/filter bar

ngraham added a comment. Thanks! The UI and behavior are now good. Code looks pretty sane too, just a few style nitpicks: INLINE COMMENTS > kmenuedit.cpp:30 > #include > + > #include Unrelated change. > kmenuedit.cpp:141 > +m_searchLine->setPlaceholderText(i18n("Search...")); > +

D16658: Respect the display property of buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R858:974efd584666: Respect the display property of buttons (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=48

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51545. tuxxi marked an inline comment as done. tuxxi added a comment. - search -> search... REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51540&id=51545 BRANCH search-bar REVISION DETAIL https://phabr

D18964: UpdatesPage: Fix icon sizing on small screens

This revision was automatically updated to reflect the committed changes. Closed by commit R134:502b963bcc96: UpdatesPage: Fix icon sizing on small screens (authored by jbbgameich, committed by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kd

D18964: UpdatesPage: Fix icon sizing on small screens

ngraham added a comment. Sure, I'll do it this time. The documentation for using `arc` is really quite good though: https://community.kde.org/Infrastructure/Phabricator REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_s

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich added a comment. I'm sorry, I'm not yet used to the Phabricator workflow. My attempt to convert this revision into a proper arc diff I can land failed, since this was initially created by pasting `git diff` output. If possible, can you land the patch? REPOSITORY R134 Discover S

D18971: UpdatesPage: Fix icon sizing on small screens

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY On Small screens (e.g phones), not all list items have the same height, for example when a package has a long version string.

D18939: KMenuEdit: add search/filter bar

ngraham added a comment. Thanks. :) You can also click on the "Resolved" checkboxes for inline comments and then click the Submit button on the bottom of the page once those issues are taken care of. INLINE COMMENTS > kmenuedit.cpp:140 > +m_searchLine->setKeepParentsVisible(true);

D18939: KMenuEdit: add search/filter bar

tuxxi updated this revision to Diff 51540. tuxxi added a comment. - Removed `.gitignore` changes - Switch label to placeholder text CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=51468&id=51540 REVISION DETAIL https://phabricator.kde.org/D18939 AFFECTED FILES kmenued

D18970: update gitignore

tuxxi abandoned this revision. tuxxi added a comment. whoops REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18970 To: tuxxi Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18970: update gitignore

tuxxi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tuxxi requested review of this revision. REVISION SUMMARY add basic filtering added label fix category expansion when searching simplify expansion code use QTreeView methods

D18903: Make Appearance KCMs' labels consistent

ngraham added a comment. Putting the KCM name in the header would make semantic sense, though then we would have triple name duplication: in the header, in the sidebar, and in the titlebar. Maybe that's not so bad as long as they all display the same text though. REPOSITORY R119 Plasma De

D18939: KMenuEdit: add search/filter bar

ngraham added a comment. I suggest not adding them to the patch. :) Since they've already been added to this patch, you can do `git checkout .gitignore` to recover the original version of that file, and then `arc diff` to update the patch. But if your IDE adds the file again automaticall

D18939: KMenuEdit: add search/filter bar

tuxxi added a comment. Hi ngraham: OK, can do on the label / placeholder. RE: `.gitignore`, those files are generated by my IDE (CLion). What do you suggest I do? REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ngraham, plasma-devel, jralei

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

filipf added a comment. In D18934#410952 , @ngraham wrote: > Let me know if that appeals to you. You bet it does, it's looks much better. Unfortunately from what I'm seeing "window-close" is picked up from the desktop\Plasma theme while

D18918: Make the text of "View Settings" action more specific

mvourlakos added a comment. @trmdi please do me a favour: 1. close this review and open a clean new one because for some reason when trying to test it in my system includes also one old commit that I added the ViewType option 2. no problem with & characters you can add them 3. no pro

D18964: UpdatesPage: Fix icon sizing on small screens

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Got some updates and confirmed that this fixes the bug. Code looks sane. Please land on the `Plasma/5.15` branch and then merge to master. REPOSITORY R134 Discover Software Store REVIS

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

ngraham added a comment. Or alternatively we should make the existing ToolButton `flat` all the time and then it will have the advantage of behaving like all other ToolButtons that people are already familiar with. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

ngraham added a comment. I don't like this approach because the IconItem has no pressed state. This is already a problem for the Task Manager tooltips, and I'd like to not replicate it here too. Also I don't really like the fact that the close button is red here even before it's hovered; dis

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren added a comment. In D18961#410792 , @kossebau wrote: > > we no longer have to install the widget to .../share/plasma/plasmoids/ > > No experience here, but do we not still need to install the QML extension plugins to have the applet work

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich added a comment. Thanks, done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D18964: UpdatesPage: Fix icon sizing on small screens

ngraham added a comment. Yep, see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_software_store Cc: ngraham, plasma-devel, jraleigh, GB_2, rag

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich added a comment. Yes, this looks like the same problem. Since the UpdatesPage width is being decreased when opening the "More information", it's the same effect as on a phone screen where the width is always that small. Can / should I somehow tag this patch so it marks the bug as

D18939: KMenuEdit: add search/filter bar

ngraham added inline comments. INLINE COMMENTS > kmenuedit.cpp:143 > +auto searchLayout = new QHBoxLayout; > +searchLayout->addWidget(new QLabel(i18n("Filter:"))); > +searchLayout->addWidget(m_searchLine); In general, we're trying to standardize on a single KDE-wide style for our se

D18939: KMenuEdit: add search/filter bar

ngraham added a comment. This revision still has unrelated `.gitignore` changes. REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D18964: UpdatesPage: Fix icon sizing on small screens

ngraham added a comment. Can you confirm whether or not this also fixes https://bugs.kde.org/show_bug.cgi?id=404070? Can't test right now, I don't have any updates! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18964 To: jbbgameich, #discover_

D18964: UpdatesPage: Fix icon sizing on small screens

jbbgameich created this revision. jbbgameich added a reviewer: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY On Small screens (e.g phones), not all list items have the same height,

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > mvourlakos wrote in menu.cpp:92 > in this slot is also needed: > > m_configureAction->setEnabled(true); > > there are cases that the Dock Settings is shown when !configuring but it is > not enabled I don't understand. my code only change the `v

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > mvourlakos wrote in menu.cpp:68 > when we add character & in the menus it means that a modifier+&Letter > activates that option what is the shortcut that add widgets? For example, "&Add widgets..." - shortcut: `Alt+a` - the shortcut only works whe

D18918: Make the text of "View Settings" action more specific

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:92 > +connect(this->containment(), > &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){ > +m_configureAction->setVisible(!configuring); > +}); in this slot is also needed: m_configure

D18918: Make the text of "View Settings" action more specific

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:132 > +const int viewType = this->containment()->config().readEntry("viewType", > static_cast(Latte::Types::DockView)); > +m_configureAction->setText(i18nc("view settings window", viewType == > Latte::Types::DockView ? "Dock &

D18918: Make the text of "View Settings" action more specific

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:68 > > -m_addWidgetsAction = new QAction(QIcon::fromTheme("add"), i18n("Add > Widgets..."), this); > +m_addWidgetsAction = new QAction(QIcon::fromTheme("add"), i18n("&Add > Widgets..."), this); > m_addWidgetsAction->set

D18896: [plasma-nm] Refresh wifi networks as fast as possible

vpilo updated this revision to Diff 51525. vpilo added a comment. - Review comments, rework - Put the timer back to 15s - Removed trigger on start for QML timers: the timer now only runs if the current scan was successful - Don't use any more Qt 5.12 APIs REPOSITORY R116 Plasma Net

D18903: Make Appearance KCMs' labels consistent

GB_2 added a comment. We currently use the KAboutData name in headers, we can easily change them to real titles and leave the desktop files how they are currently (explanation sentences). Should we just use the KCM name in the header or something more explaining like "Look and Feel Theme Sel

D18918: Make the text of "View Settings" action more specific

trmdi added inline comments. INLINE COMMENTS > mvourlakos wrote in menu.cpp:91 > is this still needed if we check the value each time we show up the context > menu? Yes, it's needed. Because when you're opening the Setting window and you right click on the view, it will close the Setting windo

D18918: Make the text of "View Settings" action more specific

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:91 > + > +connect(this->containment(), > &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){ > +m_configureAction->setVisible(!configuring); is this still needed if we check the value each ti

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

kossebau added a comment. > we no longer have to install the widget to .../share/plasma/plasmoids/ No experience here, but do we not still need to install the QML extension plugins to have the applet working? Or is there some mechanism to load them also from the build dir now? REPOSITOR

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

kossebau added a comment. Thanks for the work on that patch! So far I had thought of using the kconf_update system to ensure the config data would get the needed migration in the storage system (i.e. the ini files) into the [General] & Co. subsection as needed with the QML-based config v

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

ngraham added a comment. No. :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D18859: cdb: First working version

patrickelectric marked 2 inline comments as done. patrickelectric added a comment. Make tomaz happy REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pite

D18859: cdb: First working version

patrickelectric updated this revision to Diff 51518. patrickelectric added a comment. remove virtual, override. REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51516&id=51518 BRANCH cdb REVISION DETAIL https://phabricator.kde.org/D18859 AFFEC

D18867: Remove redundant DNS field per bug 403546

ngraham added a comment. Does this fix 403546? If so, then the Summary section should have `BUG: 403546` in it so the bug automatically gets closed. Also regardless, You should remove "per bug 403546" from the title. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_pa

D18859: cdb: First working version

tcanabrava requested changes to this revision. tcanabrava added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > backtraceparsercdb.h:31 > +protected Q_SLOTS: > +virtual void newLine(const QString &lineStr); > + remove virtual, override. > backtraceparsercdb

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51515. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51498&id=51515 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, mvourlakos Cc: plasm

D18859: cdb: First working version

patrickelectric added a comment. This is a screenshot of drkonqi on windows, it was built with craft and integrated with a WIP project. F6611293: image.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelec

D18859: [WIP] msvc: First commit

patrickelectric updated this revision to Diff 51516. patrickelectric added a comment. Correct and initial implementation REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51209&id=51516 BRANCH cdb REVISION DETAIL https://phabricator.kde.org/D188

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY If `plasmoid.nativeInterface.source != ""`, we copy it to `plasmoid.configuration.source` + same with all other properties besides `nee

D18867: Remove redundant DNS field per bug 403546

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I wonder whether this should also go to Plasma 5.15 branch, it's an improvement and doesn't introduce new strings so should be ok to be backported. REPOSITORY R116 Plasma Network Mana

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. @ngraham, are the icorresponding images now removed after removing a folder with the removal of the token check? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham Cc: alexde, davidedmundson, ngraham, p

D18918: Make the text of "View Settings" action more specific

trmdi added a comment. In D18918#410614 , @mvourlakos wrote: > I don't think it is needed, you can try to update the action text just a little before the menu is shown > > Qmenu has an aboutToShow signal and containment has as a contextuakA

D18896: [plasma-nm] Refresh wifi networks as fast as possible

jgrulich added a comment. In D18896#410594 , @vpilo wrote: > In D18896#409742 , @jgrulich wrote: > > > I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops

Force reset of kwayland

I merged someone else's commit by mistake which wasn't accepted. It was force reset immediately afterwards. Hopefully won't have affected anyone Sorry David

D18918: Make the text of "View Settings" action more specific

mvourlakos added a comment. In D18918#410587 , @trmdi wrote: > In D18918#410552 , @mvourlakos wrote: > > > > > Do you have a better way to detect when `viewType` changes? I don't

D18896: [plasma-nm] Refresh wifi networks as fast as possible

davidedmundson added a comment. > Other thing I would change is to try to repeat the scan if it fails only for the first time > then I don't think it's necessary to keep spamming NetworkManager with our requests. Maybe not necessary, but I don't think it's an issue either. The ret

D18896: [plasma-nm] Refresh wifi networks as fast as possible

vpilo added a comment. In D18896#409742 , @jgrulich wrote: > I would keep the 15s interval, everyone does 15s. Also from what I have read, every scan drops your connection for a while, which might be a problem for bad wifi drivers, where the sca

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51498. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51481&id=51498 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp containmentactions/contextmenu

D18918: Make the text of "View Settings" action more specific

trmdi added a comment. In D18918#410552 , @mvourlakos wrote: > for Latte panels after startup or after switching layouts if the user right clicks the panel the menu is appearing correctly as: > > **Panel Setings...** ? Whenever there

D18766: Don't show tooltip when search field has text

This revision was automatically updated to reflect the committed changes. Closed by commit R134:c62901d8aed6: Don't show tooltip when search field has text and set a timeout period (authored by shubham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kd

Plasma 5.15.0

Plasma 5.15.0 is now released https://www.kde.org/announcements/plasma-5.15.0.php

D18918: Make the text of "View Settings" action more specific

mvourlakos added a comment. for Latte panels after startup or after switching layouts if the user right clicks the panel the menu is appearing correctly as: **Panel Setings...** ? INLINE COMMENTS > menu.cpp:92 > +connect(this->containment(), > &Plasma::Containment::userConfiguringC

D18946: Set parent on newly created fwupd resource

This revision was automatically updated to reflect the committed changes. Closed by commit R134:8c673e79ab45: Set parent on newly created fwupd resource (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18946?vs=51482&id=5148

D18946: Set parent on newly created fwupd resource

leinir updated this revision to Diff 51482. leinir added a comment. Slightly different (and more central) approach. This ensures that resources are parented on creation rather than later (such as when being added to the updates list) REPOSITORY R134 Discover Software Store CHANGES SINCE L

D18918: Make the text of "View Settings" action more specific

trmdi updated this revision to Diff 51481. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18918?vs=51464&id=51481 REVISION DETAIL https://phabricator.kde.org/D18918 AFFECTED FILES containmentactions/contextmenu/menu.cpp containmentactions/contextmenu

D18946: Set parent on newly created fwupd resource

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, t

Make Kicker accessible

Howdy David, i wonder if we can revoke the following for the next version of plasma? https://phabricator.kde.org/D7780 would be very awsome to not have it stalled if you already did most of the work and have an accessible default menu :). cheers chrys