D18745: Fix connections' context menus position and parent

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5000fc973c6d: Fix connections' context menus position and parent (authored by vpilo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18745?

D18745: Fix connections' context menus position and parent

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Seems to work. Thanks. REPOSITORY R116 Plasma Network Management Applet BRANCH vpilo/fixRightClick (branched from master) REVISION DETAIL https://phabricator.kde.org/D18745 To:

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#406296 , @mvourlakos wrote: > @trmdi would you like to commit it for you? > Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ? > and what is your email? Yes, I don't have the co

D18717: improvements for global shortcuts

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. @trmdi would you like to commit it for you? Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ? and what is your email? REPOSITORY R878 Latte Dock REVISIO

D18717: improvements for global shortcuts

trmdi marked an inline comment as done. trmdi added a comment. 1, please make a check that sortedViewsList returns count()>0 and if it doesnt it can return a nullptr -> done 2, your turn REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 To: trmdi, mvou

D18765: Fix autologin session loading

ngraham added a comment. Going through old SDDM KCM bugs, it seems that this was already reported as https://bugs.kde.org/show_bug.cgi?id=391723. Fixed now! :) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D18765 To: davidedmundson, #plasma,

D18777: [kcms/mouse] Load current server settings in kcminit

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Confirmed the fix. Such a small change for a big problem. Do you think you could land this on the `Plasma/5.14` branch and then merge forward? There are rumblings of a new 5.14 re

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 51015. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50978&id=51015 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortc

D18777: [kcms/mouse] Load current server settings in kcminit

davidedmundson updated this revision to Diff 51014. davidedmundson added a comment. fix copy pasta out of virtualbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18777?vs=51010&id=51014 BRANCH master REVISION DETAIL https://phabricator.kde.or

D18642: [kio_applications] Install binary into kf5/kio subdir, like other kio binaries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:91fbb2e7ef04: [kio_applications] Install binary into kf5/kio subdir, like other kio binaries (authored by kossebau). R

D18632: Port away from deprecated KIO::UDSEntry::insert()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bcddc7924684: Port away from deprecated KIO::UDSEntry::insert() (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18632?vs=50609&id=51

D18777: [kcms/mouse] Load current server settings in kcminit

ngraham added a comment. Hmm, this does not compile for me: [ 34%] Building CXX object kcms/mouse/CMakeFiles/kcm_mouse.dir/backends/x11/x11_evdev_backend.cpp.o /home/dev/repos/plasma-desktop/kcms/mouse/backends/x11/x11_evdev_backend.cpp: In member function ‘virtual void X11EvdevBa

D18641: [kio_applications] Fix last dir item being shown twice

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3431ea6dd1d2: [kio_applications] Fix last dir item being shown twice (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18641?vs=50642&

D18777: [kcms/mouse] Load current server settings in kcminit

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Without loading the current server status m_handed will remain Handed::NotS

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 51009. rthomas added a comment. I've also moved isConnectionTypeVirtual() in uiutils.cpp. Forgot to do that! REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=51006&id=51009 REVISION DETA

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 51006. rthomas added a comment. Moved isConnectionTypeVirtual() below isConnectionTypeSupported() REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=50900&id=51006 REVISION DETAIL https:

D18765: Fix autologin session loading

This revision was automatically updated to reflect the committed changes. Closed by commit R123:634a2dd1bef5: Fix autologin session loading (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18765?vs=50973&id=51007#toc REPOSITORY R123 SDDM Configuration Panel

D18696: Update `libdbusmenuqt` and the AppMenu plugin

ntninja added a comment. @Zren: Updated! Thanks for pointing this out! @cfeck: It contains the fix from bug 399975 yes, but I don't know whether it will fix LyX. REVISION DETAIL https://phabricator.kde.org/D18696 To: ntninja, Zren, majohnson Cc: cfeck, plasma-devel, jraleigh, GB_2, ra

D18696: Update `libdbusmenuqt` and the AppMenu plugin

ntninja updated this revision to Diff 50993. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18696?vs=50770&id=50993 REVISION DETAIL https://phabricator.kde.org/D18696 AFFECTED FILES plugin/appmenumodel.cpp plugin/appmenumodel.h plugin/appmenuplugin.cpp plugin/libdbusmenuqt/db

D18760: Don't accept invalid KNS EntryInternal results

apol added a comment. I'd actually like to be sure that it's fixing any issues before backporting to 5.12. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18760 To: leinir, apol, ngraham, #discover_software_store Cc: plasma-devel, jraleigh, bam, GB_2

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. >> I'm not sure you even need to add the `timeout: ` line at all. A tooltip with a negative timeout does not hide automatically. The default value is -1. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham,

D18717: improvements for global shortcuts

mvourlakos added inline comments. INLINE COMMENTS > globalshortcuts.cpp:810 > +{ > +return > sortedViewsList(m_corona->layoutManager()->currentLatteViews())[0]; > +} 1. this can create a crash when there are no views at all shown. please make a check that sortedViewsList returns **count()>

D18760: Don't accept invalid KNS EntryInternal results

ngraham added a comment. Should this go to the 5.15 branch? Or even 5.12 and later? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18760 To: leinir, apol, ngraham, #discover_software_store Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel,

D18766: Don't show tooltip when search field has text and set a timeout period

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D18766#406035 , @shubham wrote: > When user is typing text, the tooltip continuosly shown above distracts and looks ugly

D18767: [KEditFileType] Make heading with mime type selectable

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows to copy the mime type displayed to clipboard TEST PLAN No longer have to type awfull

D18766: Don't show tooltip when search field has text and set a timeout period

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Meh, okay. REPOSITORY R134 Discover Software Store BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen,

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. When user is typing text, the tooltip continuosly shown above distracts and looks ugly REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot

D18766: Don't show tooltip when search field has text and set a timeout period

apol added a comment. What's wrong with seeing the tooltip when there's text? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D18766: Don't show tooltip when search field has text and set a timeout period

shubham marked an inline comment as done. shubham added a comment. @apol I have noticed that the tooltip is seen even when there is text present, also the duration for which it appears is very long REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 50978. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50974&id=50978 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortc

D18766: Don't show tooltip when search field has text and set a timeout period

shubham updated this revision to Diff 50977. shubham added a comment. Use length REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18766?vs=50975&id=50977 BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 AFFECTED FILES

D18765: Fix autologin session loading

ngraham added a comment. Maybe even 5.12 material? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18765 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-

D18766: Don't show tooltip when search field has text and set a timeout period

broulik added inline comments. INLINE COMMENTS > SearchField.qml:47 > delay: Kirigami.Units.longDuration > -visible: hovered > +visible: hovered && searchField.text == "" > +timeout: Kirigami.Units.shortDuration Prefer using `length` as that avoids copying a stri

D18766: Don't show tooltip when search field has text and set a timeout period

apol added a comment. the tooltip should be shown especially when the view is empty. Also the timeout is set already by the style. I don't understand what you are trying to fix. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham,

D18766: Don't show tooltip when search field has text and set a timeout period

shubham created this revision. shubham added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY Earlier, the tooltip was continuosly shown even though it was observed when search field was empty.

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#405084 , @mvourlakos wrote: > it looks and behave nice, lets see with Layout how it will look but I believe there will be no issues, > we are ok to commit if the property is moved to Layout I've moved

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 50974. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50814&id=50974 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortc

D18765: Fix autologin session loading

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this fixes the issue (currently tracked somewhat incorrectly at https://github.com/sddm/sddm/issues/1132) REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISI

D18765: Fix autologin session loading

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY SDDM config stored the autologin value to be in the form Session=Plasma

D18760: Don't accept invalid KNS EntryInternal results

ngraham added a comment. Is this a good candidate for going into 5.14 too? Or even 5.12? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18760 To: leinir, apol, ngraham, #discover_software_store Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, P

D18745: Fix connections' context menus position and parent

vpilo updated this revision to Diff 50971. vpilo added a comment. Reworked. There already were lots of binding loops in this QML, stuff for another change REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18745?vs=50910&id=50971

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a subscriber: mart. ngraham added a comment. In D18504#405873 , @vpilo wrote: > In D18504#405816 , @ngraham wrote: > > > The problem is that you're using a disabled menu item for the ti

D18760: Don't accept invalid KNS EntryInternal results

This revision was automatically updated to reflect the committed changes. Closed by commit R134:b11cdd776c93: Don't accept invalid KNS EntryInternal results (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18760?vs=50965&id=

D18760: Don't accept invalid KNS EntryInternal results

leinir added a comment. In D18760#405894 , @apol wrote: > Good, now I just wonder why KNS would give us poised entries... Indeed, that would want to be looked at. Essentially, it just forwards the result of the list job from Attica, which

D18760: Don't accept invalid KNS EntryInternal results

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Good, now I just wonder why KNS would give us poised entries... REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18760 To: leinir, apol, ngraham, #disco

D18760: Don't accept invalid KNS EntryInternal results

leinir updated this revision to Diff 50965. leinir marked an inline comment as done. leinir added a comment. Actually use the filtered list of entries REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18760?vs=50952&id=50965 REVISION DETAIL

D18751: [kcms/cursortheme] Correctly load m_originalPreferredSize

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can confirm the problem and that this fixes it. Code change looks sane. Ship it! 5.15 branch obvs REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.

D18760: Don't accept invalid KNS EntryInternal results

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:213 > first arg should be `filtered`. Oh dear! Yes, it should. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18760 To: leinir, apol,

D18632: Port away from deprecated KIO::UDSEntry::insert()

chinmoyr accepted this revision. chinmoyr added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > kossebau wrote in kio_desktop.cpp:183 > :) > > Well, I would rather be safe then sorry. We have no control over what other > code might do to the entry object,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#405816 , @ngraham wrote: > In D18504#405444 , @vpilo wrote: > > > In D18504#404332 , @Codezela wrote: > > > > > small t

D18760: Don't accept invalid KNS EntryInternal results

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KNSBackend.cpp:213 > +const auto filtered = kFilter(entries, > [this](const KNSCore::EntryInternal& entry){ return entry.isValid(); }); > const auto reso

D17706: Fix lock screen focus

ngraham added a comment. So what's required next here? REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: ngraham, graesslin, abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D18647: Use the correct cursor when hovering over the editable part of a spinbox

This revision was automatically updated to reflect the committed changes. Closed by commit R858:a711b2e7b4a9: Use the correct cursor when hovering over the editable part of a spinbox (authored by ngraham). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://p

D18632: Port away from deprecated KIO::UDSEntry::insert()

kossebau added inline comments. INLINE COMMENTS > chinmoyr wrote in kio_desktop.cpp:183 > A doubt, why are you using replace here? Is UDS_TARGET_URL set somewhere > before coming here? :) Well, I would rather be safe then sorry. We have no control over what other code might do to the entry ob

D18632: Port away from deprecated KIO::UDSEntry::insert()

chinmoyr added inline comments. INLINE COMMENTS > chinmoyr wrote in kio_desktop.cpp:183 > A doubt, why are you using replace here? Is UDS_TARGET_URL set somewhere > before coming here? My bad! I didn't read the summary properly. But it seems UDS_TARGET_URL is not set anywhere prior to this (a

D18632: Port away from deprecated KIO::UDSEntry::insert()

chinmoyr added inline comments. INLINE COMMENTS > kio_desktop.cpp:183 > QUrl > localUrl(QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > -entry.insert(KIO::UDSEntry::UDS_TARGET_URL, localUrl.toString()); > +entry.replace(KIO::UDSEntry::UDS_TARGET_URL, localU

D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface

davidedmundson added a comment. CI is now good to go. There's a thread on plasma-devel checking the other devs won't be screwed when I upgrade. I'll give that a few days. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricato

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. In D18504#405444 , @vpilo wrote: > In D18504#404332 , @Codezela wrote: > > > small tweak we can make the connection name in the context menu bold header msybe > > because

D18515: Bump to Qt5.12 - Drop kwin's custom ServerSideDecorationManager interface

zzag added a comment. Is it good to go? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D18515 To: davidedmundson, #plasma, #kwin, zzag, graesslin Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18753: [kcms/keys] Fix double margin

This revision was automatically updated to reflect the committed changes. Closed by commit R119:004ce594feff: [kcms/keys] Fix double margin (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18753?vs=50928&id=50956 REVISION DE

D18737: [image wallpaper] Show wallpaper title/filename on grid view delegates

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d307f6879d40: [image wallpaper] Show wallpaper title/filename on grid view delegates (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D18760: Don't accept invalid KNS EntryInternal results

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY In certain cases we m

D18724: Add a timeout for KNS backends

This revision was automatically updated to reflect the committed changes. leinir marked an inline comment as done. Closed by commit R134:003fc9fc9800: Add a timeout for KNS backends (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18724?vs=50845&id=50950#toc REPOSITOR

D18696: Update `libdbusmenuqt` and the AppMenu plugin

cfeck added a comment. If this fixes bug 401725, please add a line "BUG: 401725" to the commit message. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D18696 To: ntninja, Zren, majohnson Cc: cfeck, plasma-devel, jraleigh, GB_2, ragree

D18748: [kcms/launch] Avoid infinite loop in button handling

This revision was automatically updated to reflect the committed changes. Closed by commit R119:70a0c99d08b5: [kcms/launch] Avoid infinite loop in button handling (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18748?vs=5091

Plasma and Qt5.12

We've agreed that we want Plasma5.16 to depend on Qt5.12. Are there any objections to switching master to depend on this? David

D18754: [Look and Feel KCM] Write schemeName last

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bbf848a92a37: [Look and Feel KCM] Write schemeName last (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18754?vs=50929&id=50930 REVISI

D18752: Also try untranslated theme name

broulik abandoned this revision. broulik added a comment. Superseded by D18754 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18752 To: broulik, #plasma, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D18754: [Look and Feel KCM] Write schemeName last

broulik added a comment. I guess REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18754 To: broulik, #plasma, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18754: [Look and Feel KCM] Write schemeName last

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Is it worth putting this in 5.15? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18754 To: broulik, #plasma, davidedmundson Cc: plasma-deve

D18724: Add a timeout for KNS backends

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > davidedmundson wrote in KNSBackend.cpp:143 > this already calls setFetching(false). Good spot, i'll just swipe that and get it in :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phab

D18754: [Look and Feel KCM] Write schemeName last

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We copy the `.colors` file's contents into `kdeglobals` and I have seen many of th

D18752: Also try untranslated theme name

davidedmundson added a comment. Why do we ever need to use a translated version? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18752 To: broulik, #plasma, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jen

D18753: [kcms/keys] Fix double margin

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY A widget should expand to the edge of the widget. i.e a QLineEdit covers th

D18752: Also try untranslated theme name

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Color scheme names can be translated (and have recently been) which is why the new

D18614: Fix loading of background image preview

This revision was automatically updated to reflect the committed changes. Closed by commit R123:dc1922e6aa48: Fix loading of background image preview (authored by davidedmundson). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18614?vs=5

D18615: Fix mime type filter on background selection button

This revision was automatically updated to reflect the committed changes. Closed by commit R123:159e2dcbf935: Fix mime type filter on background selection button (authored by davidedmundson). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D18751: [kcms/cursortheme] Correctly load m_originalPreferredSize

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise setNeedsSave evaluates incorrectly. BUG: 403775 TEST PLAN O

D18748: [kcms/launch] Avoid infinite loop in button handling

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY When visiting Applications / Launch Feedback the star, indicating a edit on

D18745: Fix connections' context menus position and parent

vpilo added a comment. In D18745#405458 , @jgrulich wrote: > This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items. Oh, looks like I didn't test the lat

D17706: Fix lock screen focus

davidedmundson added a comment. Seems better, but I'm not sure I understand exactly. The key difference here is we have an event filter on mouse clicks and call requestActivate when that happens. But you said earlier calling requestActivate doesn't do anything. REVISION DETAIL https:

D17706: Fix lock screen focus

andreyby updated this revision to Diff 50911. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=50543&id=50911 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp greeter/greeterapp.h To: andreyby, davidedmundson Cc: ngraham, graesslin,

D18745: Fix connections' context menus position and parent

jgrulich added a comment. This breaks connection details, try to expand details for some available connection. There appears to be some issue with heigh of the items. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18745 To: vpilo, broulik,

D18745: Fix connections' context menus position and parent

vpilo created this revision. vpilo added reviewers: broulik, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. vpilo requested review of this revision. REVISION SUMMARY A connection's context menu now opens only from

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

vpilo added a comment. In D18504#404332 , @Codezela wrote: > small tweak we can make the connection name in the context menu bold header msybe > because it look like disabled now > it looks strange to me > what do u think I tried