D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > uiutils.h:126 > + */ > +static bool > isConnectionTypeVirtual(NetworkManager::ConnectionSettings::ConnectionType > type); > + Can you just move this metho

D18696: Update `libdbusmenuqt` and the AppMenu plugin

Zren added inline comments. INLINE COMMENTS > CMakeLists.txt:27 > > -# add_subdirectory(test) > +add_subdirectory(test) We do not bundle the libdbusmenuqt test directory in this repo. So you need to comment this line out otherwise it will not build with the test directory missing. REPOSITOR

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50900. rthomas added a comment. Shouldn't have removed the existing condition to check if the connection object is not valid. Added it back. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50899. rthomas added a comment. Hey Jan, I've made the changes you suggested. Let me know if anything needs to be fixed. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=50771&id=50

D18737: [image wallpaper] Show wallpaper title/filename on grid view delegates

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes the wallpaper chooser grid view delegates show the wallpaper's title (if i

D18733: With software rendering, use outlines instead of shadows on login & lock screen

ngraham added a comment. Ah, well at least this part of the support is already done then! :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18733 To: ngraham, #plasma, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, al

D18727: [Icon Applet] Use libTaskManager for startup feedback

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c211cbf885a: [Icon Applet] Use libTaskManager for startup feedback (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18727?vs=50857&id=50880#toc REPOSITORY R120 Plasma W

D18733: With software rendering, use outlines instead of shadows on login & lock screen

davidedmundson added a comment. FWIW, currently it'll only affect the lock screen as SDDM doesn't have any code (yet!) to enable software rendering. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18733 To: ngraham, #plasma, davidedmundson Cc: plasma-devel,

D18727: [Icon Applet] Use libTaskManager for startup feedback

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in iconapplet.cpp:404 > should this be index(i, 0) ? Good spot, indeed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18727 To: broulik, #plasma, hein Cc: davidedmundson, plasma-devel, jr

D18733: With software rendering, use outlines instead of shadows on login & lock screen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dbb19ba33304: With software rendering, use outlines instead of shadows on login & lock screen (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

D18733: With software rendering, use outlines instead of shadows on login & lock screen

ngraham updated this revision to Diff 50874. ngraham added a comment. Use a more descriptive variable name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18733?vs=50873&id=50874 BRANCH fall-back-to-outlines-with-software-rendering (branched from

D18733: With software rendering, use outlines instead of shadows on login & lock screen

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY QML shadows aren't supported with software rendering, so the white text often has

D18732: Update SwipeListItem doc to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R169:7a351c481822: Update SwipeListItem doc to QQC2 (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18732?vs=50871&id=50872 REVISION DETAIL

D18727: [Icon Applet] Use libTaskManager for startup feedback

davidedmundson added inline comments. INLINE COMMENTS > iconapplet.cpp:404 > +for (int i = first; i <= last; ++i) { > +const QModelIndex idx = m_startupTasksModel->index(first, 0); > +if > (idx.data(TaskManager::AbstractTasksModel::LauncherUrlWithoutIc

D18732: Update SwipeListItem doc to QQC2

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH doc REVISION DETAIL https://phabricator.kde.org/D18732 AFFECT

D18717: improvements for global shortcuts

mvourlakos added a comment. In D18717#404866 , @trmdi wrote: > In D18717#404861 , @mvourlakos wrote: > > > > > > What do you think? it looks and behave nice, lets see with Layout how it

D18727: [Icon Applet] Use libTaskManager for startup feedback

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. ❤ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18727 To: broulik, #plasma, hein Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali

D18727: [Icon Applet] Use libTaskManager for startup feedback

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it future-proof for Wayland TEST PLAN (and Eike happy) - still works the same

D18724: Add a timeout for KNS backends

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KNSBackend.cpp:143 > +if(!m_initialized) { > +markInvalid(i18n("Backend %1 took too long to initialize", > m_displayName)); > +

D18701: [Icon Applet] Show busy indicator when launching app

hein added a comment. Hmm ... I guess it's OK, but using libtaskmanager would have been nicer maybe (centralized the timeout behavior, and the monitoring). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18701 To: broulik, #plasma, ngraham Cc: hein, plasma-

D18651: [Task Manager] Sort manually by default

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6d6d9dbc6241: [Task Manager] Sort manually by default (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18651?vs=50668&id=50848 REVISION

D18701: [Icon Applet] Show busy indicator when launching app

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ac3fa8cbee19: [Icon Applet] Show busy indicator when launching app (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18701?vs=50819&id=

D18723: Use new Notifications KCM icon in other appropriate places too

This revision was automatically updated to reflect the committed changes. Closed by commit R120:36a85c5e5638: Use new Notifications KCM icon in other appropriate places too (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18723?vs

D18724: Add a timeout for KNS backends

leinir created this revision. leinir added reviewers: ngraham, apol, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This patch will mark

D18723: Use new Notifications KCM icon in other appropriate places too

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY D18678 changes the Notifications KCM's icon. This pa

D18700: [Color Picker] Allow dragging color button to drag color

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e0f0400dc7f2: [Color Picker] Allow dragging color button to drag color (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18700?vs=50820&id

D18721: [Folder View] Assume root of a protocol is always a folder

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Noticed that plasmashell spins up the trash KIO on startup, turns out it tries to figure out whethe

D18646: [Colors KCM] Add search and filter

ngraham accepted this revision as: VDG. ngraham added a comment. UI and interactivity are great. Very nice addition. Would be nice to have the search field as a re-usable component, yes. As in D18716: Add a SearchField component . REPOSITORY R119 Pla

D18716: Add a SearchField component

ngraham added a comment. I agree, it should be a generic TextField that just so happens to be useful as a search field if you'd like. Bonus points if one of the built-in actions is "show/hide password" so it can be used as a password field too. REPOSITORY R169 Kirigami REVISION DETAIL h

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#404861 , @mvourlakos wrote: > @trmdi can you confirm me the following for your code ? > > 1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set pri

Monday meeting minutes for 2019-02-04 (week 6)

Of special note: We decided on doing another 5.14.x release to round up Folder View and Discover fixes, to aid Debian Stable which will ship 5.14.x. This will happen pending th completion of some Discover work for the branch. kbroulik - Merged new Color KCM \o/ - Desktop Theme KCM

D18700: [Color Picker] Allow dragging color button to drag color

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18700 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18717: improvements for global shortcuts

mvourlakos added a comment. @trmdi can you confirm me the following for your code ? 1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded 2. When the user changed the isPreferredForShort

D18646: [Colors KCM] Add search and filter

broulik updated this revision to Diff 50838. broulik edited the test plan for this revision. broulik added a comment. - Add filter icon to ComboBox, needs D18718 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D186

D18716: Add a SearchField component

broulik added a comment. > Should the buttons only be visible when the text is not empty? Or can this behavior also be configurable with a property? `Action` has a `visible` property which should be taken into account like normal here as well REPOSITORY R169 Kirigami REVISION DETAIL

D18716: Add a SearchField component

ognarb added a comment. In D18716#404718 , @mart wrote: > If we are going to have a specialized line edit, I think it shouldn't be specific for search, but be a common component of things that we have to boilerplate too often as they are missing

Fwd: Shutdown of paste.kde.org

Kindly note that the shutdown of paste.kde.org will affect https://cgit.kde.org/kwin.git/tree/workspace.cpp?id=2799f69533ec5d45f6910fe3972a5297cd622d58#n1333 and https://cgit.kde.org/plasma-workspace.git/tree/dataengines/share/backends/kde/contents/code/main.js?id=56bc3c7499427fa292a23117e96e5bc

D18716: Add a SearchField component

apol added a comment. I'm fine with having this code relicensed. INLINE COMMENTS > ngraham wrote in SearchField.qml:33 > @apol Is this still applicable if it's a re-usable component? No, this is for Discover-specific behavior. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricato

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. I can no longer right click the details entries (e.g. IP address) to copy them to clipboard, the menu is blocked by this new menu. Perhaps the menu should only be on the text sections of

D18718: Support icon on ComboBox

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's no Qt API for this, unfortunately. TEST PLAN properties: { currentIcon: "view-filter"

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 04 Feb 2019 09:39:03 + Build duration: 57 sec and counting

D18700: [Color Picker] Allow dragging color button to drag color

broulik updated this revision to Diff 50820. broulik added a comment. - Fake pressed state Turns out we already fake it for when an acceptable drag comes in so we can also just use that for pressed state REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde

D18654: [fonts:/ KIO] Implement stat() call

broulik planned changes to this revision. broulik added a comment. It breaks with composite fonts that are turned into a ZIP file. I had this working at one point but can't remember what I did :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18654 To: broul

D18701: [Icon Applet] Show busy indicator when launching app

broulik updated this revision to Diff 50819. broulik added a comment. - Read timeout REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18701?vs=50781&id=50819 REVISION DETAIL https://phabricator.kde.org/D18701 AFFECTED FILES applets/icon/CMakeLi

D18700: [Color Picker] Allow dragging color button to drag color

broulik added a comment. > Could containsPress be used to pass the event down to the button so we get visual feedback? Unfortunately not, those properties are read-only in QtQuick Controls. One could fake that using "checkable" perhaps. REPOSITORY R114 Plasma Addons REVISION DETAIL

D18497: Disable KCMs while downloading file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:366ec1b2ee59: Disable KCMs while downloading file (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18497?vs=50183&id=50818 REVISION DET

D18655: Use correct window for getting ComboBox current icon pixmap

This revision was automatically updated to reflect the committed changes. Closed by commit R31:afef901a2a5a: Use correct window for getting ComboBox current icon pixmap (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18655?vs=50675&id=50815

D18717: improvements for global shortcuts

trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 403880 REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 AFF