D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. In D18019#388819 , @Zren wrote: > In D18019#388811 , @ndavis wrote: > > > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. >

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388811 , @ndavis wrote: > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. Adding a second link is pretty easy, though I wrote this before I noticed your edi

D18019: [Digital Clock] Add ability to set a custom date format string

ndavis added a comment. > Should I add presets like Event Calendar? I'm leaning towards no, but an example of the custom time formatting and another of HTML styling would be a good idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added inline comments. INLINE COMMENTS > configAppearance.qml:145 > +'name': "custom" > } > ] Does this also need a `i18nc("custom date format", "Custom")` translation context? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D18019: [Digital Clock] Add ability to set a custom date format string

rooty added a comment. a thousand times yes... this is amazing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #plasma, #vdg Cc: rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18005: Include only the largest size for each wallpaper

filipf added a comment. In D18005#387607 , @davidedmundson wrote: > - Our run-time resizes will look worse than gimp/inkscape doing it. Letting Plasma scale this 3972x2979 wallpaper . F653332

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Here's some raw numbers listed: - plasma-workspace-wallpapers prior to D17780 : about 42 MB - plasma-workspace-wallpapers after D17780 : about 152 MB - plasma-workspace-wallpapers after

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. F6531451: Screenshot_20190107_145258.png In this one, the fact that it's a header is connoted by its much larger font size and wider character width and spacing. It feels "bigger" in every way than the text beneath it. It look

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Ah we only ship the biggest size for our additions now. It's the only thing that makes sense for this package IMO, among other things distros will really think twice about shipping it if it's big, like you said. Heck, if someone asked **me** if they could put 100-

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. Before and after would be perfect, yes! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham Cc: davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, leslie

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. In D17975#388788 , @ngraham wrote: > Could you update the images in the Summary section instead of posting new ones in comments? The visual history of the patch is not really important to preserve, and having the images on

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. Could you update the images in the Summary section instead of posting new ones in comments? The visual history of the patch is not really important to preserve, and having the images on top always be current makes reviewing it much easier. Thanks! REPOSITORY R120

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. I removed "0.75 * units.smallSpacing" because it's not an integer - the result is that the margins are slightly uneven, but considering they weren't ever entirely even, and the difference between the margins gets more pronounced with increasing font size (and scaling f

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

ngraham added a comment. Lovely. Good call including all size and aspect ratio variants for now in case we don't opt to go with D18005: Include only the largest size for each wallpaper . Dare I ask how big all of this on disk? You can find out with `du

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48943. rooty added a comment. Use integers/halves and line counts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48711&id=48943 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 AFF

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. In D17975#388728 , @rooty wrote: > Hey guys, I feel silly asking this but I'm using a different computer right now - how do I get this computer's arcanist to lock onto and update this diff (instead of creating an entirel

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

ngraham added a comment. In D18044#388743 , @apol wrote: > #vdg if that's the case, I'd include placeholders here: https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels That's old; the HIG has

D18018: [Digital Clock] Add ability to change first day of week

Zren added a comment. In D18018#387920 , @davidedmundson wrote: > Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? https://bugs.kde.org/show_bug.cgi?id=390330#c5 > Just c

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 270 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/270/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 03 Jan 2019 16:47:53 + Build duration: 45 min and counting BUILD ARTIFACTS abi-compatibility-results.

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.11 - Build # 160 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.11/160/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 05 Jan 2019 16:27:59 + Build duration: 7 min 24 sec and counting BUILD ARTIFACTS abi-comp

Re: D18087: Use integers or halves, and correct for text margins using line count

You did something weird and the review can't be seen. On Tue, Jan 8, 2019 at 12:40 AM Root wrote: > rooty created this revision. > Herald added a project: Plasma. > Herald added a subscriber: plasma-devel. > rooty requested review of this revision. View Revision >

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

apol added a comment. #vdg if that's the case, I'd include placeholders here: https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18044 To: rooty, #vdg, #plasma

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Hey guys, I feel silly asking this but I'm using a different computer right now - how do I get this computer's arcanist to lock onto and update this diff (instead of creating an entirely new diff...)? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

D18087: Use integers or halves, and correct for text margins using line count

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH notification-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D18087 AFFECTED FI

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. Still not sure if we should have also included the grassland F6507127: jean-pierre-brungs-103087-unsplash.jpg REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg

D18080: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D18080 AFFECTED FILES kded/service.cp

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch improves the plasma-workspace-wallpapers package by offering cleaner, more modern photographic wallpapers. It also reintro

D16658: Respect the display property of buttons

astippich updated this revision to Diff 48917. astippich added a comment. - remove compatibility for Qt 5.9 and cleanup REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=46372&id=48917 BRANCH display_property REVISION DE

D16284: do not force text display for ToolButton

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d37015a5d1b0: do not force text display for ToolButton (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16284?vs=45425&id=48915#toc REPOSITORY R858 Qt Quick Controls 2

D18025: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18025 To: aacid, davidedmundson Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18026: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18026 To: aacid, davidedmundson Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18023: Use the nicer K_PLUGIN_CLASS_WITH_JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R115:c16e4ad21793: Use the nicer K_PLUGIN_CLASS_WITH_JSON (authored by aacid). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18023?vs=48834&id=48885

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. F6531867: image.png For me this represented a massive regression, and there's bound to be more people in a similar situation. We can't h

D18048: [Connections] Add search ellipsis to network connection search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds an ellipsis to the search function in Connections / System Settings. REPOSITORY R116 Plasma Network Management Apple

D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds an ellipsis to the filter and search labels in Font Management and Date and Time. REPOSITORY R119 Plasma Desktop BR

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch renames the label "Find file type or filename pattern" to "Search for file type or filename pattern..." REPOSITORY R126 K

D17751: Add shadow to Hour's hand

mart added a comment. In D17751#381215 , @davidedmundson wrote: > From the linked bug report (and your screenshot) > > > You're right about the typo, but it doesn't seem that trivial. The shadow shadow appears all offset (on the default bree

D17752: Remove full representation of analog clock

shubham abandoned this revision. shubham added a comment. Abandon in favor of above discussion. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17752 To: shubham, hein, mart, #vdg Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, P

D17752: Remove full representation of analog clock

mart added a comment. In D17752#388166 , @abetts wrote: > I think part of the reason why this seems too big also if because it doesn't do much more than tell you what day it is. If it was able to integrate with a calendar application, it could s

D17752: Remove full representation of analog clock

abetts added a comment. I think part of the reason why this seems too big also if because it doesn't do much more than tell you what day it is. If it was able to integrate with a calendar application, it could show appointments. Something like this: https://goo.gl/images/rwgUw9 REPOSITO

D17752: Remove full representation of analog clock

mart added a comment. -1, digital and analog clocks have the same scope, and they should have the same behavior (if anything it should have the same features of the digital clock popup) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17752 To: shubham, hei

Plasma 5.15 beta release announcement

Please add new features and noteable bug fixes made in 5.15 to https://notes.kde.org/p/plasma_5_15 This will be used as the basis for the release announce in 10 days time for 5.15 beta Jonathan

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino added a comment. Thanks -- which branch should I push this to? `Plasma/5.12`, `Plasma/5.14`, or only `master` for now? REPOSITORY R120 Plasma Workspace BRANCH sni-overlays (branched from master) REVISION DETAIL https://phabricator.kde.org/D17983 To: pino, apol Cc: apol, plasma-d

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino added inline comments. INLINE COMMENTS > apol wrote in statusnotifieritemsource.cpp:296 > Can this bit be removed then? No, this is needed for the "overlay by pixmap" case: `overlayNames` is empty (because no overlay name is available), while `overlay` is not null (as read by the pixmap)

D18018: [Digital Clock] Add ability to change first day of week

abetts added a comment. +1 How was this not an option ever? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, a

D17983: StatusItemNotifier: fix overlays by name with icons by name

apol added a comment. +1 Makes a lot of sense overall, I'd just like to make sure we're not missing something. INLINE COMMENTS > statusnotifieritemsource.cpp:296 > > if (overlayNames.isEmpty() && !overlay.isNull()) { > overlayIcon(&icon, &ove

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#388104 , @rooty wrote: > In D17906#388052 , @mart wrote: > > > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go

D17906: [kirigami] Do not use light font styles for headings (2/3)

rooty added a comment. In D17906#388052 , @mart wrote: > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? nope, very much agai

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. I was actually just going to reply that light titles could work theoretically well with level 1 headings before I saw your last comment. For this to work right, for me it would mean: - certain adjustments for visual hierarchy; big headings must still retain visua

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabr

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. in the end i *may* accept non light titles, even tough i still very much don't like the idea, but what i don't want to never, ever see in any circumstance is bold titles, anything of that will just be reverted. REPOSITORY R169 Kirigami BRANCH no-light-headings (bra

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385968 , @ngraham wrote: > - **Implementation inconsistency:** Many fonts don't have a dedicated light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use them even if nope, with the

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385857 , @filipf wrote: > With the exception of the case of the Windows Store (which does nonetheless manage to achieve some visual hierarchy with different font sizes and colors), others mostly actually have an o

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. > Perhaps we should alert packagers that for the 5.15 release, they shouldn't remove these files from users' machines when they disappear from the repo. That's not do-able. Why does it result in a black screen? If we are storing the image by path rath

D18005: Include only the largest size for each wallpaper

rikmills added a comment. In D18005#387324 , @ngraham wrote: > However, just removing files from the repo doesn't actually remove them from users' machines; their packaging system does that. Perhaps we should alert packagers that for the 5.15 re

Minutes meeting , week 2

Hello everyone! This is first meeting of year 2019, happy new year! Sho_: What I'd like to hear from everyone today and/or discuss, though: (not dictating, just suggesting:) * What's everyone looking at working on in January * What's currently in flight * What really needs to get done

D17834: Allow the use of One-Time Password

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b8f580a749f8: Allow the use of One-Time Password (authored by enriquem, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17834?vs=48852&id=48856#toc REPOSITORY R116 Pl

D18006: Include only the largest size for the "Next" wallpaper

ngraham added a comment. Thanks for noticing that! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D18006 To: ngraham, #vdg, #breeze Cc: filipf, kvermette, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D17533: Make the button's purpose more clear

amantia added a comment. I understand that, of course. I think the question is: is this an improvement or not? I think it is (not perfect, has problems, but an improvement), but if considered to be not, I will just abandon it, no hard feelings. REPOSITORY R119 Plasma Desktop REVISION DETA

D17533: Make the button's purpose more clear

pino added a comment. I'm personally still not convinced about the usage of the bold for questions, as I wrote in an earlier comment. The rest is not up to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: amantia, #plasma_accessibility, davided

D17834: Allow the use of One-Time Password

enriquem updated this revision to Diff 48852. enriquem added a comment. Now it builds. I tested it to write and read from the config file, interchangeably with nm-connection-editor, REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D18005: Include only the largest size for each wallpaper

filipf added a comment. I've booted up Debian 8, KDE SC version 4.14.2. The wallpapers scaled nicely there so I understand your curiosity. Taking a look at this list (https://packages.debian.org/de/jessie/all/kde-wallpapers/filelist) I notice three things: 1. some of the wallpapers

D17996: [sddm-theme] Remove blur on login screen when pressing a modifier

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ce5f209bd7ea: [sddm-theme] Remove blur on login screen when pressing a modifier (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D17997: [sddm-theme] Don't handle enter key when blurred

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e4212f1800be: [sddm-theme] Don't handle enter key when blurred (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17997?vs=48761&

D17533: Make the button's purpose more clear

amantia added a comment. Ping? I'll push this if there are no strong objections. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: amantia, #plasma_accessibility, davidedmundson, aacid, ngraham Cc: pino, gladhorn, ngraham, plasma-devel, kvanton, jralei

D17682: Show unconnected displays at the right side of the main screen

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D17682 To: amantia, dvratil Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18018: [Digital Clock] Add ability to change first day of week

pino added inline comments. INLINE COMMENTS > configCalendar.qml:68 > +model.append({ > +text: i18n("Default"), > +value: -1, this needs a context (using i18nc), otherwise translators have no idea what "Default" means REPOSITORY R120 Pl

D18018: [Digital Clock] Add ability to change first day of week

davidedmundson added a comment. Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: davidedmundson, ngraham, plasma-devel,

D17975: [WIP, Notifications] Add padding to notifications

davidedmundson added a comment. > How are you scaling plasma? Are you setting PLASMA_USE_QT_SCALING=1 to make sure it's really actually using the scale factor you set in the KScreen KCM? You don't need to set that. Plasma does it's own thing with fonts, fonts will be changed regardless.

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. > @filipf That looks about right! It's not. That's only within 5.x. This code has been around since at least ede349f8f2db9930c96ab4e56f9440ba82c24cb7 on kde-workspace which w