D17467: digital-clock: Show events on expanding applet

mbehrendt created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mbehrendt requested review of this revision. REVISION SUMMARY When expanding the digital-clock applet the holidayList is not updated, so that events for the current day are not shown. In

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein added a subscriber: ngraham. hein added a comment. It turns out we all collectively forgot about the "Switching" tab in the original KCM. Together with @ngraham we came up with a plan: - Drop the Shortcuts settings for now. They're duplicated from the Shortcuts KCM. - Drop th

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 47240. hein added a comment. Add back nav wrap and OSD settings. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=46916&id=47240 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES

D17268: Fix warning

apol added a comment. ping REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17268 To: apol, #kirigami Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17438: [folder] Initialise LabelGenerator::m_labelMode

apol added a comment. In D17438#373627 , @davidedmundson wrote: > That patch needs backporting to stable. > > I'll do that now. ^^' thanks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17438 To: da

D17375: Don't automatically refresh if the user already asked apt to do so

apol abandoned this revision. apol added a comment. It's landed, phabricator doesn't let me just close it. https://commits.kde.org/discover/30de60f05d183e185724e614aad67b06aec987f3 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17375 To: apol, #kub

D17375: Don't automatically refresh if the user already asked apt to do so

apol added a comment. This is apt-specific code, so if apt distros are happy with it, then it's as good as it gets. It could make sense to do the same for other distros, but that's a different battle. I'll land on 5.14. REPOSITORY R134 Discover Software Store REVISION DETAIL http

D17464: [Timer applet] Minor fixes for the applet

gepardo updated this revision to Diff 47224. gepardo added a comment. Add a comment about value 0.77 REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17464?vs=47219&id=47224 BRANCH timer-on-panel-fix (branched from master) REVISION DETAIL https://

D17464: [Timer applet] Minor fixes for the applet

gepardo added inline comments. INLINE COMMENTS > davidedmundson wrote in TimerView.qml:53 > never set size hints from current size, you're asking for binding loops. > > setting it based on the implicitWith is ok Can't get it work with `implicitWidth` and `implicitHeight`. By the way, when usin

D17464: [Timer applet] Minor fixes for the applet

davidedmundson added inline comments. INLINE COMMENTS > gepardo wrote in TimerView.qml:65 > As I remember, I was trying to make the digits size of timer equal nearer to > clock font size. Setting this to `1.0` won't break anything, but the digits > will take the full height of the panel. > > B

D17464: [Timer applet] Minor fixes for the applet

gepardo added inline comments. INLINE COMMENTS > davidedmundson wrote in TimerView.qml:65 > where has 0.77 come from As I remember, I was trying to make the digits size of timer equal nearer to clock font size. Setting this to `1.0` won't break anything, but the digits will take the full heigh

D17464: [Timer applet] Minor fixes for the applet

gepardo added inline comments. INLINE COMMENTS > davidedmundson wrote in TimerView.qml:46 > what if it's neither (i.e on the desktop) ? Doesn't it use the default sizing settings (as used before this patch)? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17464

D17464: [Timer applet] Minor fixes for the applet

davidedmundson added a comment. Cool. INLINE COMMENTS > TimerView.qml:46 > +states: [ > +State { > +name: "verticalPanel" what if it's neither (i.e on the desktop) ? > TimerView.qml:53 > +Layout.fillWidth: true > +Layout.maximumHeight:

D17464: [Timer applet] Minor fixes for the applet

gepardo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gepardo requested review of this revision. REVISION SUMMARY BUG: 395182 BUG: 361025 Here are the changes made: - Allow Timer widget to work well on panels, both vertical and horizo

D17154: Go back to SCSS

gepardo added a comment. This patch is not reviewed for two weeks. How soon can I get some feedback on it? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze Cc: ngraham, jackg, plasma-devel, ragreen, Pitel, ZrenBot, les

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2, #plasma, #vdg, ngraham Cc: abetts, ngraham, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna

D17410: Add alternatives button to applet configuration in panel edit mode

davidedmundson added a comment. > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) onVisualParentChanged function, but it doesn't work... Use console.log to check your code is being called at the right time. Also search for contextualActionsAboutToShow in other co

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. I think I'll have to use Gimp. When is the deadline? :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmundson Cc: alexde, raddison, romangg, davidedmundson, rizzitello, abetts,

D17458: Add help button to KCMs where it was missing

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BUG: 401932 TEST PLAN Opened each REPOSITORY R119 Plasma Desktop BRANC

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

ngraham added a comment. #plasma folks, any comments, or shall we land this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, alexde, Ioh

D17440: Rotate busy indicator clockwise

This revision was automatically updated to reflect the committed changes. Closed by commit R858:56fb6a3de989: Rotate busy indicator clockwise (authored by GB_2, committed by ngraham). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17

D17440: Rotate busy indicator clockwise

ngraham added a comment. Yep, the PC one already does go clockwise REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D17440 To: GB_2, #breeze, #vdg, davidedmundson, ndavis Cc: ngraham, davidedmundson, broulik, ndavis, #vdg, plasma-devel, #bree

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. ngraham wrote: > I think this was actually a great design, because it ensured good contrast for the UI elements and labels, but allowed you to actually see most of the background wallpaper. F6466002: snapshot27.png

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. In D16031#373904 , @raddison wrote: > > but I don't see why the lock and login screens should necessarily be identical in design > > I do. The the login and lock screens should be visually consistent with each other.

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. > but I don't see why the lock and login screens should necessarily be identical in design I do. The the login and lock screens should be visually consistent with each other. It's a no-brainer. How do we mitigate that? REPOSITORY R120 Plasma Workspace REVISI

D17448: Revamp README

marcinse created this revision. marcinse added a reviewer: Aiix. marcinse added a project: MyCroft Integration. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. marcinse requested review of this revision. REVISION SUMMARY Hi, I cleaned up and refreshed the README to rea