gepardo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in TimerView.qml:53
> never set size hints from current size, you're asking for binding loops.
> 
> setting it based on the implicitWith is ok

Can't get it work with `implicitWidth` and `implicitHeight`.

By the way, when using `parent.width` and `parent.height` it works OK (but 
`parent.implicitWidth` and `parent.implicitHeight` don't work correctly). Is it 
OK or are there other ideas how to rewrite this part of code?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to