[kio-extras] [Bug 329687] previewing an HTML file from a local file system causes network retrievals while generating the thumbnail

https://bugs.kde.org/show_bug.cgi?id=329687 Stefan Brüns changed: What|Removed |Added CC||stefan.bruens@rwth-aachen.d |

D17233: Only cancel job when an "error" is set and ignore "interrupted"

fvogt added a comment. LGTM otherwise. INLINE COMMENTS > downloadjob.cpp:152 > +const QString error = it->toString(); > +if (!error.isEmpty()) { > if (error == QLatin1String("USER_CANCELED") You could change this into QString error = payload.value(QStringLiter

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. In D16031#368953 , @raddison wrote: > I've also looked at the test plan and it's not exactly a stroke of genius if it looks like https://phabricator.kde.org/file/data/w3iyc7eov3ys6kmhrwi7/PHID-FILE-nya3nyqpjbmnijijvlwm/S

D17268: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY .../kirigami.2/templates/AbstractApplicationHeader.qml:113: TypeError: Cannot read property 'globalToo

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. In D16031#368865 , @ngraham wrote: > In D16031#368861 , @raddison wrote: > > > @ngraham Is it going to look something like that? https://phabricator.kde.org/file/data/zaerj

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17263 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

apol updated this revision to Diff 46572. apol added a comment. Clean after destruction REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17263?vs=46571&id=46572 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17263 AFFECTED FILES src/dele

D17263: DelegateRecycler: Don't create a new propertiesTracker for every delegate

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It should make setSourceComponent a bit lighter REPOSITORY R169 Kirigami BRANCH master REVISION

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. In D16031#368861 , @raddison wrote: > @ngraham Is it going to look something like that? https://phabricator.kde.org/file/data/zaerjwktbynwubnvu3ja/PHID-FILE-y52h6nwujyugxuqkc73z/maxresdefault.jpg No, screenshots f

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. In D16031#368787 , @ngraham wrote: > In D16031#368739 , @raddison wrote: > > > > Still I find the original version with full blur and darkened background way better to read

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. In D16031#368739 , @raddison wrote: > > Still I find the original version with full blur and darkened background way better to read for many background pictures. I don't think it's wort it to sacrifice this usability fac

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. > Still I find the original version with full blur and darkened background way better to read for many background pictures. I don't think it's wort it to sacrifice this usability factor to allow a better view of the background. I think the same. Sacrificing the

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 46554. hein added a comment. Handle KWin restarts REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=46551&id=46554 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES kcmkwin/kwindes

D16873: [comic] Request current identifier on date changed

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16873 To: anthonyfieroni, #plasma, davidedmundson, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16856: [comic] Sync configuration on write

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16856 To: anthonyfieroni, #plasma, davidedmundson Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 46551. hein added a comment. Rebase on master for good measure REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=46545&id=46551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14542 AFFECTED FILES kc

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein updated this revision to Diff 46545. hein added a comment. Fix syncing to server. Fixes take various shapes: - Fix bug on our side. - Handle weird KWin behavior, such as emiting desktopRowsChanged with an unchanged value. - s/onAccepted/onEditingFinished on the rename TextFi

D17233: Only cancel job when an "error" is set and ignore "interrupted"

broulik updated this revision to Diff 46536. broulik retitled this revision from "Delay finishing download when state changes to "interrupted"" to "Only cancel job when an "error" is set and ignore "interrupted"". broulik edited the summary of this revision. broulik edited the test plan for this