D16658: Respect the display property of buttons

astippich updated this revision to Diff 46372. astippich added a comment. - use hasOwnProperty and add fixme comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=45424&id=46372 BRANCH display_property REVISION DETAI

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added a comment. Thanks @davidedmundson. @mart, is this okay now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16879 To: ngraham, davidedmundson, #vdg, #plasma Cc: mart, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 46365. ngraham added a comment. Revert unnecessary ActionButton shadows (will move into the other patch) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=46364&id=46365 BRANCH lock-and-login-screen-co

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 46364. ngraham added a comment. Harmonize the clocks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=45962&id=46364 BRANCH lock-and-login-screen-contrast-tweaks (branched from master) REVISION DETAI

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added inline comments. INLINE COMMENTS > mart wrote in ActionButton.qml:41 > those and the stronger shadows to the clock seems unrelated, as on this > contrast is doing by darkening the background and not adding unneeded shadows. > this seems more the unrelated change to the login screen

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

davidedmundson added a comment. Two really minor comments, but in general all seems good from my POV. +1 INLINE COMMENTS > Clock.qml:47 > +text: Qt.formatTime(timeSource.data["Local"]["DateTime"]) > +font.pointSize: 48 //Mockup says this, I'm not sure what to do? >

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham abandoned this revision. ngraham added a comment. Looks like the conclusion is that this isn't the right change. I would advocate for returning to an "advanced settings" dialog or sub-page to hold these settings, and then we wouldn't have to be so shy about presenting technical terms

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

ngraham added a comment. Friendly ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16901 To: ngraham, #plasma, #vdg, hein Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel created this revision. thsurrel added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY The task manager context menu offers to _add_ applications to activities, but the main u

D17187: Set the default cursor theme to breeze_cursors

fvogt added a comment. In D17187#367110 , @wbauer wrote: > Actually, if the cursor theme is not set to anything, GTK would just use the session's default. I.e. this patch should not be necessary in the first place. If it is set though, t

D17187: Set the default cursor theme to breeze_cursors

wbauer added a comment. Actually, if the cursor theme is not set to anything, GTK would just use the session's default. And that's how it should be IMHO. But at least in openSUSE, the cursor theme is explicitly set to Adwaita in the system-wide GTK config, /etc/gtk-3.0/settings.ini . REPOS

D17187: Set the default cursor theme to breeze_cursors

This revision was automatically updated to reflect the committed changes. Closed by commit R98:dcacaa1d4f7e: Set the default cursor theme to breeze_cursors (authored by fvogt). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17187?vs=46316&id=46333 REVIS

Plasma 5.14.4

Plasma 5.14.4 is now released https://www.kde.org/announcements/plasma-5.14.4.php

D17177: Drop tab-based UI for the about page

ngraham added a comment. Yeah, I did prefer it in the toolbar. I think that actually makes it more prominent, not less. If we are worried about people sending the developers too many emails, we could de-emphasize the email address. The current UI just uses a tiny button which seems adequatel

D17177: Drop tab-based UI for the about page

apol added a comment. In D17177#366890 , @ngraham wrote: > Looks fantastic! > > Could we put the bug report button on the toolbar, maybe? It looks a bit odd just sitting in the content view like that. It was on the last version. I cou

D17177: Drop tab-based UI for the about page

ngraham added a comment. Also, and I don't know if this is in Discover or the proposed new page, but the item in Discover's sidebar should match the page title and say "About", not "Help." REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: ap

D17177: Drop tab-based UI for the about page

ngraham added a comment. Looks fantastic! Could we put the bug report button on the toolbar, maybe? It looks a bit odd just sitting in the content view like that. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, lei

D17177: Drop tab-based UI for the about page

apol added a comment. F6443951: discover-about4.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, leinir Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46328. apol added a comment. Remove the bug reporting weirdness REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46324&id=46328 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17177

D17177: Drop tab-based UI for the about page

ngraham added a comment. Yeah, I think a "Report a bug!" button would be fine. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, leinir Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-

D17177: Drop tab-based UI for the about page

apol added a comment. In D17177#366883 , @ngraham wrote: > Well then Discover is setting the wrong information :) > > Can we have an updated screenshot if the last code change resulted in any visual changes? Ah you're right. Let's try

D17177: Drop tab-based UI for the about page

ngraham added a comment. Well then Discover is setting the wrong information :) Can we have an updated screenshot if the last code change resulted in any visual changes? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #v

D17177: Drop tab-based UI for the about page

apol added a comment. In D17177#366500 , @ngraham wrote: > Looks much better visually! But something about the bugDisplay looks wrong. Right now it's recommending that people send bugs via email. No it's not, it's recomending to go to bug

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. I worry that this distorts the UI by giving the back button the same visual weight as the open KCM's title. I'm not categorically against it because I do see the advantage of improving the alignment, but something about it just feels kind of off to me in its current

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. F6443914: image.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D17192: use a Kirigami Heading for perfect consistency

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Make the title of the submodules column a Kirigami Heading so that looks the same and is perfectly al

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46324. apol added a comment. Address Dan's concern REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46280&id=46324 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17177 AFFECTED FIL

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.11 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.11/11/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 27 Nov 2018 14:39:27 + Build duration: 15 min and counting CONSOLE OUTPUT [...trunc

D17187: Set the default cursor theme to breeze_cursors

ngraham added a comment. Can you land this on the stable branch? REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D17187 To: fvogt, #plasma, ngraham Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D17187: Set the default cursor theme to breeze_cursors

broulik added a comment. +1 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17187 To: fvogt, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.11 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.11/14/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 27 Nov 2018 14:39:44 + Build duration: 12 min and counting CONSOLE OUTPUT [...t

D17187: Set the default cursor theme to breeze_cursors

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh gosh, so this is where that bug comes from. I've seen new users get really confused by this the first time they open up Firefox. +1 REPOSITORY R98 Breeze for Gtk BRANCH master RE

D17187: Set the default cursor theme to breeze_cursors

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Currently the cursor theme is not set by anything, so it's Adwaita by default. TEST PLAN New user account has "Breeze" as cursor theme in kde-

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.11 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.11/11/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 27 Nov 2018 14:35:26 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/13/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Tue, 27 Nov 2018 14:35:26 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT [

D17177: Drop tab-based UI for the about page

leinir added a comment. Ah yes, somehow i managed to miss the button @colomar mentions, which does the bug reporting linkage already. Removing the link in favour of just keeping that button seems a sensible option :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabri

D17177: Drop tab-based UI for the about page

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress

D17177: Drop tab-based UI for the about page

colomar added a comment. Integrating it in one page is definitely an improvement! Some detailed comments (I am aware that those things introduced with this layout change, they just become apparent now): 1. "About" at the top of the page and "About Discover..." are redundant. I'd recom

D16968: [Folder View] improve label contrast against challenging backgrounds

This revision was automatically updated to reflect the committed changes. Closed by commit R119:10278e79f116: [Folder View] improve label contrast against challenging backgrounds (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1696

D4929: DrKonqi : lldb and Mac support

rjvbb marked an inline comment as done. rjvbb added a comment. David, it seems our posts crossed, or did you actually see the new version I just uploaded? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces, kfunk, davidedmundson Cc: p

D4929: DrKonqi : lldb and Mac support

rjvbb updated this revision to Diff 46309. rjvbb marked 2 inline comments as done. rjvbb added a comment. Fixed the AppleTerminal oversight in the non-Apple lldbrc. Also, I've removed the m_lldbDetached backend-specific member var. Instead, I now use the `m_proc` variable itself, and whic

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 78 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/78/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 27 Nov 2018 06:37:42 + Build duration: 1 hr 32 min and counting JUnit Tests Name: (root) Failed: 9

D4929: DrKonqi : lldb and Mac support

rjvbb marked 3 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > davidedmundson wrote in lldbrc:7 > Linux has lldb too > > I assumed that's why you also had a "src/data/debuggers/external.mac/lldbrc" > as well as this file. Ah, oops, good catch! Evidently the non-Mac ver