leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed.
It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress <https://api.kde.org/frameworks/kcoreaddons/html/classKAboutData.html#aae353f5b138848c71a04b903171e4c3b> can be either an email address, or a URL, though, so it might make sense to try and handle either case (something as simple as checking for :// in the string would probably work), to make the functionality here functionally equivalent to the qwidget dialogue. At the same time, though, given that Discover's /is/ an email address... would it perhaps make sense to at least add bugs.kde.org as a link? (or, some other way of adding a secondary link for reports... though that does seem to be veering somewhat outside the scope of this particular patch) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17177 To: apol, #plasma, #vdg, leinir Cc: leinir, colomar, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
