D16977: [weather] Fix broken observation display for temperature of 0 °

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:0d379c5957e2: [weather] Fix broken observation display for temperature of 0 ° (authored by kossebau). REPOSITORY R11

D17073: Do not crop albumArt

trmdi added a comment. In D17073#364393 , @ndavis wrote: > That blur looks nice, but I think the background should be more opaque like the Elisa header background.F6437066: Screenshot_20181122_005432.png

D4929: DrKonqi : lldb and Mac support

davidedmundson added a comment. > Making DrKonqi standalone is a good step, I'd strongly suggest to move it to KF5 Applications at the first possible occasion. That'll probably be when we move to Qt6. Ultimately it'd still be the same tarball just in a different folder on an FTP sit

D17112: Allow disabling the build of the file dialog component

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. You can't run plasma without KIO. It's used elsewhere. If you're not running plasma, you shouldn't be using plasma-integration. REPOSITORY R135 Integration for

D17113: Allow disabling KPackage install while building Breeze

davidedmundson added a comment. Why? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D17113 To: ntninja, mart, ngraham, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17113: Allow disabling KPackage install while building Breeze

ntninja created this revision. ntninja added reviewers: mart, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ntninja requested review of this revision. REVISION SUMMARY Truth to be told, I'm not 100% sure what this step actually does, but breeze

D4929: DrKonqi : lldb and Mac support

rjvbb updated this revision to Diff 46044. rjvbb added a comment. includes the root cmake file changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4929?vs=46025&id=46044 REVISION DETAIL https://phabricator.kde.org/D4929 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt s

D17112: Allow disabling the build of the file dialog component

ntninja created this revision. ntninja added reviewers: mlaurent, jriddell, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ntninja requested review of this revision. REVISION SUMMARY While this of course considerbly reduces functionality it makes it possible to

D4929: DrKonqi : lldb and Mac support

rjvbb added a comment. > a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists file. Ah, thanks. I have that in my own cmake file of course, but also an unrelated change I thought I could safely keep out by just taking a diff of the `src` directory. I test DrKon

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.11 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.11/13/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 22 Nov 2018 20:34:18 + Build duration: 1 min 58 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.11 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.11/13/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 22 Nov 2018 20:34:18 + Build duration: 1 min 53 sec and counting

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists file. CMake Error at src/CMakeLists.txt:84 (add_executable): Target "drkonqi" links to target "KF5::WindowSystem" but the target was not found. Perhaps a find_package()

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.11 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 22 Nov 2018 19:42:23 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT [...truncated 158.91

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.11 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.11/12/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 22 Nov 2018 19:42:23 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...truncated 1

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

This revision was automatically updated to reflect the committed changes. Closed by commit R871:515425143cb3: debugger: DataLocation is deprecated, move to AppDataLocation (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17024?vs=4

D17073: Do not crop albumArt

ndavis added a comment. That blur looks nice, but I think the background should be more opaque like the Elisa header background.F6437066: Screenshot_20181122_005432.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D170

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. After taking a second look on it, I was able to merge the patch from the `src`folder and not from the repository root folder, weird.. Will do the tests here and now ! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb,

D4929: DrKonqi : lldb and Mac support

rjvbb added a comment. > Can you rebase it over the last master branch ? I did that hours ago, or at least I thought I did?! Is there a commit later than 62c33ba3a885106f31706cbfecc75190ca00c70c which I someho

D17107: global menu,rename menuHidden to visible

mvourlakos created this revision. mvourlakos added reviewers: Plasma, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --as @mart requested we can rename "menuHidden" property to "visib

D16715: make global menu minimize state aware

mvourlakos added a comment. included in D16768 and I will upload a new patch to rename menuHidden -> visible as @mart requested REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16715 To: mvourlakos, #plasma, broulik, davi

D16805: improve variable name for global menu model

mvourlakos abandoned this revision. mvourlakos added a comment. included in D16768 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16805 To: mvourlakos, #plasma, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, Z

D16768: mage global menu screen aware

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3fa1cc6b7716: mage global menu screen aware (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16768?vs=45243&id=46031 REVISION DETA

D16860: touchscreen text controls

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH phab/textcontrols REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #plasma, apol Cc: apol, broulik, plasma-dev

D17105: Add a new lookandfeel runner

apol updated this revision to Diff 46028. apol added a comment. LnF themes don't really have an icon REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17105?vs=46027&id=46028 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17105 AFFECTE

D17105: Add a new lookandfeel runner

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY I was using my laptop in the dark and hoping I could tone my colors down, thought this could be convenient

D16860: touchscreen text controls

mart added a comment. In D16860#364161 , @apol wrote: > isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger? i don't think we can know that fr

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. Can you rebase it over the last master branch ? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces, kfunk Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, kde-mac, ragreen, P

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#364263 , @apol wrote: > In D17079#364163 , @ltoscano wrote: > > > In D17079#364157 , @mart wrote: > > > > > I think this

D4929: DrKonqi : lldb support

rjvbb updated this revision to Diff 46025. rjvbb added a comment. Refactored for the standalone DrKonqi repo and disabled the integration testing on Mac. Making DrKonqi standalone is a good step, I'd strongly suggest to move it to KF5 Applications at the first possible occasion. The util

D4929: DrKonqi : lldb support

rjvbb marked an inline comment as done. rjvbb added a comment. Sorry, I had updating this on my list but it drifted to the bottom... I think I've addressed all feedback apart from the `m_lldbDetached` variable Kevin objected to. I'm open to suggestions how to make that aspect less eyebro

D17064: datetime runner: Match timezones less restrictively

apol closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17064 To: apol, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17080: Make it possible to fallback to a different icon

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17080 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#364163 , @ltoscano wrote: > In D17079#364157 , @mart wrote: > > > I think this ui should really go into KCoreAddons itself. Would it be accepted there? > > > kco

D17102: Connect to contextMenu clicked callback only once

This revision was automatically updated to reflect the committed changes. Closed by commit R856:453b420ceb42: Connect to contextMenu clicked callback only once (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17102?vs=46

D17102: Connect to contextMenu clicked callback only once

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The connection isn't bound to the menu entry but global causing the handler

D16889: Listen to KDE Connect device signals

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b4a5f02482f6: Listen to KDE Connect device signals (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16889?vs=46015&id=46016

D16889: Listen to KDE Connect device signals

broulik updated this revision to Diff 46015. broulik added a comment. - Check earlier REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16889?vs=46013&id=46015 REVISION DETAIL https://phabricator.kde.org/D16889 AFFECTED FILES host/kdec

D16889: Listen to KDE Connect device signals

broulik updated this revision to Diff 46013. broulik added a comment. Herald added a project: KDE Connect. Herald added a subscriber: kdeconnect. - Check if device is already known just before emitting REPOSITORY R224 KDE Connect CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1688

D16889: Listen to KDE Connect device signals

broulik updated this revision to Diff 46012. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16889?vs=46011&id=46012 REVISION DETAIL https://phabricator.kde.org/D16889 AFFECTED FILES extension/extension.js host/kdeconnectplugin.cpp h

D16889: Listen to KDE Connect device signals

broulik updated this revision to Diff 46011. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16889?vs=45496&id=46011 REVISION DETAIL https://phabricator.kde.org/D16889 AFFECTED FILES extension/extension.js host/kdeconnectplugin.cpp h

D17073: Do not crop albumArt

trmdi updated this revision to Diff 46007. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=45950&id=46007 REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES applets/taskmanager/pa

D4929: DrKonqi : lldb support

patrickelectric added a comment. This revision now requires changes to proceed. What is the actual state of this patch ? REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces, kfunk Cc: patrickelectric, kfunk, mart, broulik, kde-mac, plasma-devel, ragreen, Pitel,

D17079: Provide a qqc2/kirigami-based about page

ltoscano added a comment. In D17079#364157 , @mart wrote: > I think this ui should really go into KCoreAddons itself. Would it be accepted there? kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, kirigami-addons (

D16860: touchscreen text controls

apol added a comment. isn't this a bit too binary? Maybe it makes sense to have hover effects even if on tablet mode. isn't it a matter of whether it comes from a finger? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16860 To: mart, #pla

D17079: Provide a qqc2/kirigami-based about page

mart added inline comments. INLINE COMMENTS > DiscoverWindow.qml:76 > } > +TopLevelPageData { > +id: aboutAction can you try how does it look for this page to be pushed as a layer instead of the main PageRow? would be like applicationWindow().pageStack.layers.push(thecomponento

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. I think this ui should really go into KCoreAddons itself. Would it be accepted there? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragree

Re: Relicensing of file in plasma-phone-components

Hi Bhushan, i'm fine as well going to LGPL On Wed, Nov 21, 2018 at 5:21 PM Martin Klapetek wrote: > > Hi, > > I'm fine with relicensing my contributions to > plasma-phone-components/dialer/src/dialerutils.* > code from GPL2 to either GPL2+ or LGPL. > > Cheers > -- > Martin Klapetek > > > On Sun,

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#363975 , @ngraham wrote: > Cool! > > For this design, I'd like to get rid of the tabs and put everything in a scrollview. We generally have enough space that a tabbed view is overkill. +1 REPOSITORY

D17079: Provide a qqc2/kirigami-based about page

leinir added a comment. Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact th

D17094: Fixed comic widget context menu crash

anthonyfieroni added inline comments. INLINE COMMENTS > comic.cpp:527 > +mActionScaleContent->setEnabled(false); > +mActionShop->setEnabled(false); > +mActionStorePosition->setEnabled(false); Check against nullptr like else branch? REPOSITORY R114 Plasma Addons REVISI

D17095: Fixed comic widget crash

pavelmos added inline comments. INLINE COMMENTS > anthonyfieroni wrote in comic.cpp:196 > Just move this after brace. Yes, I agree. Your remark is true REVISION DETAIL https://phabricator.kde.org/D17095 To: pavelmos, jriddell, bshah, davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel,

D17095: Fixed comic widget crash

pavelmos updated this revision to Diff 45996. pavelmos marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17095?vs=45995&id=45996 REVISION DETAIL https://phabricator.kde.org/D17095 AFFECTED FILES applets/comic/comic.cpp To: pavelmos, jriddell, bshah,

D17095: Fixed comic widget crash

anthonyfieroni added a reviewer: Plasma. anthonyfieroni added inline comments. INLINE COMMENTS > comic.cpp:196 > updateComic( previousIdentifierSuffix ); > return; > } Just move this after brace. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabr

D17095: Fixed comic widget crash

pavelmos created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Crash happens on trying to load an unsupported format content such as video. To prevent a crash, the patch blocks the loading of

D17094: Fixed comic widget context menu crash

pavelmos created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pavelmos requested review of this revision. REVISION SUMMARY Crash happens on trying to use the context menu of widget with no active comics. The patch disables some items in this context

D17076: Avoid indeterminism in kcolorschemeeditor

bmwiedemann added a comment. Can you please push it? I am contributing so rarely, that it is not worth having commit access. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17076 To: bmwiedemann, rwooninck, ochurlaud Cc: plasma-devel, ragree

D17073: Do not crop albumArt

ndavis added a comment. If you want to try adding blur to the background, check out the code here: https://cgit.kde.org/elisa.git/tree/src/qml/HeaderBar.qml#n53 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc:

D17073: Do not crop albumArt

ndavis added a comment. In D17073#364003 , @trmdi wrote: > How about this ? > F6436415: test.png I think this version works much better than the other 2. It shows the entire image and it fills up

D17073: Do not crop albumArt

anthonyfieroni added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17073: Do not crop albumArt

trmdi added a comment. How about this ? F6436415: test.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot,

D16873: [comic] Request current identifier on date changed

anthonyfieroni added a comment. @davidedmundson have more little fixes over applet did you something suspicious here, i plan to commit them before 5.14.4 release. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16873 To: anthonyfieroni, #plasma, davidedmundson