rjvbb updated this revision to Diff 46025. rjvbb added a comment.
Refactored for the standalone DrKonqi repo and disabled the integration testing on Mac. Making DrKonqi standalone is a good step, I'd strongly suggest to move it to KF5 Applications at the first possible occasion. The utility doesn't even depend on a single Plasma library and provides a service that has nothing Plasma-desktop specific. Instead, ask yourself if automatic crash reports are welcome only from Plasma desktop users or if as many users as possible should be able to submit crash reports (i.e. from any platform where DrKonqi is functional). Better, don't ask yourself, ask the entire family of KDE developers. On a related note: DrKonqi's dependencies have been bumped along with the other Plasma dependencies. That's overkill: it has no business requiring Qt 5.11, 5.9LTS provides all required APIs. Similarly, it builds just fine against KF5 Frameworks 5.47.0, possibly even earlier versions. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4929?vs=12368&id=46025 REVISION DETAIL https://phabricator.kde.org/D4929 AFFECTED FILES src/CMakeLists.txt src/aboutbugreportingdialog.cpp src/backtracegenerator.cpp src/backtracegenerator.h src/backtracewidget.cpp src/bugzillaintegration/reportassistantdialog.cpp src/data/AppleTerminal src/data/CMakeLists.txt src/data/debuggers/external.mac/gdbrc src/data/debuggers/external.mac/kdbgrc src/data/debuggers/external.mac/lldbrc src/data/debuggers/external/lldbrc src/data/debuggers/internal/lldbrc src/debugger.cpp src/debugger.h src/drkonqibackends.cpp src/drkonqidialog.cpp src/main.cpp src/parser/CMakeLists.txt src/parser/backtraceparser.cpp src/parser/backtraceparserlldb.cpp src/parser/backtraceparserlldb.h src/tests/CMakeLists.txt To: rjvbb, #plasma_workspaces, kfunk Cc: patrickelectric, kfunk, mart, broulik, kde-mac, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
