D16968: [Folder View] improve label contrast against challenging backgrounds

2018-11-17 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, hein, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently the shadow behind Folder View items' labels is very subtle. This leads to poo

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.11 - Build # 70 - Still unstable!

2018-11-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.11/70/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 18 Nov 2018 03:03:08 + Build duration: 1 hr 33 min and counting JUnit Tests Name: (root) Failed: 9

D16890: [systemtray] Keep config entries after modifying

2018-11-17 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This does fix 390890 for me though! Everything else still seems to work. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16890 To: anthonyfieroni, #plas

D16890: [systemtray] Keep config entries after modifying

2018-11-17 Thread Nathaniel Graham
ngraham added a comment. In D16890#359757 , @anthonyfieroni wrote: > Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect. That's a separate bug: https://bugs.kde.org/show_bu

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.11 - Build # 79 - Fixed!

2018-11-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.11/79/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sun, 18 Nov 2018 03:03:08 + Build duration: 8 min 54 sec and counting

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Roman Gilg
romangg added a comment. In D16937#361203 , @filipf wrote: > Eike's Simple Menu is a good example of separator use - the separator is subtle and doesn't fully break up the the plasmoid: > > F6429446: Screenshot_20181117_234118.png

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Root
rooty updated this revision to Diff 45696. rooty added a comment. - Raise the separator opacity by 0.05 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16937?vs=45680&id=45696 BRANCH kickoff-leaner-separators (branched from master) REVISION DETAIL

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Filip Fila
filipf added a comment. Eike's Simple Menu is a good example of separator use - the separator is subtle and doesn't fully break up the the plasmoid: F6429446: Screenshot_20181117_234118.png On top of that he made the search field unfocused by d

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Root
rooty added a comment. In D16937#361182 , @ngraham wrote: > I could get behind reducing the opacity. Perhaps to 0.7 or 0.6. Removing the frame for the scroll area to get rid of the extra lines on the top or bottom when it's scrollable could also

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Filip Fila
filipf added a comment. If we had a discussion on the level of the community on general approaches to design in the future, that would really allow for better orientation in changes like these. It seems that excessive minimalism is something that is going to be overcome, but there is al

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Nathaniel Graham
ngraham added a comment. I could get behind reducing the opacity. Perhaps to 0.7 or 0.6. Removing the frame for the scroll area to get rid of the extra lines on the top or bottom when it's scrollable could also make sense now that these lines are a part of the design. But I'll need a bit of

qdbus kactivities - delete all stats

2018-11-17 Thread Thomas Weissel
hello everybody. i'm currently refining my digital-exam environment based on kde plasma for schools and could use some help. i need to be able to delete all recent documents from all applications via qdbus i know i can do that from systemsettings > desktop behaviour > activities but it needs to b

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Root
rooty updated this revision to Diff 45680. rooty added a comment. - Change focus: false back to focus: true (change not required, a slip) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16937?vs=45679&id=45680 BRANCH kickoff-leaner-separators (bran

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Root
rooty updated this revision to Diff 45679. rooty added a comment. - Fix double separator issue left over from master (remove scrolling frame) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16937?vs=45618&id=45679 BRANCH kickoff-leaner-separators (

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Root
rooty added a comment. Okay so, it took me a while to figure out (total noob here I'm telling you) - the key was to add frameVisible:false at line 60 of KickoffListView.qml. Then the extra (overlapping) separators are gone. Check it out: F6428936: image.png

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Root
rooty added a comment. > Are these problems because of your change or on current master as well? Are they something worth fixing in your opinion? > > Otherwise visually would be a nice change. Current lines are too strong. Actually, the bugs are already present in master, and using a

D16937: Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

2018-11-17 Thread Roman Gilg
romangg added a comment. In D16937#360676 , @rooty wrote: > > FWIW make sure to test your changes with all four possible orientations. > > I actually figured out how to do that just before my latest edit, my bad. It seems to work sort of fine

D16945: Fix fallback to built-in ui

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY If the lock screen package is not available m_mainQmlPath is an empty URL. Thus view->setS

D16943: Disable kcrash in greeter in same way as in KWin

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY When running KWin's lock screen test I saw: KCrash: crashing... crashRecursionCoun

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

2018-11-17 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16595 To: aacid, #plasma, davidedmundson, mart Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart