romangg added a comment.

  In D16937#360676 <https://phabricator.kde.org/D16937#360676>, @rooty wrote:
  
  > > FWIW make sure to test your changes with all four possible orientations.
  >
  > I actually figured out how to do that just before my latest edit, my bad. 
It seems to work sort of fine with the tabs on the left or the right, except 
for the lower separator (to the left/right of the tabs on the right or left, 
respectively) that seems to appear shorter than the length of the separator to 
the left/right of the tab bar before you start scrolling to the bottom.
  >
  > ...
  >
  > I don't know if this was on purpose or if it's a bug, but the bottom 
separator becomes thicker to the left/right of the tab bar before/when you 
start flicking through the menus in the previous design (no opacity settings / 
width: root.width) before reaching the end (of a given menu)
  >
  > ...
  
  
  Are these problems because of your change or on current master as well? Are 
they something worth fixing in your opinion?
  
  Otherwise visually would be a nice change. Current lines are too strong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16937

To: rooty, ngraham, #vdg
Cc: romangg, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to